glacambre / firenvim Goto Github PK

No idea why this might happen

Just a suggestion: did you try TCP_NODELAY? This should probably be done on both ends.

If there is already text in the textarea then it gets loaded into the vim buffer but changes dont get set on quitting the client

i get the following error in the console

NeovimFrame.ts:120 Uncaught (in promise) TypeError: Cannot read property 'match' of undefined
    at NeovimFrame.ts:120
    at Array.find (<anonymous>)
    at NeovimFrame.ts:120

OS: Fedora 30
Browser: Chrome 1569574344
Nvim: 0.4.2

This is needed because Chrome can't handle SVGs. Most existing packages require other tools (e.g. inkscape) to exist in $PATH which seems completely absurd to me, so I'll probably need to write my own webpack loader.

Probably just need a 10ms timeout and then calling .focus() on the frame again.

Should be easy to fix: listen for scroll events, add a 10ms timeout, grab the element's new position, reposition the iframe over it.

Is it possible to support chrome ?

This isn't currently possible because the content script assumes it's in the content - while the preference page is in the background script.

There must be a way to fix this since Firefox doesn't.

We currently use a colored square which isn't very pretty.

Happens on https://drewdevault.com/donate/

Currently, fancy editors aren't supported.

• Ace: https://ace.c9.io/
• CodeMirror: https://codemirror.net/

Anything else?

If I have a long multiline doc and hold down e.g. j in the embedded nvim, only the first j reaches the editor seemingly, and the cursor stays on the second line down rather than scrolling line-by-line.

Not sure if there's anything I can provide for diagnosis or if this can be reproduced by others.

Since Firenvim now supports both Firefox and Chromium, I should probably set up E2E tests to avoid breaking things for Chromium users.

It would be nice to be able to use firenvim on Riot/Reddit.

Somebody on Matrix asked for Google Docs support.

This happens because we use v:progpath in order to get an absolute path to the neovim binary (this is needed because on OSX $PATH doesn't contain neovim).
Solving this requires detecting we're running in an appimage (checking if progpath points to somewhere in /tmp is probably enough) and finding the "real path" of that appimage.
Until this issue is fixed, a simple workaround is to just manually edit ~/.local/share/firenvim/firenvim to make it point to the right path.

Someone on reddit asked for Safari support, which seems doable but might require a very different background script.

Input fields often are too small for the smallest possible neovim frame (3 lines). It'd be nicer if the iframe adujsted its size to that.

• OS Version: macOS Mojave 10.14.6
• Browser Version: Firefox Quantum 69.0.1
• What I tried to do: Open firenvim in a tab, then close the tab without
  quitting nvim
• What happened: a process is orphaned (noticeable via ps aux | rg firenvim)
• What I expected: the process should die when the tab dies, throwing away the
  contents

The characters in this string get really tall rows. This can probably be fixed with a bit of CSS.

­؀؁؂؃؄؅؜۝܏᠎​‌‍‎‏‪‫‬‭‮⁠⁡⁢⁣⁤⁦⁧⁨⁩𑂽𛲠𛲡𛲢𛲣𝅳𝅴𝅵𝅶𝅷𝅸𝅹𝅺󠀁󠀠󠀡󠀢󠀣󠀤󠀥󠀦󠀧󠀨󠀩󠀪󠀫󠀬󠀭󠀮󠀯󠀰󠀱󠀲󠀳󠀴󠀵󠀶󠀷󠀸󠀹󠀺󠀻󠀼󠀽󠀾󠀿󠁀󠁁󠁂󠁃󠁄󠁅󠁆󠁇󠁈󠁉󠁊󠁋󠁌󠁍󠁎󠁏󠁐󠁑󠁒󠁓󠁔󠁕󠁖󠁗󠁘󠁙󠁚󠁛󠁜󠁝󠁞󠁟󠁠󠁡󠁢󠁣󠁤󠁥󠁦󠁧󠁨󠁩󠁪󠁫󠁬󠁭󠁮󠁯󠁰󠁱󠁲󠁳󠁴󠁵󠁶󠁷󠁸󠁹󠁺󠁻󠁼󠁽󠁾󠁿

After running close_server, nvim prompts Press ENTER or type command to continue on stderr. This might be related to neovim/neovim#9358.
Could also be related to neovim/neovim#11166.

This should be fairly easy to do:

• Have a :FirenvimInstall command that creates a {power,}shell script in ~/.local/share/firenvim and puts the native manifest in ~/.mozilla/native-messaging-hosts
• On launch, have the neovim plugin open a tcp port (neovim/neovim#10084) and generate a security token, then send token+port number to firefox with stdioopen()
• Have the webextension open a websocket, send the token to the neovim plugin and then use regular msgpack-rpc messages until end of connection

This is probably going to make starting a new firenvim frame rather slow - we might want to instantiate one neovim process in the background in order to speed things up.

It's rather annoying to have to :q! these elements before being able to <Tab>/<Enter>.

Otherwise they fight over who gets the keyboard events.

Hi.

I haven't spent much time thinking about how to implement this, but it seems to
me like there might be an argument to make that firenvim should always autosave
/ always write the buffer to the input box.

The argument is it's really low effort to delete the resulting text from the
textbox if you need to, but high risk if you throw away a really long comment.

I.e. the workflow I kind of expected was something like as soon as I left
focus from the input box, autoquit vim, autopopulate the input box, then if I
refocus, re-open.

Having an explicit save/quit via :q / :w / :x seems just a bit unnatural there
to me.

But yeah curious to hear what you think!

(I guess on the implementation side, even not having read yet how this works,
you just have JS always send :x or whatever at the end itself)

Happens on master. Reproducible on github. Prevents writing buffer content to textarea.

Using firenvim from 9c810f0 with Firefox 67 from openSUSE/Tumbleweed package is rather flawless on Github, somehow manageable on Reddit (it doesn't activate every time), but complete disaster on Bugzilla.

When I click on "Reply" link, I get this:

What looks like nvim frame scrolls up over the actuall <textarea> just to the one line height, which is really hard to use.

Someone on reddit said they wanted that and it sounds really reasonable.

As someone pointed out on reddit, this would probably be better.

So, with the latest release, we have it finally working in my Firefox. Thank you!

I like this extension very much, but even I have to admit that using it for input fields seems like a bit too much. Could we get an configuration (compile-time even) option to use it for textareas only?

Thank you.

Would be pretty useful.

The font-size is a little bit too small. Not sure what it's dependent on, but I'd like to be able to configure it if possible. Maybe even fully customizable CSS for the #host element?

https://developer.chrome.com/extensions/commands

If you create a command, then go to the extension keyboard shortcut settings and map ctrl-w to it, that will override the close tab shortcut. This may also work with firefox.

• Visit a github issue
• Try to edit it
• Click on the "cancel" button

The iframe should have disappeared but it didn't.

We need to implement something similar to what Firefox does (global browserAction, window-local or tab-local).

Getting permission denied.

> git clone [email protected]:~glacambre/firenvim

Cloning into 'firenvim'...
[email protected]: Permission denied (publickey,keyboard-interactive).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I had some trouble installing firenvim on Mac OS Mojave. I was wondering if anyone would be able to help me troubleshoot. I can post install logs, if that would help.

hope this tool can be used in windows too.

When running npm audit fix I get this change:

diff --git a/package.json b/package.json
index 763936d..3b68478 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
     "tslint": "^5.13.1",
     "tslint-sonarts": "^1.9.0",
     "typescript": "^3.3.3333",
-    "web-ext": "^3.0.0",
+    "web-ext": "^3.1.1",
     "webpack": "^4.29.6",
     "webpack-cli": "^3.2.3"
   },