Start creating and using https://github.com/reactjs/reselect, by having selectors we can make our code better. Easier to test and easier to reason about.

Also we can do this incrementally.

Add "fork" to Repository Actions

I don't know how much work it is to support iPad size classes but I would absolutely love to pay $10 for this conditional on supporting iPad (where I do most of my team communication - and development on my desktop). I get that it's a free download but I so badly want there to be a good iPad client :)

Would definitely be awesome to have the ability to edit and delete issue comments!

Is it possible to add GitHub Enterprise support to the app ?
Idea would be to add a GitHub Enterprise sign in button on launch screen in addition to the sign in button that will ask for the GitHub Enterprise URL and so redirect to the GitHub Enterprise url instead of GitHub.com

Causing by adding private repos that aren't loaded yet.

Github has a PR list view that displays only the PRs that have requested review from me but which I haven't reviewed. I frequently use this as a code review TODO list. It'd be great to have it available in git-point.

This isn't an issue, but more of a wish lish. Dark themes are nice and alot easier on the eyes. Love the app!

Would be nice if clicking the image on a user profile screen opens a modal screen that shows the image in full screen mode :)

Hi, thanks for this amazing project. I wanted to contribute in some way, but can't get the project to run since I am having this error in the packager:

error: bundling: UnableToResolveError: Unable to resolve module `config` from `/Users/frankdilo/projects/git-point/App.js`: Module does not exist in the module map or in these directories:
  /Users/frankdilo/projects/git-point/node_modules

This might be related to https://github.com/facebook/react-native/issues/4968
To resolve try the following:
  1. Clear watchman watches: `watchman watch-del-all`.
  2. Delete the `node_modules` folder: `rm -rf node_modules && npm install`.
  3. Reset packager cache: `rm -fr $TMPDIR/react-*` or `npm start -- --reset-cache`.
    at ResolutionRequest._resolveNodeDependency (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:394:11)
    at tryResolveSync (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:136:20)
    at tryResolveSync (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:66:12)
    at ResolutionRequest.resolveDependency (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:134:22)
    at dependencyNames.map.name (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:145:59)
    at Array.map (native)
    at ResolutionRequest.resolveModuleDependencies (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:145:42)
    at Promise.resolve.then (/Users/frankdilo/projects/git-point/node_modules/react-native/packager/src/node-haste/DependencyGraph/ResolutionRequest.js:169:21)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:169:7)
Bundling `index.ios.js`  25.0% (1/2), failed.

Hi,

Thanks for this nice app. I was wondering if it would be possible to use OAuth authentication or Personal Access Tokens to access my account rather than the username/password combo ?

Thanks again for your work.

Hey! I am trying to get this project started on my Windows machine to see if I could tackle an issue or two. RIght now I am having issues with the installation process, yarn run link:

Looks like you installed react-native globally, maybe you meant react-native-cli?
To fix the issue, run:
npm uninstall -g react-native
npm install -g react-native-cli

Running those two npm commands fixed nothing. Before forking the application, I did not have anything React Native installed on my machine. Any suggestions will help, thank you!

Screens that use a profile component (repository screen/user profile screen) should have white status bar text. Currently, the text is dark.

I've already exposed a barColor prop to modify this attribute in the ViewContainer component which is the wrapper for all screens in the application. However simply changing the value doesn't correctly change the status bar colour as it should, and this probably has to do with how we have nested stack navigations within tabs so it's most likely being overwritten.

Hey @housseindjirdeh I've seen quite some new issues in the project, what do you think about having a Roadmap with the most urgent features? I think we can use Github projects to make this happen.

Thanks!

When clicking Repositories on the authenticated user profile screen, the list of repositories that shows is only public (unless actually searched for --> that call will show a private repo)

This is most likely due to endpoint that's hit by getRepositories in the user.actions. Although /users/${user}/repos is correct for other users --> we'll have to conditionally set the endpoint to be /user/repos for the authenticated user in order to see private repos in the list.

App has crashed on taping on "Add carousel"
iOS 11, latest public beta atm

Video attached
2017-07-12 17.54.24.MOV.zip

Would be nice to have syntax highlighting for repository and pull request code in the app. For pull request diffs - this probably isn't trivial at all with they way I've set it up but worth looking into if we have the time :)

Definitely not a high priority however.

As of currently, actual commit information can't be viewed anywhere in the application. You may have already noticed that you can't even click a commit in the notifications screen to view it's details.

Would definitely be nice to:

• have the number of commits when viewing the diff of a pull request be clickable
• have commits that show in the notifications screen be clickable
• add number of commits in the repository screen - also clickable

Clicking either would navigate to a list of commits screen (CommitsListScreen for example) and clicking each commit would take you to a commit details screen (CommitScreenfor example which can look the same as PullRequestDiff screen).

Showing commit comments might be a bit more tricky and it's something we can do as a separate ticket once this gets added in.

Currently, pull request review comments don't show at all when viewing a PR. Not too sure how we want to include this functionality design-wise just yet, but this is definitely something we need to have. Open to all kinds of suggestions!

For some reason, diff blocks only appear in Pull Requesrs for public repos, but not for private repos. The side effect is that you cannot view different for private repo PRs.

Thank you @FlorianTaut for suggesting this :)

Will be awesome to be able to do this. Here's what I'm envisioning on the IssueListScreen:

Only in the that screen --> add a + icon to the top right corner and when clicked it takes you to a form type screen that looks just like PullDiffScreen. An issue title input and an issue description input and a simple list item for Submit new issue.

Please take a look at how I added a cog icon to the top right in the PullDiffScreen to get an idea of how I added a top right icon with actions in the navbar.

Once the API is hit and successful - we can use the response to navigate directly to the newly submitted issue. We can rely on the awesome work done by @mikekavouras and show the loading-modal until the call is complete similar to how he handled forking in #50.

Hey,

it would be nice to have those Buttons on the personal Settings page:

Those are the opened issues and PRs of the user.

Thank you

Could be useful to have a share link associated to repositories, users and issues that would allow us to share the actual github link.

For repositories and users, share can be added to the ActionSheet that opens when clicking the menu icon. However for issues we might have to add a share icon somewhere. Always open to suggestions of course.

Our current welcome screen before a user logs in:

I quite like it, but I think having a welcome swiper explaining the different things the app could do would be even better 🤓

For example: the Slack mobile app

The Product Hunt app

Doesn't have to be as anything as complicated as those options - they're just for reference.

Some points however:

1. react-native-swiper seems to be an excellent library that can do just this
2. I like the idea of having the Sign In button at the bottom always so even though the user can continue to swipe, they can always just click the sign in button
3. I'll leave the floor open for design suggestions. Something simple with a top title (Control your notifications for example, a GitHub octicon in the middle and a mini blurb below (View and control all of your unread and participating notifications. for example is what I'm envisioning. Feel free to just lift copy from the landing page

Always open to further ideas and suggestions of course <3

At the moment the phone app is available in the appstore also for ipad.

As the app on ipad is only a scaled up version of the phone version (at the time of writing) the app should instead define that its only compatible for iphone not ipad

Since the app has nested navigation throughout, most of the screens can be accessed through each of the tabs. Moreover, the same screen can easily be accessed in the same stack.

To reproduce this bug, there are 2 ways:

1

1. In any tab, navigate to any screen (for example: user profile)
2. Switch to a different tab, navigate to the same screen (for example: user profile for a different user)
3. Switch back the first tab and you'll notice that the correct state isn't shown

2

1. navigate to repository screen (as an example)
2. click any contributor to navigate to user profile screen
3. click number of repos to navigate to repository list screen
4. click a repository to navigate to the repository screen
5. go back multiple times until you reach the first repository screen you accesed -- you'll notice that the correct state isn't shown

This can be solved by essentially reloading component state whenever it comes into focus and there's an issue open for that in React Navigation.

One thing I've tried is wrapping a HOC in the meantime that exposes a isFocused prop, but I couldn't have this working without the component state being fired multiple times every time the screen was focused.

Open to suggestions of any kind!

I follow the steps under CONTRIBUTING.md but couldn't run the project. What I'm seeing is this:

No bundle URL present.
Make sure you're running a package server or have included a .jsbundle file in your application bundle

Any idea what could be wrong?

Thanks!

Hi,

This app looks promising, great work! 👍
It would be nice to have the pinned repositories on a user profil 😃

Hey,

Some emojys are not rendered corretly.. See below:

Thank you

It would be helpful to show the last search results or last watched repos when starting a new search request

When you open your profile, the user description is missing.

I'd love to work on this feature, let me know if I can do it.

Also, thanks for making this project, it's awesome!!!

Would be nice to have a settings icon on the authenticated user's profile screen (AuthProfileScreen) that opens a modal screen with a form of sorts that allows you to update settings in your profile such as:

• Profile Image (select from the photo library + take photo (if that's not too complicated) - we can have a separate ticket for this because I'm not sure if the API makes this easy)
• Name
• Email
• Website

We may also want to allow updating of the following:

• Bio
• Company
• Toronto

But we can do this as part of a separate ticket and only if we decide to include them in the user profile screen

Does the app really need access to all this?

The less data would be required the best

Would be awesome to allow the user to filter for Best Match Most Stars etc... for repository search and the same for users (Most Followers, etc...).

Will need to do the same for issue search when that gets added in to the app as well #12.

I see that right now is not possible to watch any repos (only star repos is available)

I'd like to work on this feature too.

Thanks!

So we can't logout of the app right now :). Currently users have to delete the app and redownload in order to sign in with another account.

We can just navigate the user to the initial welcome screen (might be worth clearing our persisted store too).

Seems like labels here is not centered vertically imo
iOS 11, latest public beta atm.

Nice app though :)

Hey,

It would be nice to be able to create issues with GitPoint.

Another point is that rendering is not working correctly. Images are not displayed only the code behind the image is displayed.

Great app!

Thank you!

Something I've been thinking about adding for some time: editing and updating files in a repo. Still not 100% sure how exactly we would do this but opening this issue for discussion/tracking.

Getting a NET::ERR_CERT_AUTHORITY_INVALID

Hey @housseindjirdeh! Thanks for the super awesome project, I really like it!

What about only allowing squash merges on the repo, that will give us a cleaner commit history + it's easier to track bugs, what do you think?

Since this is built with React Native, it only makes sense to include an Android version.

Unfortunately, I haven't once tried running the application on a Android emulator or device so there is definitely going to be quite a bit that needs to be done to have it working smoothly across both platforms.

Hey,

it would be cool to view the Releases of repositories.

For example between Stars and Forks or below:

I marked the to Points that seem possible to me.

Thank you

So I spent a bit of time some while ago working on adding reactions. This is all in the with-reactions branch of the repo. Keep in mind this is a much older branch and there have been a lot of changes since than on master, but I feel we can port our logic from there when we're ready.

This is what I had working:

You'll notice Slack inspiration there :P

An important thing to point out is that the Reactions APIs are still in development preview. Definitely worth discussing if we wouldn't mind including it now and changing it in the future or if that's not the safest option just yet.

Looking forward to having this rolled out eventually. Discussions/contributions are always welcome :)

As of currently, only code in the master branch of every repo can be viewed. Definitely need to allow for the user to switch branches.

We can start using https://github.com/acdlite/redux-actions so we can write less code. I'm talking specifically about dispatching something like this: https://github.com/acdlite/redux-actions#usage instead of having all the boilerplate we already have in our reducer/actions.

Also, we can do this incrementally.

As mentioned, let's narrow down our eslint/formatting preferences in the codebase. We can use this thread for discussion.

I'm a huge fan of prettier - we can do a prettier-eslint pre-commit hook? Thoughts? CC @alejandronanez @patw0929

We can only search for users and repos currently. Would be nice to have the ability to search for issues as well.

Just like https://github.com/trending