Giter Club home page Giter Club logo

write-docker-actions's Introduction

Learning Lab bot

Course: GitHub Actions: Write Docker container actions

This repository powers the Learning Lab course GitHub Actions: Write Docker container actions.

Every Learning Lab course is made up of:

The course repository is written in YAML and Markdown. The template repository could be written in any language that supports the learning objectives.

For more information on the goals of this course, check out the course-details.md.

Contribute

See something we could improve? Check out the contributing guide in the community contributors repository for more information on the types of contributions we ❤️ and instructions.

We ❤️ our community and take great care to ensure it is fun, safe and rewarding. Please review our Code of Conduct for community expectations and guidelines for reporting concerns.

License

All Learning Lab course repositories are licensed under CC-BY-4.0 (c) 2019 GitHub, Inc. The template repositories associated with each course may have different licenses.

When using the GitHub logos, be sure to follow the GitHub logo guidelines

write-docker-actions's People

Contributors

brianamarie avatar hectorsector avatar lucie-docs avatar mattdavis0351 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

write-docker-actions's Issues

Errors in cat-facts python code

Description
The provided code in the template will throw an error when running the actions as the schema of the message delivered by the API (https://cat-fact.herokuapp.com/facts) seems to have changed.

This might be related with #9 however the API is currently responding (maybe the service changed?).

There are other errors in the same code, the method that picks a random fact might throw an index out of bounds error and it is fetching the length of the facts list from the parent execution context.

To Reproduce
Steps to reproduce the behavior:
Run the python code provided in the template in a suitable env (with requests module installed)

Expected behavior
The output should be 2 lines with a random cat fact and the set-output with it, for example:

The technical term for a cat’s hairball is a bezoar.
::set-output name=fact::The technical term for a cat’s hairball is a bezoar.

Screenshots
Screenshot from 2020-12-16 13-53-11
Screenshot from 2020-12-16 14-03-32

Additional context
I've finished the course without this problem by fixing the python code:
Screenshot from 2020-12-16 14-00-33

Switch to review approvals

Currently we toggle branch protections on and off. However, since the learner is opening their own PRs, we can have the bot approve and therefore not rely on the browser refresh issues that are caused with the toggle, and promote proper use of GitHub's PR reviews.

Think of a better step than commenting

The step where we ask the learner to comment out their workflow seems a little forced. We might find a more practical way to move the learner along in this course.

Screen Shot 2020-03-24 at 1 28 15 PM

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.