A couple of times, when I double right-clicked on a file in the to-be-committed list (haven't checked other items), it crashed visual studio. I tried clicking Debug once, and If I recall correctly It threw an InvalidCastException or something of that sort. I have yet succeeded in recreating the crash again so I cannot tell for sure if it is the right exception or not. I'll make sure to verify or update if the crash happens again.

Sequence of events :

1. Create a repo (public or private) on GitHub and add visualstudio .gitignore
2. Create local repository, commit to that
3. Sync to repo on GitHub and you get an error.

For this to work you have to create the repo on GitHub wihout .gitignore

Today, if a user clicks the "Sync" button and tries to sync a GitHub.com repository, they'll receive the standard basic authentication dialog. This will work fine if the user is not using two factor authentication (2fa). But if they are using 2fa, this is not a nice experience.

Instead, if the user clicks Sync, we should launch our own login dialog. And after the user logs in, we should take them to the Sync page (if possible) though it'd be fine to take them back to the home screen and let them click Sync again.

There's a few ways we might be able to accomplish this.

1. Hide the Sync button for unauthenticated users viewing a GitHub.com repository and add our own "Sync" button that launches the login dialog and then navigates to the Sync page.
2. Hook into the Sync button and override the event handling to launch our dialog. (I have no idea if this is possible).
3. We don't show the Team Explorer section and rebuild the whole section ourselves (ewww!)
4. Something else that people more knowledgeable about Team Explorer might think up.

Also, we need to make sure we don't forget to also hijack the menu if possible.

There seems to be a "scripts" submodule in the root pointing to revision 7ee5265... of a nonexistent https://github.com/github/VisualStudioBuildScripts/ repository. Going to that link 404s. This causes problems when cloning.

Is this broken or am I misunderstanding how the submodule is supposed to work?

When the user is unauthenticated and they visit a repository's home page in team explorer, we should provide a visual indication that they are not logged in and an option to log in. Something like this:

When they log in, the "sign in..." button goes away.

Search for GitIgnore field in Create popover doesn't display correct search results

Steps to reproduce:

1. Click on Create
2. Create popover displays
3. Search for a license

Expected Results: The correct search results displays if the GitIgnore selection exists

Actual Results: Nothing displays - I hope I'm correct in assuming the search results does display? 😢

Search for License field in Create popover doesn't display correct search results

Steps to reproduce

1. Click on Create
2. Create popover displays
3. Search for a license

Expected Results: The correct search results displays if the License exists

Actual Results: Nothing displays. 😢

It would be great if we could explore our git repositories from source controll explorer (or something simmilar) so we dont have to leave the IDE. We can work from file explorer, but it doesnt feel like an IDE when switching.

Imported from https://github.com/github/VisualStudioInternal/issues/346

Repro steps:

1. Login with an account that has 2fa enabled.
2. Disconnect internet access from your computer.
3. Enter 2fa code and hit verify.

Expected: 2fa dialog shows an error message.
Actual: The verify button stays disabled and busy. Note, the dialog is still responsive, the operation just never completes.

When I click on "plug" icon in Team Explorer then Visual Studio immediately crashes.

Stack trace:

Unhandled exception:
System.NullReferenceException
Object reference not set to an instance of an object.
   at GitHub.VisualStudio.Base.TeamExplorerServiceHolder.<UIContextChanged>b__0() in Y:\jenkins\workspace\GitHub for Visual Studio speakeasy jenkinskeep\src\GitHub.VisualStudio\Base\TeamExplorerServiceHolder.cs:line 128
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitHub.VisualStudio.Base.TeamExplorerServiceHolder.<UIContextChanged>d__2.MoveNext() in Y:\jenkins\workspace\GitHub for Visual Studio speakeasy jenkinskeep\src\GitHub.VisualStudio\Base\TeamExplorerServiceHolder.cs:line 128
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c__DisplayClass2.<ThrowAsync>b__3(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.DispatcherOperation.InvokeImpl()
   at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Windows.Threading.DispatcherOperation.Invoke()
   at System.Windows.Threading.Dispatcher.ProcessQueue()
   at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
   at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
   at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

Dump and reproduction steps can be downloaded from here:
http://rusfolder.com/44020874
http://rusfolder.com/44020875

I can actually login behind a proxy unlike #52 but my problems start after that.
As this is something that happens globally with git commands (not just via the GitHub for Visual Studio) I'm not sure if this belongs here as it might just be my fault for not setting the global proxy in the git configuration.
Having said that, it would be nice to have options for setting git http.proxy and https.proxy flags from the extension.

Hi,

Not sure what do do here. I am doing the course Using git with visual studio 2013 on microsofts virtual acadamy website.

I have cloned a git repo from GitHub. Its a java-script open source project. I followed the instuctions on opening the cloned repo off the videos but only see folders and no files. I can open the open source projects in webstorm but not in visual studio 2015 lol.

Any ideas be much appreciated.

Thanks.

Soon, some API actions will require that the user have a verified email, and error when they don't: https://github.com/github/github/pull/44098

We need to ensure the app behaves nicely in those cases.

This will help make the GitHub extension a bit more visible.

I think there's two phases to this feature.

Phase 1 : Only for Git Repos

We add the option to the existing Git section for menu options. Thus this option only shows up when a Solution is in a Git repository. The functionality is simple in this case.

1. If user is unauthenticated, launch the login dialog.
2. If the user is authenticated, navigate to the Sync page that contains the Publish dialog (or we could launch the publish dialog).

Phase 2 : All Solutions

When phase 1 is done, we should open a new issue to do phase 2 that always shows the menu option. When invoked, it does the following steps.

1. If user is unauthenticated, launch the login dialog.
2. If the solution is not already a Git repository, launches a version of the Create Repository dialog geared towards publishing with the current solution in the path (sometimes users might want to create the repository one folder above the one the .sln file is in).

This would initialize the local repository and then publish it to GitHub.

Steps to reproduce:

1. Enter in a field description that's pretty lengthy or copy/paste in something like this:
   Now, this is a story all about how My life got flipped-turned upside down And I'd like to take a minute Just sit right there I'll tell you how I became the prince of a town called Bel Air.

**Expected Results:**The text box will automatically line wrap

Actual Results: The text just keeps going in one line forever

If you fork a report on github after you've already logged into the VS Plugin, when you try to clone the new repo it doesn't show up in the list. Doing some additional testing (deleting a repo, removing an organization) show that those aren't update either.

I believe the list of repos/organizations should refresh each time you open the clone repo window.

I would dig into the code, but the Community addition does not allow you to work on VS extensions.

Imported from https://github.com/github/VisualStudioInternal/issues/35

A couple of times, when I double right-clicked on a file in the to-be-committed list (haven't checked other items), it crashed visual studio. I tried clicking Debug once, and If I recall correctly It threw an InvalidCastException or something of that sort. I have yet succeeded in recreating the crash again so I cannot tell for sure if it is the right exception or not. I'll make sure to verify or update if the crash happens again.

Currently I use the following steps:

1. Go to Branches and checkout master
2. Go to Sync and click fetch, choose upstream/master
3. Go to Branches and expand upstream, right click master and choose Merge from
4. Go to Sync and click push
5. Go to Branches and switch back to my branch

That's a lot of steps, I want a fewer-clicks solution. Example:

1. Coding in my branch and feel like sync
2. Go to Sync and choose upstream/master and origin/master then click Go, the process kicks up in the background
3. Continue coding in my branch

PS. Bitbucket offers sync fork on server, so in hg only an hg pull is needed in this scenario

Is it possible to create gist from selected lines with this extension?

This blog post says that the author checked the "Create Private Repo" checkbox, but a public repository was created and the author inadvertently published AWS keys: How a bug in Visual Studio 2015 exposed my source code on GitHub and cost me $6,500 in a few hours

I'm fairly certain this is an issue in the GitHub extension, rather than Visual Studio itself.

Here's how the Visual Studio sync dialog appears without the GitHub extension installed:

And with the extension:

Imported from https://github.com/github/VisualStudioInternal/issues/372

Add list of known local GitHub repo clones in the Connect page, under the clone/create/sign out links.

The native libraries aren't being properly packaged during the build, which causes pinvoke errors when certain features are used.

Refresh button doesn't clear out the commit message field

Steps to reproduce:

1. Enter text in the "Enter in a Commit message (Required) field
2. Hit the Refresh button

Expected Results: I feel when I hit refresh (because I haven't saved the commit) that maybe the field should be cleared out?

Actual Results: Nothing happens right now. Again, this was just something I was confused about so this may totally not be a bug but something I noticed.

These are other places where I think the Refresh button would clear these fields out?

Steps to repro with the beta-1.0.12:

• Create a new project and add it to source control
• Click on the "Sync" button in the Team Explorer home page
• Publish to GitHub

Expected:
Message "Repository published successfully"

Actual:
Message with error 401

So I'm getting the feeling that MS is doing something funky behind the scenes to pass in credentials to libgit2. If that's the case, we're going to have to rely on their libs instead of the nuget packages for libgit2/libgit2sharp to get this working properly.

The page https://visualstudio.github.com/ doesn't have a easily flaunted link to this source repository. Right now the simplest discovery path (beyone URL guessing) is in the release notes. It really should be a prominent link on the page itself.

Imported from https://github.com/github/VisualStudioInternal/issues/135

1. Launch VS
2. Team -> Manage Connections
3. Click on Create under the GitHub section
4. log in to GitHub.com on the login dialog
5. enter a repo name, description and local path
6. Click "Create Repository"

Actual: A notification that says "The repository was cloned successfully"
Expected: A more relevant notification that says my repo was created on GitHub.com.

Search Work Items field doesn't (seem to) work

Steps to reproduce

1. Navigate to Team Explorer
2. Attempt to search in the "Work Items" field

Expected Results: I think as a user, I should be able to click the box and enter in my search data (or control + ') to enable the field. I'm not sure what exactly is Work Items and tried to see if there was a "Work Items" section that I'm not aware of.

Actual Results: I can't access the Work Items search field. It looks like it might be disabled?

Unfortunately it is not yet possible to use VS2015 for everything (depending on the dependencies in a software project - i.e. currently it is only possible to do SQLServer 2012 SSIS development in VS2012, there might be other reasons aswell).

It would be good to also support VS2013/VS2012 with the Github VisualStudio plugin.

When developing this plugin, did you have a look at supporting multiple versions of VisualStudio and how difficult would it be to add support?

Per my conversation with @haacked in #10, I would like to be able to browse code on GitHub from Visual Studio and then open that code file in Visual Studio.

@haacked also mentioned that when viewing a file on GitHub there is a button titled Open this file in GitHub for Windows, which will open the code file in your default text editor for that file type. However, this only works if you have GitHub for Windows installed as it's not supported by default in Visual Studio.

I'm interested in finding out what GitHub for Windows does that enables that to be be viewed in a text editor and then help add that to Visual Studio whether that by making it a part of this extension or by creating another one.

Imported from https://github.com/github/VisualStudioInternal/issues/440

User used a personal token as password and got the following error:

👷

The installer seems broken from the download page. I was able to install by using the MODIFY feature from the original vs_enterprise installer--perhaps that installer is different?

Imported from https://github.com/github/VisualStudioInternal/issues/428

So this is the broad list of things that go into PRs. I've set checkmarks on the bare minimum PR support without which there's probably no point in shipping. Any things that we wouldn't support initially would instead jump to the website to show the information, if possible.

PR Feature - Level 1

• List Pull Requests
  • Filtering
• Create Pull Request
  • Entry form for title, description and create button
  • Assigment
  • Commit list

PR Feature - Level 2

• Create Pull Request
  • Commit detail (file changes list per commit)
  • File changes list (of the PR)
  • Diff of file change selected (from commit detail or PR changes detail), no special adornments

PR Feature - Level 3

• Pull Request detail
  • Commit list
  • Commit detail (file changes list )
  • File changes list (of the PR)
  • Conversation list
  • Diff of file change (from commit detail or PR changes list)
    • Add comment on diff view line
    • See comments on diff view line
  • Merge PR
  • Close PR

Things to figure out

• Need a way of assigning someone to a PR
• Need a merge button somewhere
• Sorting

Mockups

Pull Request List

Pull Request Creation / Detail

The pull request creation wouldn't have a Conversation tab because, well, it's a new PR, but viewing an existing PR would have it. Still debating whether to use tabs or dropdowns (for space conservation), but tabs do provide useful information.

Not seen in the mockups is the ability to see individual changes list per-commit, which is a very useful feature. Considering having the commit entry as a collapsible pane that shows a list of changed files in the same way as the PR file change list.

Pull Request Detail, alternate form with pull downs

Repo name field doesn't display the current project name but the previous one

Steps to reproduce:

1. Create a new project
2. Make the initial commit
3. Publish the Repo
4. Create another new project
5. Make the initial commit
6. Attempt to Publish

Expected Results: I think the Repo name field should display the new project name (or maybe be blank?)
Actual Results: The field displays the previous project's name
Note: This is also the same behavior with the Repository Description field

I am attempting to connect to GitHub but the Connect to GitHub dialog will not let me click on GitHub, it forces GitHub Enterprise. Any idea how I fix this? I don't currently and never had an Enterprise account. Screen Grab of the dialog below and a screen grab of my VS About dialog too.

thanks.

VS doesn't refresh to the correct repo after creating a new one

Steps to reproduce:

1. Have an existing project open
2. Navigate to Team Explorer --> Manage Connections
3. Click Create
4. Enter in required fields and click Create to create a new repo

Expected Results: VS switches to the newly created repo/project

Actual Results: VS stays on the previously opened repo/project and you have to click on the newly created project/repo in the Local Git Repositories list in Team Explorer to get to it.

Imported from https://github.com/github/VisualStudioInternal/issues/412

User noticed a bunch of repositories were "missing".

It turns out, the user hadn't scrolled down.

The UI is a bit confusing in this case. The scrollbar isn't visible until you hover and even then, in some cases, it isn't very noticeable.

It seems that there is no way to refresh the list of GitHub repositories which is annoying, because sometimes only a sign out and sign in allows me to see newly forked repositories (not even a VS restart seems to help).

First of all, thanks! Really liking the plugin so far!

But, one minor issue is our internal github enterprise install is not SSL and the repo in Visual Studio 2015 is http://, but the plugin converts all the links "Pull Request", "Pulse", "Graphs", "Issues" to https:// breaking the feature for us.

Let's assume I'm logged in into account A, open a local project from account B, make some changes and then try to commit these changes to GitHub.
This will obviously fail and the output window from VS shows a 404.
So I click on the Sign out link

then on the Login link

and now the Connect to GitHub dialog automatically selects the GitHub Enterprise login and I'm unable to select the normal GitHub login.

This behavior only appears if I'm opening a project from a different account. If I logout/login in a project from account A it is working fine.

Regards.

After publishing a new repository to GitHub, the TE view stays on the publish page (pictured), instead of switching to the Home view.

Move strings into resources, make things nice and ready for translation/localization

Take a look at this screenshot.

When you're working in Git, what's one of the most important pieces of context you need to know? Yep! What branch am I in? So how do I find that out today? I have to navigate to Team Explore and then click on Branches.

We should put this context front and center. Bonus if we can also provide a branch picker right there. Here's a couple of ideas.

I'm not sure if we can do this or if it requires the VS team to do it, but I thought I'd log it here for discussion.

I guess i have an issue logging into my account using that extension since am behind a proxy.

Any workaround to resolve this issue.

Thanks.

Here is the logs

2015-08-09 14:56:04.0514|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:56:25.4323|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:56:25.4323|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:56:44.0001|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:56:44.0001|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:57:43.5552|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:57:43.5552|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:57:49.3852|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:57:49.3852|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:57:53.7129|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:57:53.7129|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:58:11.5627|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:58:11.5637|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-09 14:58:38.7682|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-09 14:58:38.7682|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'qandil' FAILED
2015-08-13 09:29:01.9302|INFO|thread: 1|RepositoryHost|Log in from cache for login '(null)' to host 'https://api.github.com/' FAILED
2015-08-13 09:29:01.9382|INFO|thread: 1|RepositoryHosts|Log in to GitHub.com host 'https://api.github.com/' with username 'Qandil' FAILED

A user recently documented an account of a severe consequence that resulted after publishing a repository to GitHub.
https://www.humankode.com/security/how-a-bug-in-visual-studio-2015-exposed-my-source-code-on-github-and-cost-me-6500-in-a-few-hours
I was able to reproduce this myself with the following steps:
0) Sign into the GitHub extension.

1. Create a new local repository in Team explorer.
2. Click on Changes and Commit an initial commit into the repo.
3. Click sync to navigate to the synchronization page.
4. Check the Private Repository box and then click publish.

Result was a repository was successfully published to GitHub and was visible from an inprivate browser session where I was not signed in.

A customer reported consistent crashes with the GitHub extension installed. It's a null reference exception in TeamExplorerServiceHolder.

Here's the dump with more info:
https://onedrive.live.com/redir?resid=439D1CEA375857EE!42116&authkey=!AGcdg_F0wdUwlTg&ithint=file%2cdmp

I don't really know if this has anything to do with GitHub for VS, but since you guys know a lot about Git I thought I'd ask here. Maybe you've heard about this kind of behavior before 😃

I have this problem that every time I open a solution a strange looking empty directory is created in the folder where .sln is launched from. The directory name is always the same no matter what repo I launch a solution from: DTAR_08E86330_4835_4B5C_9E5A_61F37AE1A077_DTAR

Anyone know what's causing this?