Giter Club home page Giter Club logo

query-selector's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

query-selector's Issues

TypeScript type definition

I put together a TypeScript type definition for this library now that I'm using it. I could publish it to DefinitelyTyped but it's preferable to keep the definition in the package. Will you accept a PR with this or would you prefer to keep it separate?

Should this library be deprecated?

The points in the Motivations section of the README are outdated or not applicable with TypeScript.

Finding an individual element in the document tree and operating on it can lead to null pointer exceptions.

TypeScript now supports optional chaining, and with strictNullChecks enabled, this should never be an issue.

Even if found, the element may be of the wrong type.

The TypeScript definitions for these methods accept a type parameter, which will assert the return type. Obviously, if the fetched element is actually of a different type, it can still lead to runtime errors. On the plus side, there's no runtime cost for the check. But in my experience, this kind of runtime error is extremely rare. Furthermore, this library will just throw an Error anyway, so it's still going to end up being a runtime error.

Why deprecate?

This will discourage new users and point them to the vanilla patterns.

Why keep it?

This library may still be useful for Flow users.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.