giphy / giphy-js-sdk-core Goto Github PK

Hi,

Is there a workaround to retrieve the VerificationID in order to verify GIPHY Integration ?

Quoting from Github:

For the repository owner, contribution guidelines are a way to communicate how people should contribute.

For contributors, the guidelines help them verify that they're submitting well-formed pull requests and opening useful issues.

See Microsoft's CONTRIBUTING for VSCode and Facebook's CONTRIBUTING for React Native.

Describe the bug
termSuggestion returns a failure with an issue regarding CORS header, when other endpoints seem to be working fine.

To Reproduce
Steps to reproduce the behavior:

1. Try a request using .termSuggestions(). I have a demo listed below.

Expected behavior
I am expecting a response from the endpoint for 'termSuggestion' but instead I get a CORS error. I am not sure why this is the case if the search endpoint is allowing me to work. Pasting the request url into my browser bar returns {"message":"You cannot consume this service"}

Reproducible Demo

I have made an easy to follow, simple project. You can recreate the results too that cause this issue!
https://github.com/RobertCrowdis/giphy-sdk-example

Desktop (please complete the following information):
Running on latest version of Chrome as of 2/20/2019, Macbook Air with macOS High Sierra 10.13.4

Recommended by Github to comply with recommended community standards.

You can find how Giphy Core SDK for JS compares to community standards here.

Describe the bug
The build status from the Travis CI API is not loading correctly. Showing status unknown currently.

To Reproduce
Steps to reproduce the behavior:

1. Check the badge on the README.

Expected behavior
Show current build status.

Screenshots

Hello,

The js api is great, but origal size gif are heavy, is there a reson why "downsized", "downsized_still" and "downsized_large" sizes are not included in the returned objects ?

Thanks for the feedback

Response from Image object does not match schema definition found in documentation (https://developers.giphy.com/docs/#images-object) e.g. gif_url vs url

This appears to have been fixed in this commit - 5615a76 - however this change is not available in version 1.0.5.

Can you tell me when you plan to make a new release?

Whenever I run the command npm install giphy-sdk-core I get an error that says I can not install from "node_modules\giphy-js-sdk-core" as it does not contain a package.json file". I am pretty new to programming and I am confused as to what this means.

2019-09-15T04_01_51_822Zdebug.txt

Is your feature request related to a problem? Please describe.
The current README has a mixed structure and seems desorganized.

Describe the solution you'd like
Follow Github's recommended format.

Describe alternatives you've considered
Follow a well-structured format.

Describe the bug
The monthly download count is not showing in the README, showing zero instead.

To Reproduce
Steps to reproduce the behavior:

1. Check downloads badge in README

Expected behavior
A good alternative would be to show the total count.
https://img.shields.io/npm/dt/giphy-js-sdk-core.svg

Screenshots

Quoting from Github:

A code of conduct defines standards for how to engage in a community.

See Facebook's and Microsoft's code of conduct.

The SDK has been working great for me until version 1.0.6. Now all calls through the SDK get

No 'Access-Control-Allow-Origin' header is present on the requested resource.

Recommended by Github to comply with recommended community standards.

You can find how Giphy Core SDK for JS compares to community standards here.

I can't use this api within a react native project as it conflicts with react natives own fetch.

To fix I have uncommented require('isomorphic-fetch'); from line 14 in RequestHandler.js

Is there a more solid fix?

I am using the SDK in a project and have encountered some bugs that could easily be fixed. There are some PRs that haven't been merged that should fix these bugs, as well as outdated issues.

I was told by @Nolski that @cosmocochrane1 is the one responsible for the repo. I would like to receive maintainer permissions to help with PRs and Issues.

Where can I find a changelog for the npm package giphy-js-sdk-core? Without it it's hard to notice what changes between versions.

What about keep a changelog?

The response I'm getting from the random endpoint looks totally different than to what's on both the docs and Giphy's API explorer.
I'm getting this response:

{
  data:{

    images: {fixed_height_downsampled: {…}, fixed_height_small: {…}, fixed_width_downsampled: {…}, fixed_width_small: {…}, fixed_width_small_still: {…}, …}
    type: "gif"
    url: "https://giphy.com/gifs/url"
    user:{
      username: ""

    }
  }
}

On Giphy's API explorer, the response looks to be

{
  "data": {
    "images": {
      //image_urls
    }
    "type": "gif",
       "id": "GIF_ID",
       "slug": "slug",
       "url": "giphy-url.url",
       "bitly_gif_url": "bit.ly.url",
       "bitly_url": "bit.ly.url",
       "embed_url": "embed.url",
       "username": "",
       "source": "source_url.com",
       "content_url": "",
       "source_tld": "www.google.com",
       "source_post_url": "source_url.com",
       "is_sticker": 0,
       "import_datetime": "2015-05-20 20:37:11",
       "trending_datetime": "1970-01-01 00:00:00",
  }
}