giom / nginx_accept_language_module Goto Github PK

For some major languages, 2-letter code is inadequate/insufficient.

Consider the Chinese language, which has 2 scripts, simplified and traditional. Those would be described as 5-character locale code zh-cn, zh-sg (simplified) and zh-tw, zh-hk (traditional).

It would be nice if your module could work with 5-character locale codes and some kind of user-defined locale-to-locale mapping.

You can see an example of my method I wrote in PHP Language Detector.

Does this module also have a way to add ", Accept-Language" to the Vary header -- or is there some good way to do this on nginx generally?

On review I noticed this module is prone to poor scalability.

Scales roughly O(n*m) where n is the number of languages supplied in the header and m is the number of languages supported.

If m is sufficiently large this module will cease to perform well.

A handy option, besides checking the accept language header, would be also to check an optional cookie value for a language code as well.

Maybe the following optional config statement:

accept_language_cookie <name of cookie to check>

And give the value of the cookie preference over the language order given in the accept language header.

This would allow the application to override the automagic language value (by setting a cookie), in case the uise would like to choose a language other than what their browser is set to.