Comments (6)
distantnative
commented on June 28, 2024
It's hasn't gotten lost. Let's keep it with one issue for this.
from kirby.
silllli
commented on June 28, 2024
The other issue was and remains closed as “completed” (after me stating more inconsistencies), so I thought there is need for a new one to stay visible.
from kirby.
distantnative
commented on June 28, 2024
@silllli as far as I see the PR #6462 does address those as well or do you see its differently?
from kirby.
silllli
commented on June 28, 2024
@distantnative Ah, true! But using the passed allowed character set is prone to becoming out of sync with the sanitization on the server (which is hardcoded) again.
Also, as I mentioned, the Panel can’t handle files starting with an underscore (which was prevented so far) so there is a way to break it now by renaming a file to start with an underscore.
from kirby.
distantnative
commented on June 28, 2024
Which is why the PR also removes them on the Panel/frontend at the start/end of the filename.
from kirby.
silllli
commented on June 28, 2024
Perfect. Sorry, I didn’t check all commits and there was no feedback on my additional comment.
from kirby.
Related Issues (20)
- Filename sanitization rules are inconsistent HOT 1
- Throwing NotFoundException results in 500 error page HOT 1
- Strange behavior when clicking on tags field input
- Date picker not opening when clicking on date field in Panel HOT 3
- Lab examples for `<k-table>`
- Public Lab: page/file preview empty as data is missing
- `<k-table>`: problems with case-sensitive matching of column index
- Star in blueprint title error
- textarea element is missing some padding when used as a Block in a Layout field.
- Console error when small screens
- System view: too long server name HOT 3
- `$file->srcset()` includes upscaled image sizes HOT 1
- Language permissions not working
- Writer field overwritten with cached values from nested children HOT 1
- Writer field content deleted, when renaming page slug HOT 1
- Changing the sort number of listed pages will cause recreation of image source sets
- Duplicate content when appending `.html` to page URLs
- URLs of link fields are not truncated in table layout columns
- Image thumbs: persisting jobs files HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kirby.