Changing the sort number of listed pages will cause recreation of image source sets about kirby HOT 6 CLOSED

The salt by default contains the parent's page ID which includes the sorting number. If you resort the parent, the page sorting number changes, the page ID changes, the salt for contentToken changes and in the end that's why the root for the media file changes => it gets newly created.

from kirby.

@ovenum this will be fixed/improved in Kirby 5 (instead using the absolute root for the hash, we're using the root to the content folder and then only the ID without sorting numbers).

#6432

from kirby.

@ovenum are you already using https://getkirby.com/docs/reference/system/options/content#salt-for-drafts-and-media-files as suggested on Discord to not use the page ID (which includes the sorting number) in the path?

This might not fully work as I realize that the file's mediaRoot also includes $parent->mediaRoot() (the page), which includes its id (incl. sorting number) as well: https://github.com/getkirby/kirby/blob/main/src/Cms/Page.php#L798

I haven't spotted in our code where we would use the modification timestamp of the page in the file's url. Are you sure about this? It does in fact use the modification of the file itself which is necessary as otherwise browser would not load new versions of a file that gets updated/replaced with the same name.

from kirby.

@distantnative i have not used the config option for content salts.
Testing with a kirby plainkit, setting content.salt to a fixed value will solve the issue.

// site/config.php
return [
'content' => [ 'salt' => 'test' ]
]

When not setting the content salt i can reproduce the issue every time with the plainkit.
Also not sure what the root of the issue is. I could see that the modified timestamp of the folder changed and that it’s contained within the file path, so just assumed it might be the cause.

from kirby.

Thanks for explaing this! Understanding now why this is happening. I would consider it a bug or at least a not optimal default setting.

The images do not need to be re-created because their path or content did not change when just the parents sorting number is modified/added.

As mentioned on Discord this can cause unecessary server load and hdd usage when pages sorting numbers are changed.

from kirby.

Thanks @distantnative this really helps a lot!

Also noticed that this can cause Google to create duplicate content hints when a page contains PDFs that were added to the search index and now got a new url because of changing the sort order and not clearing pages media folder.

from kirby.