`file.create:before` hook: allow to modify `$file` object about kirby HOT 4 OPEN

But in the after hook the original file should now be the actual file, shouldn't it? Or what else are you getting from $upload?

The problem here is that our objects (like $file) are immutable. So $file->update() does not change the file object, but rather creates a new one with the modified content. These hook types are though only triggers. So what happens in the hook is also not passed back to the general script. And thus the script continues with the file object as it was passed into the hook. In the after hook it's less apparent as there it also writes the new content to the now existing content file, so on any new request that content gets actually read.

It's an issue of the immutability of our objects. We will have to look into if we can change the hooks to return something without being a huge breaking change. But if the after hook works for you in the meantime, I would go with that.

from kirby.

@silllli have you tried it with file.create:after?

from kirby.

Yes, there it works. But in the after hook the original file (passed as $upload in the before hook) is not available.

I could imagine that this is technically not possible (since we are in the before hook, so there is no actual file to update() yet). But then why pass the $file object to the hook?

Also, using the file.create:before hook to save things like the filename to the file metadata was suggested in the forum in several thread so I expected it to work.

from kirby.

But in the after hook the original file should now be the actual file, shouldn't it? Or what else are you getting from $upload?

I am looking at ways to adjust the filename sanitization done by Kirby (mostly allowing uppercase letters). The Vue parts worked well, but adjusting the server-side sanitization is a lot more tricky. I found a solution that overwrites parts of the File class in a plugin. That needs some code copying from and fiddling with the Kirby core—so it’s anything but future-proof.

I thought saving the original filename in the before hook and then reapplying (with custom sanitization) it in the after hook would be a cleaner and more future-proof way of handling this. In the after hook, the filename was already sanitized and there is no way of accessing the original anymore.

Thank you for the quick replies!

from kirby.