getamis / eth-client Goto Github PK

package main

import (
	"log"
	"github.com/getamis/eth-client/quorum"
)
func main() {
	c, err := quorum.Dial("http://0.0.0.0:8545")
	if err != nil {
	    log.Fatalln(err)
	}
}

I get the following error

# github.com/getamis/eth-client/client
../../github.com/getamis/eth-client/client/client.go:49:6: cannot use client literal (type *client) as type Client in return argument:
	*client does not implement Client (wrong type for EstimateGas method)
		have EstimateGas(context.Context, ethereum.CallMsg) (uint64, error)
		want EstimateGas(context.Context, ethereum.CallMsg) (*big.Int, error)

Is there something I am doing wrong?

Why is this a separate repo, while go-ethereum has an ethclient package and Quorum too?

If there are any changes between client here and go-ethereum/ethclient, to make a PR there, and to merge the additions from the quorum package here into quorum/ethclient.

the istanbul and quorum clients reference their own git repo (getamis/eth-client) so forking and making a PR is kind of challenging, since any PR has to be reverted to point to this repo, rather than the repo where the PR is.

I just checked out the latest code and I was having a look into the client.go source file and I could not find any implementation for some of the functions in the api.go?

For example., I could not find the implementation for BlockByHash method in the client.go? Any ideas?