Giter Club home page Giter Club logo

geta-optimizely-tags's People

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

geta-optimizely-tags's Issues

Documentation needs clarification

Documents should clarify that functionality is implemented using Razor Pages, and thus needs the endpoints to be mapped. This package should not make the assumption that the consumer/installer is already using Razor Pages functionality.

In admin mode: Editing tags only works on page 1

In EPi Admin mode, when on the Geta Tags admin panel, editing (renaming) tags only works on page 1. If I browse to page 2 and click an Edit-button, I get redirected back to page 1 instead of getting the input fields.
The same issue applies after searching for a tag.

Clicking an edit-button on Page 1 works as expected.

Scrollbar is missing

Scroll bar is missing in geta tag's view. A similar issue was noticed for other pages in Optimizely and this was fixed by adding id="root" to div in admin layout.
image

TagsGroupKey doesn't work with same tag name from Group A and Group B

[Display(Name = "Tags", Order = 170)]
[UIHint("Tags")]
[TagsGroupKey("ArticleTags")]
[GetaTags(AllowSpaces = true)]
public virtual string Tags { get; set; }

[Display(
Name = "Tags")]
[UIHint("Tags")]
[TagsGroupKey("StoryTags")]
[GetaTags(AllowSpaces = true)]
public virtual string Tags { get; set; }

If I use Cancer Care for either groups, i get the error that it already belongs to ArticlePage

Scheduled job is not working correctly

We installed the most recent version of Geta Tags (https://github.com/Geta/geta-optimizely-tags) on an Optimizely CMS 12 implementation, but it appears the scheduled job is not working correctly. We would appreciate guidance on what the expected behavior of the scheduled job should be as we have been unable to find any documentation specific to this.

We had found this issue (https://github.com/Geta/Tags/issues/87reported) that was reported on the previous version of Geta Tags that looks to be the same as what we are experiencing with the new version, but it did not appear to have any resolution or follow up for it.

OOTB, it appears the job should remove invalid tags (https://github.com/Geta/geta-optimizely-tags/blob/master/src/Geta.Optimizely.Tags/TagsScheduledJob.cs). Below are the two scenarios that we are trying to validate.

Scenario #1:

  1. Tag is deleted from Geta Tags page in CMS
  2. Tag still exists on CMS content
  3. Maintenance job runs
  4. Should tags that are no longer in the Geta Tags library be removed from content? (this is not currently happening, old tags not in Geta remain on the content)
    Scenario #2:
  5. Tag is updated from Geta Tags page in CMS
  6. User does not select "Check this box to edit existing tags in the content" option
  7. Tag updates to new tag on Geta Tags Page/Library
  8. Should the original tag be removed from all content if it is no longer part of the Geta Tags library? (not currently happening)

Tags not working after upgrading to CMS 12

We are in the process of upgrading our solution from CMS 11 to CMS 12 and in the process replaced the Geta.Tags package with the Geta.Optimizely.Tags package. However, after upgrading the CMS shows no tags in the overview and no results are returned when querying for tags.

When I look at the tblBigTable in the database I do still see the tags with StoreName Geta.Tags.Models.Tag. Could the change of namespaces to add the .Optimizely. be the cause that no results are returned? If so, is the fix to change the StoreName and ItemType columns to the new namespaces?

Search is case sensitive

When searching for tags, it is required to search in correct casing otherwise there are no results.

Adding field to to SystemTabNames.PageHeader does not populate field value

Optimizely Version: 12.13

When adding a tags field to SystemTabNames.PageHeader the field does not load tags assigned to that field. It just loads a blank text field.

Adding tags works fine. But when you publish and the page refreshes, the field is blank again.

[UIHint("Tags")] [Display(Name = "Tags", Description = "Tags associated with this content.", GroupName = SystemTabNames.PageHeader, Order = 10)] public virtual string Tags { get; set; }

image

Standardize package

Consolidate with other packages that have been upgraded.

Things to check:

  • Naming
  • Configuration
  • remove nuspec, configure everything in csproj
  • zip files

Can use NotFoundHandler as an example

Old jQuery files: Potential security vulnerability

Hi Team @marisks @brianweet @valdisiljuconoks

I am currently undergoing a penetration test on one of my website applications which is currently using this package.
A security vulnerability has been identified with the use of old jQuery files in this package. Taking a look at this code repo, I can see that the following jQuery files used as part of this package.

(https://github.com/Geta/geta-optimizely-tags/blob/master/src/Geta.Optimizely.Tags/module/ClientResources/vendor/jquery-2.1.0.min.js) - /*! jQuery v2.1.0 | (c) 2005, 2014 jQuery Foundation, Inc. | jquery.org/license */
https://github.com/Geta/geta-optimizely-tags/blob/master/src/Geta.Optimizely.Tags/module/ClientResources/vendor/jquery-ui.min.js

Can you please advise/help me in how I can resolve this issue?

Kind Regards

Anil

When used together with sitemaps package leads to build error

How to reproduce:

  • install Geta.Tags 2.0.0 package
  • install Geta.Optimizely.Sitemaps 3.0.0 package
  • run re-build and you get the error

Error:

Microsoft.NET.Sdk.Razor.StaticWebAssets.targets(442, 5): Two assets found targeting the same path with incompatible asset kinds: 
'C:\Users\..\.nuget\packages\geta.optimizely.sitemaps\3.0.0\contentFiles\any\net6.0\wwwroot\css\dashboard.css' with kind 'All'
'C:\Users\..\.nuget\packages\geta.optimizely.tags\2.0.0\contentFiles\any\net6.0\wwwroot\css\dashboard.css' with kind 'All'
for path 'css/dashboard.css'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.