get-focus / deprecated-focus-application Goto Github PK

Hello,

In our project, we would like to customize the header actions :

• On a primary action, we'd like the possibility to display a list of actions on click
• We'd like to change the color of buttons

Hello,

The response status of the server is well used to display an error 👍 , but in the case of a modal, the error "toaster" is displayed under the modal, in the list component.

"focus-application": "3.0.0-rc16"

That's a question !!

get-focus/deprecated-focus-components-v3#74

add css to remove double scrolls.

klee-contrib/focus-notifications#33

Hello,

When I am first on a page which contains a Header, and I go to a page which doesn't contain a header, the "old" header is still displayed.

It seems the following code is not effective :

componentWillUnmount() {
    injectBarContentSummaryHeader(null);
    injectBarContentExpandedHeader(null);
    injectActionHeader(null);
}

"focus-application": "3.0.0-rc8"

Buttons doesn't display well.

Is it possible to treat this issue from focus-comment ?

klee-contrib/focus-components#648

If the issue from components is not up-to-date, can you close it ?

thanks @pierr

Since recently on Diane,
when there is a header on a first page,
and there is no header on a second page,
we get the error like 'wrong type... ' in HeaderComponent when accessing the second page from the first.
And I think it is because of the line 34 of the fix #55 : injectActionHeader(Empty). Indeed, as far as I understand, injectActionHeader is different from the others and need an object like {primary: , secondary: }, and not a component.
See in header-component:
{actions && <div data-focus='header-bar-actions'><ContentActionsComponent primary={actions.primary} secondary={actions.secondary} /></div>}
Empty.primary may cause an exception.

Hello,

Here's a gif to show the behaviour :

"focus-application": "3.0.0-rc27"
"focus-components": "3.0.6"

[Message/Confirm Reducers] Useless console.log()

There are some logs that are not used and not useful

https://github.com/get-focus/focus-application/blob/e66c37180510db01c789c7d87d16d8c2af362df2/src/messages/messages-reducer.js#L12

https://github.com/get-focus/focus-application/blob/e66c37180510db01c789c7d87d16d8c2af362df2/src/messages/messages-reducer.js#L19

https://github.com/get-focus/focus-application/blob/ce039c10c9c8044a59235cc711fd24314ee58e90/src/confirm/confirm-reducer.js#L11

The bar is hidden behind the Header Bar when we set it as "fixed".

The bar is currently displaying at the center. It has to display at the right of the bar

I would like to be able to put error messages in different format according to the type:
Error: Red background
Warning: Orange background
Info: blue background
Success: green background.
That's why I need css selector differentiation between types.

https://github.com/KleeGroup/focus-components/blob/v2.x.x/src/components/confirm/index.js

https://github.com/get-focus/focus-application/blob/master/src/translation/index.js#L3

• style-webpack-loader
• style-loader
• css-loader
• autoprefixer-loader
• sass-loader
• node-sass

https://github.com/reactjs/react-router/blob/master/docs/API.md#components-1