georgehj / albumart-ueber Goto Github PK

The script does not work with Python 3.9, ueberzug returns

Task exception was never retrieved
future: <Task finished name='Task-7' coro=<shutdown() done, defined at /usr/lib/python3.9/site-packages/ueberzug/layer.py:88> exception=AttributeError("type object '_asyncio.Task' has no attribute 'all_tasks'")>
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/ueberzug/layer.py", line 89, in shutdown
    tasks = [task for task in asyncio.Task.all_tasks()
AttributeError: type object '_asyncio.Task' has no attribute 'all_tasks'

• Find rights free music and album artwork for screenshots
• Move statements of rationale to the README
• Add list of tested terminals
• Add a See Also section to the README
  • Link to project pages for dependencies
  • Briefly note how they are used

Where there are duplicates such as folder.jpg and folder(1).jpg, find will match both.

Consider using head to limit the matches to one or using find with the -quit option.

Currently the function will wait before first checking to see if mpd is running.

Test changing the order of operations within the function.

mpd_check() {
	# wait until mpd is running
	while true; do
		sleep 1
		if mpc -q 2</dev/null; then
			break
		fi
	done
}

Refreshing on a keypress of r is preferable to quitting and reopening.

Variable names are inconsistently cased.

Fix in line with current recommendations following bash library deprecation.

Currently the tmpimgfile logic is firing on every track change regardless of whether the album changes.

Logically, there could be two states: where the file is different and where it isn't. In which case could only change when the art is different.

Problem

Currently the script uses two hard coded paths for the music directory and the pictures directory.

Solutions

• Use environmental variables
• Use $XDG_DATA_HOME to store collateral like no-art.png?

To-do

• Use $HOME variable for music directory and no-art path for now

Functions are inconsistently named and reading order could be improved.

We don't need output from grep.

mpd's music_dir can't be printed with mpc.

The following should be better explained:

• mpc will give file paths which are absolute but start under mpd's set music directory
• The script's variable declaration is necessary to place these paths in the proper context of the user's filesytem

To avoid confusion consider doing the following:

• Add comments
• Change place of script's variable declaration for music_dir

tmpimgfile_old isn't being used. Delete it.