geocoder-php / geocoder-js Goto Github PK

Hi,
currently I am using Google places to search for addresses within my Wordpress plugin Maps Marker Pro. A user now informed me that all Google services were recently blocked in China, so I am looking for an alternative.
Does geojoder-js support autocomplete of addresses for supported geocoding services or if not is this something that is planned in the future?
thx for any info!
Robert

Good to keep tabs on how complex we make our js code as time goes on.

https://github.com/vigetlabs/grunt-complexity

Now that we have a couple of provider implementations out, it seems fairly obvious to me that we should break out the code for fetching external data into a separate class and inject that into the provider classes. Bonus points if we can use something already written.

Examples pages are just console.logs(). We can do better...

If I try to get the coordonates for a given address that not exists in OSM referential, the b.address.house_number returns error because of the undefined b.address.
It try to get house_number on undefined.

It is necessary to return false (or equivalent) when no coordonate are found.

I corrected the mistake by adding if (b.length === 0) { return false; } before returning all values at line 406.

How can I install the package as my dependencies?

@fillerwriter could you please "transfer" the repo instead of forking it?

Hi there! How to add var with google api key to geocode.js?

You must use an API key to authenticate each request to Google Maps Platform APIs.
And it deny requests without api key.
And yandex too.
Any thoughts?

Is there an example or will it work with autocomplete?

I have a page on which I call GeocoderJS through openstreetmap provider.
Problem is my page is served with https, and I get some Mixed active content errors due to GeocoderJS using http protocol by default.

I had a look at and noticed that contrary to GoogleAPIProvider for which the protocol can be https, no https option is proposed for Openstreetmap provider (nor MapQuest btw). line 373.

Changing http to https on that line did solve the problem.

Currently, our unit testing is happening through PhantomJS, but I want to make sure we can work with node.js as well (i.e., not on a headless browser). I'm 90% sure we're not doing anything at this point that would prevent anyone from using this server-side, but just to make sure, let's explore options for server-side unit testing, preferably without rewriting all the tests.

Since #3 adding support for Node.js, the dist file is leaking global variables. A simple solution would be to wrap the build script in a function to scope these variables

When I try to geocode with yandex more then 1000 addresses, some time there callback function undefined error appears

?format=json&geocode=Санкт-Петербург, ЛИТОВСКАЯ, 48&lang=en-US&callback=jsonp1537788530860:1 Uncaught ReferenceError: jsonp1537788530860 is not defined
at ?format=json&geocode=Санкт-Петербург, ЛИТОВСКАЯ, 48&lang=en-US&callback=jsonp1537788530860:1
(anonymous) @ ?format=json&geocode=Санкт-Петербург, ЛИТОВСКАЯ, 48&lang=en-US&callback=jsonp1537788530860:1

https://github.com/geocoder-php/Geocoder#the-chain-provider