Giter Club home page Giter Club logo

libflatarray's People

Contributors

cicku avatar gentryx avatar hkaiser avatar larryxiao avatar shifty91 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

libflatarray's Issues

Remove link file libflatarray

Hi,

Is it really necessary to keep this link inside src?
If library is header only maybe it's better to put all files under include/libflatarray/*.
It's more common layout.

Of course if you have good reasons, feel free to keep it as is.

missing libflatarray/config.h

I've gotten following error:

/home/evansl/dwnlds/llvm/3.8/prebuilt/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-14.04/bin/clang++ -I../github/libflatarray/include -DHAVE_LIBFLATARRAY -O0 -std=c++14 -o /tmp/build/clangxx3_8_pkg/clang/struct_of_arrays/work/soa_compare.benchmark.optim0.exe soa_compare.benchmark.cpp
In file included from soa_compare.benchmark.cpp:51:
In file included from ../github/libflatarray/include/libflatarray/flat_array.hpp:20:
In file included from ../github/libflatarray/include/libflatarray/estimate_optimum_short_vec_type.hpp:11:
In file included from ../github/libflatarray/include/libflatarray/detail/streaming_short_vec_switch.hpp:11:
In file included from ../github/libflatarray/include/libflatarray/short_vec.hpp:203:
../github/libflatarray/include/libflatarray/detail/short_vec_scalar_double_1.hpp:13:10: fatal error:
'libflatarray/config.h' file not found

include <libflatarray/config.h>

     ^

Maybe you've not pushed it yet?

add dedicated mask type

e.g. template<typename CARGO, std::size_t ARITY mask_type which then wraps a short_vec's internal mask

Remove the workaround for the gcc bug 51626?

I notice there is a workaround:
https://github.com/gentryx/libflatarray/blob/master/include/libflatarray/aligned_allocator.hpp

    /**
     * Added due to compiling for Intel MIC with CPP14=TRUE
     * GCC Bug Report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51626
     */
    void construct(pointer p)
    {
        std::allocator<T>().construct(p, value_type());
    }

This compiler bug is marked as fixed: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51626
Shall the workaround be removed? Is the compiler bug actually fixed?

Members with non-trivial construction/desctrution cause segfaults

Reason: during initialization no c-tor is run and when copying one soa_grid to another a bitwise copy is performed.

Resolution: add tests for soa_grid and soa_array with non-trivial member types (e.g. std::map<int, std::vector >), then copy containers and read/write individual cells.

LIBFLATARRAY_REGISTER_SOA does not work with class templates having more than one template parameter

Hi,

i tried to use LibFlatArray with a class template which has more than one template parameter and it didn't compile. A simple example can be found here: https://gist.github.com/anonymous/b188cd1459c1b6d5ca6f

The error message is: error: macro "LIBFLATARRAY_REGISTER_SOA" passed 3 arguments, but takes just 2 LIBFLATARRAY_REGISTER_SOA(Cell<4, 1>, ((double)(sum))((double)(value)))

Since it works fine with just one template parameter, the issue might be related to the comma inside Cell<4, 1>.

Originally reported by @shifty91

Moved from https://bitbucket.org/gentryx/libflatarray/issues/16/libflatarray_register_soa-does-not-work

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.