Giter Club home page Giter Club logo

nette-comgate's People

Contributors

geniv avatar mikkuba avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

mikkuba

nette-comgate's Issues

isPost()

Nice nette repo! :)

I would just correct action method in your ReadMe:

public function actionStatus()
    {
          $request = $this->context->getByType(Request::class);
          if ($request->isPost()) {

to

public function actionStatus()
    {
        $this->getHttpResponse()->setContentType("application/javascript");
        $request = $this->getHttpRequest();
        if ($request->getMethod() == "POST") {
..
...
....

I would suggest to set ContentType, because Comgate need clear response with code and message. With enabled debug mode (and Tracy). It will add Tracy bar at the end of the page. Also isPost() is deprecated since 2.3.0 and removed in 2.4.0 I guess.

But overall - Very good job!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.