Please update Bouncy Castle

• https://www.bouncycastle.org/
• https://www.bouncycastle.org/releasenotes.html
• http://www.bouncycastle.org/latest_releases.html
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncy%20castle
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncycastle
• https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.html

The file is bitrafael-client/src/test/java/com/generalbytes/bitrafael/api/wallet/bch/WalletToolsBCHTest.java.

In the method getMasterPrivateKey, the extended private key derived from the example mnemonic abandon abandon abandon with password of password is xprv9s21ZrQH143K25nXfd4XuZ6d955Y7XQ7GzSrew7bEYCx1eC6JixjXoaULDjgpB4BJaLL4BmCTka4L9Jq5rxstLcXLnVkGK4tkMk8D9iv1y8, which is correct.

But the test for the corresponding xpub key xpub6C9nRehjbvKLDD1Rzjshv5HaTm9Q1qFnraUZ34uVtbQzgAMFffuhTxN2umR6gfjWYyf4egfQVCbRegE9gMYCwbK3rsV8Xz1LU2KAHUvNaYB is not correct, as the correct key should be xpub661MyMwAqRbcEZrzmebYGh3Mh6v2Wz7xeDNTTKXCnsjvtSXErGGz5btxBU7Kyfy5EwthQ5ZRhQ2wqRHU5QCESg11V8bywtkRWhZNr94AgH9, from a couple different tests I've run.

I'm not sure if you're actually running these tests or not but if so, this would point to a bug in your code.

I would also recommend extracting these BIP39 type items to a separate library or area and only test those there, instead of together with BCH tests.

MoneroExample.java only the example of generating address, please help me, thanke you.

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?

• https://www.bouncycastle.org/
• https://www.bouncycastle.org/releasenotes.html
• http://www.bouncycastle.org/latest_releases.html
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncy%20castle
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncycastle
• https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.html

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?

• https://www.bouncycastle.org/
• https://www.bouncycastle.org/releasenotes.html
• http://www.bouncycastle.org/latest_releases.html
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncy%20castle
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncycastle
• https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.html

Linked to:

• #36
• https://github.com/GENERALBYTESCOM/bitrafael_public/search?q=spongycastle