geerlingguy / ansible-role-collectd-signalfx Goto Github PK

Currently, if you change the SignalFx token after you've first installed collectd, it is not changed in the Collectd SignalFx configuration file.

See: Ability to test install process without valid token?. For now, I'm going to find some way to work around the installation process. But at some point I hope to be able to have this role more end-to-end testable.

Setting the Hostname in /etc/collectd/collectd.conf is actually a little annoying to automate, since you have to make changes to two lines:

FQDNLookup false
Hostname www.example.com

So it would be nice if this role had a task to do this automatically. Something like:

- name: Set hostname in collectd configuration.
  lineinfile:
    dest: /etc/collectd/collectd.conf
    regexp: "{{ item.regexp }}"
    line: "{{ item.line }}"
    insertbefore: "{{ item.insertbefore | default('') }}"
  with_items:
    - regexp: "^FQDNLookup .+$"
      line: "FQDNLookup false"
    - regexp: "^Hostname .+$"
      line: 'Hostname "{{ collectd_hostname }}"'
      insertbefore: "^FQDNLookup.+$"
  when: collectd_hostname
  notify: restart collectd

Then you can just add collectd_hostname to set a custom hostname.

Reverting to not use a hostname and use FQDN instead would of course require a manual reversion; I'm not too worried about that though.