Giter Club home page Giter Club logo

Comments (10)

ctb avatar ctb commented on August 25, 2024 1

you rock! thanks, @rchikhi!

from bcalm.

ctb avatar ctb commented on August 25, 2024

Oddly enough my shorter automated workflow https://github.com/ctb/2018-bcalm-debug doesn't detect any problems. Must not trigger the right problem.

Note that when I compile bcalm from scratch on my HPC the spacegraphcats-twofoo-example above runs just fine and passes the reciprocal edges test.

from bcalm.

rchikhi avatar rchikhi commented on August 25, 2024

Thanks for the detailed report! I confirm that I can reproduce the behavior of #37 (comment) on my own Linux, when using bioconda's bcalm. The problem doesn't occur when using the current master branch of bcalm. So something must be going on with bioconda's version, I'm on it.

from bcalm.

ctb avatar ctb commented on August 25, 2024

from bcalm.

rchikhi avatar rchikhi commented on August 25, 2024

I think I see what's going on. Two bugs: 1) I thought BCALM outputted consecutive unitig IDs, but apparently with some compilers it had some rare inversions (e.g. 9,10,12,11,13,14,..). Likely a multi-threading bug. 2) The procedure used to link unitigs silently and wrongly assumed that unitigs needed to have consecutive IDs. I've commited a fix for both bugs and will release BCALM 2.2.1. @natir could you please update Conda when you have time, or show me how?

from bcalm.

ctb avatar ctb commented on August 25, 2024

ping! I'd suggest withdrawing bcalm from bioconda until someone has time to fix it.

from bcalm.

rchikhi avatar rchikhi commented on August 25, 2024

pinging @natir: bcalm 2.2.1 is released and needs to be updated in bioconda please :)

from bcalm.

natir avatar natir commented on August 25, 2024

@epruesse update bioconda bcalm to 2.2.1 in this pull request bioconda/bioconda-recipes#12811

from bcalm.

rchikhi avatar rchikhi commented on August 25, 2024

merci!

from bcalm.

ctb avatar ctb commented on August 25, 2024

from bcalm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.