face's People
face's Issues
name is nil sometimes
In some cases, person created has nil for name.
Move logic in get_people to person_group
get_people
does too much and makes it hard to read. Move to person_group
method.
NoMethodError when no canadidates
Handle case where Face has no candidates
Duplicated code: face rectangle copied twice
Reusing face rectangle in new_person
and add_face_to_person
method.
candidates are at least >= 0.5 probable. more elaborate algo can be used maybe?
Some cases the same person are identified different. Use a higher tolerance possibly?
Degrees of relationships should be dynamic
Implement algo to allow arbitrary relationship distances (can cap up to 6)
**minor** [0] => first where possible
get_people method is hard to read
Lot of temporary variables and lack of clarity. Should be refactored for readability.
Existing people not being properly saved or grabbed from Microsoft Face API database
As per title
Possible issues:
- People not properly being saved
- People ids are not properly being retrieved
- Failed call
- Mismatch of
person_id
on local database side
**major** database migration to PostGres if using Heroku
MySql not supported database. Need to convert to usable database.
photo, image_data are similar
Passing photo
and image_data
around everywhere. We only use photo
in new_person
case, which could be moved to normalize_people
instead?
- Problems:
new_person
is only case where we add person so misleading to add it in normalizing...
*major* Model does not properly match faces sometimes
as per title
add_face_to_person method should not know Person model
Currently add_face_to_person
method in FaceApi
consumes a Person
object but only id
is used. No knowledge needed for everything else
create flush button
Time consuming to re-create new users everytime. Best to have a flush
button (when clicked, deletes all entries in database and azure database).
Incomplete refactoring for code duplication
Need to reuse the ApiSetup module more. Not enough being used in other modules. Too repetitive and using too many duplicated code can lead to poor maintenance.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.