garimaaroraa / hello-world-python Goto Github PK

pythonpackage.yml

        python-version: [3.7]

I think we should test against 3.8 as well.

if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
We don't really use requirements file, we have stuff in setup.py. So the following commands should work.

pip install # install prod deps
pip install ".[test]" # installs dev deps

Opinion: flake8 linting should be enabled by default to throw errors everywhere, and we should also use flake-annotations, which forces you to add type hints everywhere.
i.e. that would be the default way to do this and then you can modify it later on. So you will need to add something like this
python -m pip install --upgrade black flake8 flake8-annotations
python -m flake8 . --show-source

Also include black in the pipeline which executes like
python -m black --check .

Also let's fail if coverage is not at a certain point.
python -m pytest --cov=<module_name> --cov-fail-under=85 -m 'not integration'