garagescript / c0d3-app Goto Github PK

https://github.com/garageScript/c0d3-app/pull/64/files?file-filters%5B%5D=.scss&file-filters%5B%5D=.svg&file-filters%5B%5D=.tsx#diff-5da9e1296552b69aedaaf21b8ef4e55b

https://app.zeplin.io/project/5e19606fd539a701e62f9d70/screen/5e44ed56127ab694c3bd4349

1. Next.js template
2. Typescript
3. ReadMe

As a user, if I am already logged in and I visit v2.c0d3.com I should automatically go to curriculum page.

• Loading
• Disabled
• Correct Color

Install StoryBoard.

urls should be retrieved for env variable.

We should keep a catalog of requested revision submissions so you can follow up with the conversation if they have any further questions. Otherwise you have to ask them to send the code to you what you submitted and what feedback you gave so you can properly analyze the scenario.

AC

• Reviews should be a separate card (ignore the comments section). User profile image is not be necessary.
• https://app.zeplin.io/project/5e19606fd539a701e62f9d70/screen/5e44ed5757b4ff8a25025f13

AC - Left side

• Left pane should display all challenges for lesson.
• On the left pane, when user has completed the challenge, it should indicate so.
  • Other status (untouched, pending review, rejected)
• The right pane must display challenge content when the page first loads
• When the user clicks on the challenge navigation on the left, the right pane must display the correct lesson content.
• If user has pending or approved submission, their submission must be visible under lesson content along with reviewer feedback (if any)
• Submission code diff should render the diff UI correctly
• Reviews should be a separate card (ignore the comments section). User profile image is not be necessary.

Our app dependency on server_url secret is causing a server_url blocker where we need to authenticate before auto deploying.

Fix - Please remove the secret dependency so our auto deployments does not get blocked by approval.

Suggestion: use layout with BootStrap loading icon

AC

• The right pane must display challenge content for the challenge the challenge user is currently on (first incomplete) when the page first loads

The way SVGs are processed, we are getting build errors because data is not a valid attribute.

To fix, remove minification plugin until a fix is resolved (svgo)

Loading component created a nasty UI bug:

#135

@Wolfy64 describes the issue:

The <Spinner/> is wrapped by<Layout/> who is include the navBar. that explain the UI bug
Now the DOM error is because <Spinner/> is wrapped by  <Layout/> and <Layout/> is wrapped by the spinner lol 
(edited)

Inception!

Why is there a rendering issue? Watch the attached video. First you get a messy and ugly flicker then the page loads.

https://js5.c0d3.com/assetExercise/renderingIssues.mp4

Signup Page must work as expected.

AC

• If fields are wrong, make sure to display error fields
• If signup is successful, take user to the curriculum page.

AC

• If user has pending or approved submission, their submission must be visible under lesson content along with reviewer feedback (if any)
• https://app.zeplin.io/project/5e19606fd539a701e62f9d70/screen/5e44ed5757b4ff8a25025f13

Update Ze.it to use new domain.

AC

• As a user currently on JS1, when I click on View Challenges button I should be taken to the lesson page.
  • URL path: Should take users to the lesson page. curriculum/<id of lesson>
• Lesson Page must show the correct challenge on the left pane.

Tech Debt - There are too many card components

LessonCard, ReviewCard, LoginCard

should just be a Card component with width prop

AC

• When users clicks on Start Lesson link, they should be taken to the notion doc on a new tab.

Currently Curriculum Page was not required, leading to a drop in code coverage.

AC - Code Coverage back up to 100%

AC

• Should display correct number of pending submissions

As title states, it would be nice to have the full stack that will be used for the project available as a list in README in order for students to do some research into each technology. Feel free to close if we don't want that information available to everyone. Thanks!

AC

• On the left pane, when user has completed the challenge, it should indicate so.
• Other status (untouched, pending review, rejected)
• https://app.zeplin.io/project/5e19606fd539a701e62f9d70/screen/5e44ed57cf17278c82cb74ef

Not high impact, but potentially affecting users in the future

AC

• Submission code diff should render the diff UI correctly

The order property on lessonInfo data

export const GET_LESSON = gql`
  query lessonInfo($lessonInfo: LessonId, $lessonUserInfo: LessonUserId) {
    lessonInfo(input: $lessonInfo) {
      id
      title
      description
      order
      docUrl
      challenges {
        id
        description
        title
        order     <------------------------------------------
      }
    }
    userSubmissions(input: $lessonUserInfo) {
      id
      status
      mrUrl
      diff
      viewCount
      comment
      challengeId
      reviewer {
        id
        username
      }
      createdAt
      updatedAt
    }
  }
`

does not map correctly to the SVG images.

1. Must show x submissions to review

AC

• When the user clicks on the challenge navigation on the left, the right pane must display the correct lesson content.

TODO:
load first challenge that has not been completed by default

If the user manually enter a urrl i.e. https://c0d3.com/curriclum/23 which does not correspond to a correct lesson, it should redirect the user to an error or 404 page.