Giter Club home page Giter Club logo

Comments (6)

galkahana avatar galkahana commented on July 20, 2024

Good. How about you add your solution to hummus?

from pdf-writer.

TheGS avatar TheGS commented on July 20, 2024

I'd like to, especially since this particular modification itself is trivial to do, but I'm limited in how directly I can contribute at this time. I'm working on changing that, though

from pdf-writer.

galkahana avatar galkahana commented on July 20, 2024

@TheGS just to clarify this. basically if something coming from seac then Type1Input::GetGlyphCharStringName() should be forced to go to the else part? i could add a "force" there in that case. would that make sense?

On another matter. mind looking if my latest commit is not complete idiocy - adding support for symbol encoding, hoping i don't hurt anything...seems like i don't, but i wanted an expert opinion. here - fa35726

from pdf-writer.

TheGS avatar TheGS commented on July 20, 2024

It looks like the only code that ever sets CharString1Dependencies::mCharCodes is Type1Input::Type1Seac() and the only code that ever consumes CharString1Dependencies::mCharCodes is Type1ToCFFEmbeddedFontWriter::AddComponentGlyphs(), so it should be safe to just get the encoded glyph name from StandardEncoding inside the AddComponentGlyphs() implementation.. in the case of 'seac', the encoding of the font never needs to be consulted, since 'seac' requires its component character glyph codes to be in Adobe Standard Encoding by definition. That's what we ended up doing.

from pdf-writer.

galkahana avatar galkahana commented on July 20, 2024

Makes sense. Thanks

from pdf-writer.

galkahana avatar galkahana commented on July 20, 2024

k. should be taken care of with cc3b48f

from pdf-writer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.