Giter Club home page Giter Club logo

Comments (2)

galkahana avatar galkahana commented on July 4, 2024

Hi,
I think that what you are doing is mostly what should be done. There's some usages of StartPDFStream with a dictionary in PDFWriter itself, that if im comparing to have a slight difference. For exmaple, here's code for writing CFF fonts that uses StartPDFStream in the same manner you're trying to use it:
https://github.com/galkahana/PDF-Writer/blob/master/PDFWriter/CFFEmbeddedFontWriter.cpp#L95

The key difference is that creating the dictionary context is done via the ObjectsContext::StartDictionary method as opposed to creating a new dictionary object directly. so, change your code to this for it to work:

DictionaryContext *dictionaryContext = objectsContext->StartDictionary();
dictionaryContext->WriteKey("Type");
dictionaryContext->WriteNameValue("EmbeddedFile");
PDFStream *pdfStream = objectsContext.StartPDFStream(dictionaryContext);
IByteWriter *mwriter = pdfStream->GetWriteStream();
mwriter->Write(inAttachment->FileContent, inAttachment->Lenth);
objectsContext.EndPDFStream(pdfStream);

The reason for the mishap in the code you ran is that dictionaries must be registered at ObjectsContext in an attempt to make starting and ending dictionary consistent (it makes sure that StartDictionary and EndDictionary are called on the same dictionary in case of nesting). StartPDFStream calls EndDictionary, but since the dictionary in the code sample you provided is NOT registered in ObjectsContext there's a failure and so the dictionary end writing is skipped. StartPDFStream does not seem to check the return status code from EndDictionary (there's only a log if you activate logging) which is why it slilengtly continues to just writing the stream keyword and the rest of the stream. (here's some documentation about StartDictionary/EndDictionary in more documentation about the ObjectsContext - https://github.com/galkahana/PDF-Writer/wiki/The-ObjectsContext-Object#dictionary-writing)

i'm gonna fix StartPDFStream to fail if EndDictionary doesn't end well and return null stream pointer...which would very loudly indicate a problem.

from pdf-writer.

tangdouer1005 avatar tangdouer1005 commented on July 4, 2024

yes! With your help, I made it!
In fact, I tried to use objectsContext.StartDictionary() to create DictionaryContext, but I always used this function objectsContext.EndDictionary(DictionaryContext* inDictionaryContext) by mistake, which would lead to Segmentation fault error.
like this.

        result.second = objectsContext.StartNewIndirectObject();
        DictionaryContext *dictionaryContext = objectsContext.StartDictionary();
        dictionaryContext->WriteKey("Type");
        dictionaryContext->WriteNameValue("EmbeddedFile");
        objectsContext.EndDictionary(dictionaryContext);           // my mistake
        PDFStream *pdfStream = objectsContext.StartPDFStream(dictionaryContext);
        IByteWriter *mwriter = pdfStream->GetWriteStream();
        mwriter->Write(inAttachment->FileContent, inAttachment->Lenth);
        objectsContext.EndPDFStream(pdfStream);

I used to think it was because objectsContext could not create other objects before PDFStream was created.
as it says in the wiki

Important – Streams MUST always be written inside an indirect object definition. So make sure to call StartNewIndirectObject (or when modifying, StartModifiedIndirectObject), before starting the stream, and make sure you are clear of any object writing at the time.

In fact, I misunderstood wiki.
Now I understand that the reason for my Segmentation fault is that I repeatedly released the DictionaryContext, but I didn't think of this at the time.

thanks!

from pdf-writer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.