gajop / spring-launcher Goto Github PK

i.e. http://logs.springrts.com/logfiles/234/

"pr-downloader 0.7-524-g8eab580"

where to to file a bug about this?

http://logs.springrts.com/logfiles/570/
http://logs.springrts.com/logfiles/583/
http://logs.springrts.com/logfiles/589/
http://logs.springrts.com/logfiles/527/
http://logs.springrts.com/logfiles/526/
http://logs.springrts.com/logfiles/525/
http://logs.springrts.com/logfiles/524/
http://logs.springrts.com/logfiles/501/
http://logs.springrts.com/logfiles/460/

http://logs.springrts.com/logfiles/574/
http://logs.springrts.com/logfiles/562/
http://logs.springrts.com/logfiles/593/
http://logs.springrts.com/logfiles/595/
http://logs.springrts.com/logfiles/600/
http://logs.springrts.com/logfiles/539/
http://logs.springrts.com/logfiles/538/

electron-userland/electron-builder#4711

Since I can't comment and re-open the issue...

Related to this:
#19

Removing the engine from the list of downloads results in it not launching chobby at all with a predictable error:
http://logs.springrts.com/logfiles/141/

Which brings me back to my original request of:
The current method is a setup for failure that is tied to an arbitrary "has it been deleted yet?" spring build deletion cycle.

The entire point of portable is to be self contained insomuch that is has the base game and engine distributed with it (ignoring the fact that checking for game/luamenu updates happen upon launch <- this is to be expected). So it doesn't make sense for the launcher to fail because it's checking for an engine build it already has.

Portable shouldn't be trying to download the engine at all. If you are using the portable build then it is clear and should be obvious that that comes with maintenance responsibilities.

With the added caveat that I should be able to tell chobby launcher what engine version it is to use without it trying to download it.

One of the key issues with spring-launcher are the big autoupdate sizes. Perhaps multipart/byteranges support is necessary?
See https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/differentialDownloader/multipleRangeDownloader.ts

http://logs.springrts.com/logfiles/582/

http://logs.springrts.com/logfiles/503/
http://logs.springrts.com/logfiles/580/
http://logs.springrts.com/logfiles/577/
http://logs.springrts.com/logfiles/573/
http://logs.springrts.com/logfiles/581/

spring/pr-downloader#127

Auto-update should:

• check for auto updates in a very fast way. timeout fast (couple of seconds in the worst case)
• allow for game/tool to be used without auto-updates (if it fails, for whatever reason, allow continuing to the next step)

http://logs.springrts.com/logfiles/206/

We should either bundle this with the launcher or tell users that they need to download it

http://logs.springrts.com/logfiles/533/
http://logs.springrts.com/logfiles/424/

Desired modules:

• downloading via pr-downloader (and perhaps other providers such as http and git?)
• launching spring and handling the spring process
• communicating to spring via a command-based protocol
• uploading user logs to http://logs.springrts.com/

.. something else I'm forgetting?

http://logs.springrts.com/logfiles/248/

http://logs.springrts.com/logfiles/568/

Am I expected to supply my own config.json?

http://logs.springrts.com/logfiles/566/

[Sun Mar 15 2020 16:18:06 GMT-0400 (Eastern Daylight Time) warn] [Error] ../../tools/pr-downloader/src/pr-downloader.cpp:262:DownloadStart():Insuffcient free disk space (268 MiB) on C:\Program Files\Beyond-All-Reason\data: 1024 MiB needed
[Error] ../../tools/pr-downloader/src/main.cpp:221:main():Error occurred while downloading: 5

http://logs.springrts.com/logfiles/569/
http://logs.springrts.com/logfiles/550/

Reported by silentwings here: Spring-Chobby/Chobby#457

Error:
⨯ image /Users/masterbel2/Spring/Sources/spring-launcher/build/icon.png must be at least 512x512
Upscaling the image to 512x512 removed the error, and the build completed successfully.

Did not submit a PR since I don't have a true 512x512 icon.

(to github? or to infolog service we have?)

It's a persisting error several users had lately with BAR. Example infolog:
http://logs.springrts.com/logfiles/523/

This user allegedly fixed it by reinstalling and toggling "install for all users" instead of "only for me". Not sure if this was actually caused by that, but I've heard of other applications having networking errors due to not being installed globally on windows. Perhaps it treats those with higher level of caution or something. One example of such app is "Search Everything".

Can it be toggled to all users by default?

http://logs.springrts.com/logfiles/576/
http://logs.springrts.com/logfiles/575/
http://logs.springrts.com/logfiles/561/

The current method is a setup for failure that is tied to an arbitrary "has it been deleted yet?" spring build deletion cycle.

The entire point of portable is to be self contained insomuch that is has the base game and engine distributed with it (ignoring the fact that checking for game/luamenu updates happen upon launch <- this is to be expected). So it doesn't make sense for the launcher to fail because it's checking for an engine build it already has.

Portable shouldn't be trying to download the engine at all. If you are using the portable build then it is clear and should be obvious that that comes with maintenance responsibilities.