ga-wdi-boston / api-token-auth Goto Github PK

even if they only console.log.

Avoid oneliner arrow functions and the time and confusion that result?

so replace

const signIn = (data) =>
  $.ajax({
    // ...
  });

with

const signIn = function (data) {
  return $.ajax({
    // ...
  });
};

As opposed to hardcoding API URL in curl scripts

We show them resources, and we show them auth, but never an authenticated resource request. If @gaand's vision of doing everything authenticated from the start comes true, I don't think this is necessary, but if I have extra time tomorrow, I may talk a little bit about how to do that.

jQuery.ajax, FormData, etc.

setup functions like

const changePassword = function changePassword(foo){}

@gaand and @jrhorn424 both came up to me after this lesson and mentioned that the lesson left out a good bit of the "why" and focused mostly on the "how." I agree that this is important, but also looked back and noticed that it doesn't exist at all in the README. It should be added. If not by them, than by whoever delivers this next.

via @gaand

Some scripts use JSON, others use URL-encoded. Other than mentioning that URL-encoded is what actually gets sent over the wire, is there a purpose for doing both kinds for all scripts? Or is this something we can just show once with the sign-up or sign-in script and then just use the -json.sh scripts for the rest?

Add a reference and link to httpbin

Map to JavaScript use of app.api.

This feels very much like part of the jquery-ajax-foo sequence (even though it's technically not using the previous/solution -> current/master format, but doesn't follow the same naming convention. Do we a) want to put it into that sequence, where it follows that convention? Or rename it to above? Maybe this is two issues...

Building off of #5, explicitly export and require functions from different files.

See ga-wdi-boston/planning#5
(Formerly https://github.com/ga-wdi-boston/010/issues/4)

We created this in class.

demo has better example code. solution currently has the same code as master, which we typically consider starter code.

via @gaand

$ID and $TOKEN. This may need to be opened on library-api-guide, not here, but this is the repo that I noticed it in.

@gaand says: "These scripts are terrible and should be fixed!"
@gaand Please provide more detail about the nature of their terribleness. 🗡

Check the document carefully.

Which means we're teaching them to console.log and console.error, which is wrong.

@payne-chris-r asked me to open this. There are two scripts for the same thing and it's confusing.

change-password-json.sh and change-password.sh

via @gaand

via @gaand