fuzzykiller / download-cleaner-lite Goto Github PK

Options are invisible on dark themes like FT DeepDark

Would it be possible to add a separate option to toggle whether or not manually cancelled downloads are considered complete, so that they can be automatically removed while failed downloads remain?

Currently, startup removal is implemented in the extension’s initialization method. That means it also triggers when the extension is reloaded, upgraded or enabled for any reason really.

The Web Extension API offers the runtime.onStartup event.

For timers to be restored correctly however, reloads of any kind need to be handled, too. Perhaps the runtime.onInstalled event offers the desired behavior.

Further investigation is required.

I was not expecting the extension to clean out paused downloads. In removeDownloads:

// Skip in-progress downloads
if (download.state === "in_progress") {
  continue;
}

Could/should that either check for 'complete', or just additionally exclude 'interrupted' if you want to leave it open to cleaning out future state constants?

if (download.state !== "complete") {
or
if (download.state === "in_progress" || download.state === "interrupted") {

As-is, failed/paused downloads just vanish when using the delay option.

Firefox 108 x64, Windows 7 x64, i5 6600k

Settings:

• enabled: remove downloads after a delay (120 for example).
• disabled: remove downloads when starting.
• disabled: consider interrupted downloads as complete.

Result:
I can still see the downloads till 10 days ago..

It may not be possible to detect when the app quits, but it is certainly possible to detect when the app starts as at some point your extension will be initialized during startup, right? So how about an option to delete download history on start up? That would almost have the same effect to me as cleaning history is not a privacy feature for me, it's just for reducing UI clutter.

Downloads are currently removed with a delay of at least one minute. When the delay is set to 0, the download should be removed right away.

On Firefox 70(b5), there appears to be a regression in the downloads API. The extension does not receive any notifications about new or changed downloads.

When a download is started, the browser console displays these messages:

Further investigation is required.

Hello there,

Would it be possible to automatically reset the color of the downloads button (the down arrow) from blue (active) back to the default black (neutral), after the removal of downloads from history has taken place ?

Right now it stays blue indefinitely after the downloads history has been cleared out, which is distracting because the blue color supposedly indicates the presence of completed downloads in the history list (which aren't there anymore), hence the button should revert back to its neutral state.

Thank you very much.