I can't see any reason for it, but .gv-button gives left padding 25px and right padding 22px. It's not helping anything and the fact that the text isn't centered is just barely noticeable to someone with a keen eye

• hide other matches by default, make showable with boolean prop on ResultTable

The checkbox at the header of the table causes an error when clicked.

Checkbox list has lost its Checkbox -- has something to do with rearranging providers (seems related to a fix done for FilterList in 1.47.0) -- just need to import the Checkbox

If you use callback refs on a grey vest component, it doesn't actually set properly

Perhaps it should be separated.

right now there's no way to reuse the TagComponent that's used in TagsQuery in stand-alone TagsInput instances. Creates code duplication issues if you want your TagsInput instances to have tags that look like the GreyVest TagsQuery tags, since the default Tag you get with TagsInput looks a lot worse than the TagComponent passed into TagsQuery.

Just need a one-liner to export TagComponent

Follow up to #128

It’s used for cases where your filtering by something other than the key field, such as a case we have in one of our products where you have a combo field with a name and ID that you’re doing the terms aggregation on but only need to filter by the name.

The Date exampleType component should have another name. Currently, requiring this property alone overwrites the global object Date.

• Shrink Column Width by not showing which fields match in the column (just in modal)
• Render Empty Cell when there's no match

https://github.com/smartprocure/contexture-react/blob/master/src/exampleTypes/ResultTable.js#L258

mapNodeToProps = () => ({})

should not be fixed with _.constant({}) as that returns numerically the same empty object every time, which definitely isn't wanted for props on a component

Which is neat if you want to optionally forbid filtering.

If you have fields in the includes array which are omitted from the fields prop (to hide them from the table), the reordering logic won't work right unless all omitted fields are always at the end of the includes array. Here's the RCA from the ticket where we identified the issue in our product using this library:

Incorrect/non functional reording behavior is caused by omitting fields that are present in the includes array. The indexes are off because the array index i of the visibleFields referenced here https://github.com/smartprocure/contexture-react/blob/master/src/exampleTypes/ResultTable.js#L150 isn't actually the index of the field in the actual includes array, it's the index of the includes array filtering out anything we're hiding. So for example, if includes is [a, b, c, d] and you omit b, the visible column index for c is going to be 1 even though it's really 2 on the actual includes array.

This can be fixed a few different ways. We could:

• Patch contexture react so that when moving a column, we move it to be +/- 1 of the index whereever the occurence of the next visible item is (because if you have [a, b, c, d, e, f] and c, d, and e are all hidden, you have to know that moving b to the right actually means moving it to the end).
• Just make sure that hidden fields are always at the end of the includes array.

Need to change https://github.com/smartprocure/contexture-react/blob/master/src/exampleTypes/Facet.js#L92 corresponding to #123

Right now, theming is accomplished by components allowing you to override inner components via props. We currently create themes by using defaultProps from recompose and just packaging up all of the components. This works but makes it difficult to customize themes from outside the theme itself since it relies on components within the closure of the theme files.

A potentially better option is to introduce support for getting components from props or from a contextureTheme on context via Provider/inject. This would allow runtime changes of specific components so you could, for example, take the grey vest theme as is but just tweak one small thing externally instead of having to duplicate most of the theme. It would also make theming a bit more maintainable as you wouldn't import components from a theme (which makes it difficult to change a theme globally - somewhat defeating one of the main benefits of the theming concept), you'd use the contexture-react components directly and set the theme in the root of your app with Provider.

Per this issue, we should make a new repo: mobxjs/mobx-utils#93 with the contents of https://github.com/smartprocure/contexture-react/blob/master/src/mobx-react-utils.js

It is not clear that "bellow the line" is applied to all tags.

Adding this:

TagsInput loses it's state between renders, which means that the tag currently being typed resets to empty string. For some reason, inputs are getting rerendered in some of search pages more than they should (likely due to loading indicators we don't really need there), but this also prevents us from implementing the "backspace" functionality to restore a tag. The plan was to wait for react 16.8's hooks to implement functional state, but we might be able to nest components deeper or something to work around it now.

It would be nice to enter dates like 1118 to get 01/01/2018. We should find or build one and put it in an example story

Right now it just does nothing due to the !isPaused check:
https://github.com/smartprocure/contexture-react/blob/master/src/exampleTypes/ResultTable.js#L196

We should unpause when doing inline filters if the target node is paused.

Makes debugging harder. It also forwards all props which is causing this error"
Warning: Received `true` for a non-boolean attribute `loading`.

#180 broke it. Selecting any value throws.

Right now disableFilter is only used in the results table. The intention is that a field's results should be displayed but should not be filterable.

Right now the terms stats component shows details on a click on a row even if the click target is a child of the row that's supposed to be independently clickable. We should rewire this so that the click handler is only active if you ask for it or pass a different one in.

Add HERE Maps based geo filter component

OnChange argument should be an event object. Code is broken currently since it assumes a simple value instead of an event object.

onChange={x => {
        let { from, to } = _.find({ label: x }, ranges)
        tree.mutate(node.path, { from, to })
      }}

related issue: https://github.com/smartprocure/bid-search/issues/855

issue to track progress on overriding the default HTML5 element date component

Better address formatting which does not auto start with the country etc

Right now the search input bar is also sticky, which is weird when scrolling especially with a lot of tags on a small screen. We'd like to find a way to make just the button sticky. The main challenge here is that sticky only scrolls inside a parent - so we'd likely need to move the search bar into a single top level grid that includes the results so that the button's parent can take up the full height of the results.

Need to improve the usability of the facet options text field for filtering options -- right now it loses focus on every update.

The number type in contexture-elasticsearch supports lots extra analysis to help find the best range.

We should add a BestRangeButton example-type component that captures the client side functionality for this and export it, along with a higher order BestNumberRange component that just wraps up the existing Number example type component along with the new one (for use in dynamic filter lists, etc)

It's been brought up a few times that jest snapshots in contexture-react add little value and are mostly just annoying. The only value they seem to provide is as a warning if you changed more DOM structure than you expected, but it seems like no one really looks at them anyway. Should we rip them out?

In a currency input you don't want 3.14159. It's no good to round or truncate with the existing formatter prop since if that changes the value when it becomes the value of the input it will trigger a search update. Need to implement a significantDigits prop to which values will be rounded when they're set rather than when they're displayed.

follow up to #195 -- the findBestRange results need to be rounded to node.significantDigits when set in the Number example type

GeoFilter geo util should accept parameters to the 2 functions for the config values.

currently sets align-items to baseline. Should be center.

Make sure paused is false before attempting to filter columns in the result table component since filter information is sometime based on query results.

Need a couple styling changes to the example types default modal to account for the fact that we get some pretty unruly content in there

• set a px max-width instead of fit-content since that's experimental and isn't working with the crazy nested tables that come through
• overflow-x: scroll
• change the current padding to a border so x-scrollable content scrolls within the visible whitespace instead of over it

Pretty sure it's as simple as:

props => ReactDOM.createPortal(
  <Modal {...props} />,
  document.body
)

This will fix issues with Modals inheriting styles from their parents, like opacity.

Right now, our popover renders under the parent's DOM node, making it susceptible to clipping even with a large z-index. Moreover, it can mess up the layout when it shows since it occupies space. The solution is to use a react portal to move it out of its parent's DOM node but to also get a reference to it so it can render in the correct position. We might want to wait until we use react with hooks to make this easier.

Alternatively we could look into a library like https://github.com/alexkatz/react-tiny-popover
This one is pretty small: https://github.com/dbtek/react-popover

I don't see a sort arrow anymore.

Should probably do this after all the initial code is in

We should consider prefixing prop names with an underscore. So _tree and _node to prevent unintended overwriting of the existing component props.

https://github.com/smartprocure/contexture-react/blob/master/src/example-types/components.js#L34-L37

• SearchRoot needs to be able to take a path, e.g. <SearchRoot tree={root} path={['root', 'criteria']} />
• Make some kind of functional field picker (text input box is fine)
• Make facet example type functional (show context options as checkboxes and dispatch when checked or use a data reaction)
• Make a functional query type (can be a text input mimicing "raw mode" and kill the words array thing we already have)

Description

• it's possible to get a TypeError in the TagsQuery component when getting the join on a null node
• switch to _.get

Fix broken storybook

The pager should hide itself if there's only 1 page

We import it in example types

need to make the contents of the field picker sorted, default alpha with a prop to override

https://github.com/smartprocure/contexture-react/blob/master/src/exampleTypes/ResultTable.js#L59 is getting us a react warning when it turns out the labels aren't unique.