Type of issue

Feature request

Description

There seems to be no way to set up redirects (302s) to external urls. I understand this might be to keep consistent behavior with react-router v4's browser redirect behavior. Perhaps we can offer an <ExternalRedirect> component in fusion-plugin-react-router to workaround this?
Alternatively, if there's some way of doing this otherwise, please document it.

Current behavior

Right now, in order to set up an external redirect route, I'm doing this. This method is clearly sub-optimal since the browser is loading the page with a null component just to redirect (and there's no way to leverage 302 status code here):

    <Route
      path={`/go-to-google`}
      render={() => {
        if (__BROWSER__) {
          window.location.href = 'https://www.google.com';
        }
        return null;
      }}
    />

Expected behavior

Support a syntax like:

    <Route
      path={`/go-to-google`}
      render={() => <Redirect to={"https://www.google.com"} />}
    />

Type of issue

Bug

Description

When fusion-core was updated to strip the routePrefix from ctx, the router plugin was never updated to handle this behavior.

Current behavior

Links and route matching don't work as expected.

Expected behavior

Links and route matching should work with the routePrefix.

Steps to reproduce

1. run a Fusion.js application with the ROUTE_PREFIX environment variable set
2. add some <Route> components and <Link> components

Type of issue

Teams would like to be able to access the history object that we use in this plugin for various use cases. One of them being syncing state to redux in https://github.com/ReactTraining/react-router/tree/master/packages/react-router-redux

Description

Add a RouterToken which we can use as a dependency to get access to history.

createPlugin({
  RouterToken: router
}, ({router}) => {
  // Will I be able to do this?
  router.from(ctx).history

The exported Link component doesn't have type annotations, so when imported, it is any.

Problem/Rationale

Documentation regarding Fusion API is out of date given recent changes to leverage new Dependency Injection architecture.

Solution/Change/Deliverable

Update documentation

The ROUTER_DATA element should be optional, so we can support non-ssr browser loads.

In theory users could emit events with primitive values
for the event payload. We should only try and extend the
payload if it is a truthy object.

Type of issue

Bug

Description

When rendering the Status component on the server if multiple children are passed in only the first is rendered.

Current behavior

Only first child is rendered

Expected behavior

All children should render

Your environment

• fusion-plugin-react-router version: 1.5.3-alpha.0

Type of issue

Bug

Description

On the browser the Redirect component will cause an exception

Current behavior

Exception is thrown

Expected behavior

Should work on browser and server

Steps to reproduce

1. Render Redirect component in the browser
2. See the error: 'checkPropTypes.js:19 Warning: Failed context type: The context router is marked as required in Redirect, but its value is undefined.'

Your environment

• fusion-plugin-react-router version: 1.5.0-1

Type of issue

Feature request

Description

Instead of using the globally scoped event emitter using an emitter scoped to the request should allow us to log events with context specific details (actual path and headers from the request). This would also require the context object being passed into the emit call.

Current behavior

pageview:server is emitted on the global event bus and does not include context.

Expected behavior

pageview:server is emitted on a event bus scoped to an individual request and includes the context.

Server side redirects are setting the status
code correctly, but are not adding the Location
header. We should use ctx.redirect

Type of issue

Bug

Description

MemoryRouter does not provide onRoute into child context
Besides it would be nice to be able to override onRoute with some mock function

Current behavior

When using MemoryRouter for UnitTesting it fails with following error:
TypeError: context.onRoute is not a function

Expected behavior

Should not fails on this step

Steps to reproduce

run following test snippet:

    const component = mount(
      <MemoryRouter initialEntries={['/test']}>
        <Route path="/test" render={() => <div>Test</div>} />
      </MemoryRouter>
    );

    expect(component.find('div').text()).toBe('Test');

Your environment

• fusion-plugin-react-router version: 1.2.0

• Node.js version (node --version): 8.14

• npm version (npm --version): 6.4.1

• Operating System: OSX

I'm having trouble styling Link components. If you nest an anchor element or anchor component, Fusion will create another anchor instead of rendering one anchor. If you pass the Link component into styletron's withStyle, Fusion crashes.

Is there a way to style Links with styletron? I'd prefer to avoid using inline style and nesting a random element for the purposes of styling.

Type of issue

Feature request

Description

The render prop is the suggested approach for passing props to a Route from a parent component but fusion-plugin-react-router does not allow this property.

Current behavior

When passing the prop render to the Route component an error is thrown 'Cannot pass render function to tracking route'.

Expected behavior

Should be able to pass render to a Route

Your environment

• fusion-plugin-react-router version: 1.0.4

It should be fully compatible with v4: https://reacttraining.com/blog/react-router-v5/

The upstream and downstream timing events should probably be handled
by some standard stats library, not the router. It does make sense for
the router to emit render/pageview stats, but not more generic stats like
upstream and downstream.