Giter Club home page Giter Club logo

legioninvasiontimer's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

legioninvasiontimer's Issues

Suggested improvement

If someone would have the time, you might be able to actually put the zone coming up next. Both wowhead.com and worldofwarcraft.com forums have lists of the rotation Blizzard uses. Would be nice to know if it was a zone with an emissary quest pending.

Legion timer header for candy bar is on when LDB mode is selected

If LDB mode is pikced without locking up window with canfybars, then header is always shown on sceen because legionTimerDB.lock never become true, is not possible to lock it when LDB mode is ticked in options

	if legionTimerDB.lock then
		f:EnableMouse(false)
		f.bg:Hide()
		f.header:Hide()
	end

LDB source not registered in ElvUI

LDB plugin library is not included in package and not listed in embeds.xml, in code is library required by:

local ls = LibStub("LibDataBroker-1.1", true)

This library is dynamicaly registered only after bar starts, but it need to be inicialized at load or it will not be recognized by addons supporting LDB like ElvUI, because list of available LDB sources is checked on application load. This change in code fix it and register as source. In fact there is no reason why not have support for LDB on even if candybar is primary target.

	local ls = LibStub("LibDataBroker-1.1", true)
	local obj = ls:NewDataObject("LegionInvasionTimer", {type = "data source", icon = 132177, text = "..."})
       	function obj.OnTooltipShow(tooltip)
       		if not tooltip or not tooltip.AddLine or not tooltip.AddDoubleLine then return end
       		ShowTip(tooltip)
       	end
	local prevTime, label, repeater = 0, "", false
	local function update()
		prevTime = prevTime - 60
		obj.text = label..": ".. SecondsToTime(prevTime, true)
	end
	startBroker = function(text, timeLeft, icon)
		if obj then
			obj.icon = icon
			obj.text = text..": ".. SecondsToTime(timeLeft, true)
			prevTime = timeLeft
			label = text
			if repeater then repeater:Cancel() end
			repeater = C_Timer.NewTicker(60, update)
		end
	end
end

[Enhancement] Option: Only load for character level > 97

Add an option to only load/display if the current character is above level 97 (98+).

A more complex alternative: provide a means for the player to select a minimum level such as a slider (reasonably user-proof) and/or text box.

[Suggestion] Add Incursion Timers

Hello! Thank you for your work on this addon!

Might it be possible for you to add timers for the new 8.1 faction assaults (formerly called incursions) as well?

Addon unresponsive

Addon installed, confirmed enabled.

/lit, /legioninvasiontracker give the 'Type /help for a listing of a few commands' error. In-game, it doesn't appear in the addon options under interface.

I see no timer bars on-screen, on the map, and no LDB module.

Position of the timer bar

Hi,
I just recently tried your addon. So far so good.
I realised that there is no profile management like in other addons.
NOT needed for a small addon like this.

But there's a small issue.
When you have many different chars. You login and you always have to position the bar manually.
When you want to have it on the exact same position like on your other chars it's a bit trickey.
You have to make a screenshot if you want to have it the same. And manually move it with the mouse.

So 2 things are possible:

  • Add a X Y coordinates to the size fields you already have. So we can type into the textfield x200 y400 or something
  • If you move it on one char, you move it for the others aswell. Global position setting. But I guess that's not for everyone nice, since some whant it on different positions. So I would pref the x y coordinates

Frame Location

Will you consider saving the frame's SetPoint in legionTimerDB? I have the frame locked, so whenever I log into a new character, it's stuck in the center of my screen.

Options not accessable in broker

Unable to access the options menu when addon is configured for broker. and also because of that unable to disable the broker option

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.