fullstack-hy / flight-diary Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 3.0 55 KB

TypeScript 100.00%

flight-diary's People

Contributors

Stargazers

Watchers

Forkers

5p1n0 onzfonz

flight-diary's Issues

utils.ts missing eslint disable comment from isWeather and isVisibility

src/utils.ts does not match the course material and is missing comment from the isWeather and isVisibility functions.

 // eslint-disable-next-line @typescript-eslint/no-unsafe-argument

code should match below:

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const isWeather = (param: any): param is Weather => {
  // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
  return Object.values(Weather).includes(param);
};

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const isVisibility = (param: any): param is Visibility => {
  // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
  return Object.values(Visibility).includes(param);
};

dairies.ts try/catch statement missing type guard

The try catch statement in src/routes/diaries.ts is missing a type guard. The course material references this type guard, but the source code is out of date.

The code should match below:

router.post('/', (req, res) => {
  try {
    const newDiaryEntry = toNewDiaryEntry(req.body);
    const addedEntry = diaryService.addDiary(newDiaryEntry);    
    res.json(addedEntry);
  } catch (error: unknown) {
    let errorMessage = 'Something went wrong.';
    if (error instanceof Error) {
      errorMessage += ' Error: ' + error.message;
    }
    res.status(400).send(errorMessage);
  }
})