Individual toggle groups are rendered with the same ID. This needs to be updated to append the value to ensure IDs do not clash.

Add another container to the InputTrait to be able to assign meta information. An example use of this would be to pass validation rules or possibly config options for a renderer to apply to a specific input object.

I wonder if this is correct or not. Seems to be illogical to me.

Shouldn't it be $contentName?

Shouldn't this file go to the legacy package?

Should be done after #4

It is unclear whether setLabel() or setContent() (which is set by the constructor by default) should be used as the label of Option element.

Eg:

<?php
//Create the select element
$select = new Select();

$select[] = new Option()->setContent('red');
$select[] = new Option()->setContent('green');
$select[] = new Option()->setContent('black');

$optGroup1 = new Optgroup();

$optGroup1[] = new Option()->setContent('one');
$optGroup1[] = new Option()->setContent('two');
$optGroup1[] = new Option()->setContent('three');
$select[] = $optGroup1;

would become

<?php
Helper::generate('select', array(
  'attributes' => array(...),
  'options' => array(
    'red', 'green', 'black',
    array( 'one', 'two', 'three')
));

• Cleaning up duplicated code
• Getting test coverage up
• Logical restructure of elements #33
• Improve bootstrap renderer #23
• Cleaning up Builder (interface)

IMO calling setValue on select should deselect all the earlier selected values.

The current problem it occured: in the ModelProvider I showed on IRC first sets the default value. When I repopulate the form, the selected value does not override the default one.

I also think that it should be possible to determine whether an Option is selected or not. IMO this would be better on this line:

$attributes['selected'] = 'selected';

This also makes it super easy to deselect an item.

Optgroup is special in it's label. I think it usually has a label, so probably a constructor should ask for it.

Currently V1Model builder only accepts a model name and fetches the properties itself. IMO it would be better to be able to pass a properties array, so any custom modifications are possible before building the form.

There is a strange thing in list of elements, namely all of them are called "Input", but actually almost half of them are not. (I am referring to an element rendering into an input tag or not)

So I propose the following change: Rename the Input directory to Element and create an Input dir under it and move all real Input elements under it (with the necessary namespace changes of course).

Also, the inheritance should also respect this structure, eg. InputElement should only be used for real input elements.

There is no constructor in select field, which means the usual fieldname, attributes, default value call is impossible. There should be a constructor overriding the DataContainer's. And I think it is more important to be able give in field attributes instead of Options.

It seems there is no functionality to HTML-escaping when form building.

v1 has prep_value(): https://github.com/fuel/core/blob/1.8/develop/classes/form/instance.php#L627

There should be a general interface that is implemented by ALL fields. Currently there is no such thing.

IMO 'label' => $contentName, is missing from here.

Update the bootstrap renderer to use the metadata to turn features on an off like button type and if the element is contained in a full span div or not.