The nuget package https://www.nuget.org/packages/FSharp.Compiler.CodeDom/ doesn't express a dependency on FSharp.Core nuget

This should be fixed

Known workarounds

Have the consuming project add an explicit dependency on FSharp.Core nuget.

Description

When I call CompileAssemblyFromFile on my provider instance, the program throws the following error stack trace:

Unhandled Exception: System.ComponentModel.Win32Exception: The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at FSharp.Compiler.CodeDom.Internal.Compiler.compileFiles(String args, CompilerResults res)
   at FSharp.Compiler.CodeDom.Internal.Compiler.compileAssemblyFromFileBatch(CompilerParameters options, String[] fileNames, CompilerResults results, FSharpFunc`2 sortf)
   at Program.main(String[] argv)

This occurs despite the fact that System.IO.File.Exists returns true when passed in the file path.

Here is the full code:

open System.IO
open System.CodeDom.Compiler
open FSharp.Compiler.CodeDom


[<EntryPoint>]
let main argv =
    let sourceFilePath = Array.get argv 0
    if File.Exists(sourceFilePath) then
        let provider = new FSharpCodeProvider()
        let mutable compilerParameters = CompilerParameters()
        compilerParameters.GenerateInMemory <- true
        provider.CompileAssemblyFromFile(compilerParameters, [| sourceFilePath |])
        |> ignore
    else
        printf "File does not exist"
    0

Here is myfsproj file:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Program.fs" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="FSharp.Compiler.CodeDom" Version="1.0.0.1" />
  </ItemGroup>

</Project>

Repro steps

1. Create a new application using: dotnet new console -lang F#.
2. cd into the application directory.
3. Paste the above code block into Program.fs.
4. Paste the above config block into <application>.fsproj.
5. dotnet build (succeeds).
6. Create an F# source file in the same directory and save it as foo.fs. I used the following:

namespace Foo

type Bar = { baz : int }

7. dotnet run foo.fs

Expected behavior

The program executes without throwing an exception.

Actual behavior

The program throws System.ComponentModel.Win32Exception with the above stack trace.

Known workarounds

No known workarounds.

Related information

• Operating system: Windows 10, 64-bit OS, x64-based processor
• Branch: Hopefully master? (installed from nuget)
• .NET Runtime, CoreCLR or Mono Version: dotnet --version returns '3.0.100'

It is impossible currently to run it with Mono on Linux.
When .Net exe should be executed on Mono, Process.StartInfo.FileName should be "mono" and real executable name should be passed as first argument.
It would be also great if there would be possibility to pass fsc.exe through environment variable if it was not found in registry - it will give option to use FSharp.Compiler.Tools nuget package.

@drvink The build is broken, both on Windows and on Travis/Linux, I think in both cases because of the installer

C:\GitHub\fsprojects\FSharp.Compiler.CodeDom\Installer\ModifyMachineConf
ig\ModifyMachineConfig.csproj(71,3): error MSB4019: The imported project
 "C:\Program Files (x86)\MSBuild\Microsoft\WiX\v3.x\Wix.CA.targets" was
not found. Confirm that the path in the <Import> declaration is correct,
 and that the file exists on disk.

Description

As of today, CodeDom cannot be used in .NET Core 2.0 projects for F#.
Is it planned to support it in a near future?

Is it possible to declare parameters as option types?

For example, when creating a method like this:

var method = CodeMemberMethod {
    Name = "Test",
    ReturnType = new CodeTypeReference(typeof(string))
};
var parameter = new CodeParameterDeclarationExpression(typeof(FSharpOption<string>), "x");
method.Parameters.Add(param);

the generated code looks something like

            abstract Invoke : Microsoft.FSharp.Core.FSharpOption<string> -> string
            default this.Invoke  (fund:Microsoft.FSharp.Core.FSharpOption<string>) =

but I would like to be able to use the f# Option type, e.g.

            abstract Invoke : Option<string> -> string
            default this.Invoke  (fund:Option<string>) =

It looks like generateTypeRef or getTypeRef could be modified to map FSharpOption<> to Option<> when outputting the F# code, but is that the right thing to do or is there another way?

thanks!
Tony

Is it possible to sign binaries in the NuGet package? That would make it easier to use the binary from another project that will be signed (and, therefore, strong-named).

Hi, I have observed strange behaviour of FSharpCodeProvider class.
When I try to runCompileAssemblyFromSource for the first time, I got an exception that the outputassembly was not found. ( I assume that it will be generated, so why it should be present?)

But when I run the same code second time, then everything executes proprely...

you can find more details here: https://gist.github.com/severin-wokam/0ae5d22a5ed787a7e11f
or here: https://github.com/severin-wokam/FSharp.Scheduler/blob/master/src/FSharp.Scheduler/BootStrapper.fs

Not sure how CodeDom should look like on the image... So I am really appreciate any suggestions. Some initial options:
Option 1:

Option 2:

Option 3:

Option 4:

Option 5:

Description

when codeStrings has not only one string in it
provider.CompileAssemblyFromSource(params', codeStrings)
would throw exception at CodeProvide.fs

around line 113 when AddExtension("fs", false)

Repro steps

Expected behavior

different .fs file name should be generated and add to tempfiles

Actual behavior

the second Array.map would call AddExtension("fs", false)
but with the same file name

Known workarounds

I use guid string file name with AddFile to replace AddExtension

            sources |> Array.map (fun src ->
                let fn = Guid.NewGuid().ToString() + ".fs"
                res.TempFiles.AddFile(fn, false)
                use wr = new StreamWriter(fn)
                wr.Write(src)
                fn)

Related information

• Operating system
  Win 2012R2
• Branch
  master
• .NET Runtime
  4.6.1

See: https://bugzilla.xamarin.com/show_bug.cgi?id=24709 for detail.