frostbits-security / ccat Goto Github PK

Ran into an issue with the Smart Install check on a 16.12.x config file. vstack was not enabled for Smart Install and port 4786 was not open. However the tool returned a positive conformation.

This appears to be due to the logic in the check and the fact that in the 16.12.x config file vstack is not defined nor available.

if float(version) >= 12.2:
if 'vstack' in global_params['disable_service']:
results_dict['Services']['smart install'] = [2, 'DISABLED']
else:
results_dict['Services']['smart install'] = [0, 'ENABLED', 'Turn it off or block 4786 port (if "vstack" option unavailable) to disable smart install configuration']

Create series of tests to ensure that changes don't break anything (checks for example)

I love this project! I think I will really help me convince customers to let me add security features.

I'm not a coder, but if you need someone to work on documentation or other tasks I would like to help.

Thanks!
Michael Hubbard

TODO: exclude vlanmap from config list

Ability to output a machine readable output format that can be used to feed/check via other tools for conformance compliance

Hi

Just tying to use your tool. Unclear with the VLAN Map
In the JSON File

1. Are the numbers in the array the VLAN ID? if not how do i generate one for my config?
2. Are the Elements (e.g DMZ, Management, Other) in you sample VLAN map defined in other scripts or can i create my own segments E.g Office, internal , Guest and put the corresponding VLAN id in the array

Use PCI and NIST security standarts as an option

When i run the script on some configuration files for switches and routers, it gives the result only security and services and protocols but doesn't give any information about either enabled or disabled interfaces

networkx and matplotlib are missing in your requirements.txt file

Hi - I am running into an issue parsing port-security settings when my configuration has options set after the command switchport port-security maximum. Two examples I have found that break CCAT are switchport port-security maximum 2 vlan 10-11 and switchport port-security maximum 2 vlan voice.

The error I am getting is pasted below. Please let me know if there is anything I can do to fix this or work around it. Thank you.

Traceback (most recent call last):
  File "ccat.py", line 241, in <module>
    port_result = checks.port_security.check(interfaces[iface], vlanmap_result)
  File "/home/john/CCAT/checks/port_security.py", line 56, in check
    port_sec_check(iface_dct, max_mac, result, [0, 1, 2])
  File "/home/john/CCAT/checks/port_security.py", line 14, in port_sec_check
    if int(port_sec_dct['maximum'][0]) > max_mac:
ValueError: invalid literal for int() with base 10: '2 vlan 10-11'

iface_params['arp_insp']['mode'] is 'untrusted' or ['trusted'], this fucks up arp inspection check.