Bug Report

Current Behavior
While Nightmode is enabled, the plugin replaces:

-<link rel="stylesheet" media="" class="nightmode-dark" href="https://chat.spectre.app/assets/forum-dark-206d3f11.css">
+<link rel="stylesheet" media="" class="nightmode" href="https://chat.spectre.app/assets/embed-dark-607a4491.css">

Steps to Reproduce

1. Enable Flarum/Embed
2. Enable FoF/NightMode
3. Open an embed URL for a post, eg. https://chat.spectre.app/embed/40-an-algorithm-for-freedom
4. Notice forum CSS is removed and basic style is no longer applied.
5. Turn off JavaScript
6. Forum CSS is no longer removed.

Environment

• Flarum version: 0.1.0-beta.15
• Extension version: 0.7.1
• Website URL: https://chat.spectre.app
• Hosting environment: Free Flarum
• Browser: Firefox 87

Changes in Flarum 1.2 require an update in our overrides https://github.com/FriendsOfFlarum/nightmode/tree/master/src/Overrides

I have not tested locally but I believe this is the cause of the issue discussed at https://discuss.flarum.org/d/29963-v12-bug-report

ValidateCustomLess needs to be updated for the new Less variable system
https://github.com/flarum/core/blob/v1.2.0/src/Forum/ValidateCustomLess.php

Assets also has a few changes, it might be breaking the new extender
https://github.com/flarum/core/blob/v1.2.0/src/Frontend/Assets.php

I think RecompileFrontendAssets is fine like it is, only a deprecation comment was added.

Bug Report

Current Behavior

In Dark mode some strings of the code are not visible.

See here:
https://discuss.flarum.org/d/21492-friendsofflarum-night-mode/365

In vendor > fof > nightmode > resources > less > forum > extension.less line 115 - each time I update this extension, I have to override as below

    .App:before {
        background: rgba(0,0,0,0.1);
    }

This is required to match my existing theme - otherwise, the header is loaded with a style that seems to override that which is in custom CSS. Can this be looked at also ?

He! Thanks for that extension, it's awesome!

Would love to set my board as dark mode by default. So I thought that this extension is tight to the "dark mode switch" on the admin. But if I set my board as dark mode, well, you can't have light mode anymore :)

The color of the titles of unread discussions is almost black (#111) and unreadable in discussion lists.

Flarum Info

Flarum core 0.1.0-beta.8.1
PHP version: 7.2.12
Loaded extensions: Core, bcmath, calendar, ctype, date, filter, hash, iconv, json, SPL, pcre, readline, Reflection, session, standard, mysqlnd, tokenizer, zip, zlib, libxml, dom, PDO, bz2, SimpleXML, xml, wddx, xmlreader, xmlwriter, openssl, curl, fileinfo, gd, gettext, gmp, intl, imap, ldap, mbstring, exif, mysqli, Phar, pdo_mysql, pdo_sqlite, soap, sockets, xmlrpc, xsl
+------------------------------+-----------------+------------------------------------------+
| Flarum Extensions            |                 |                                          |
+------------------------------+-----------------+------------------------------------------+
| ID                           | Version         | Commit                                   |
+------------------------------+-----------------+------------------------------------------+
| flarum-approval              | v0.1.0-beta.8   |                                          |
| flarum-bbcode                | v0.1.0-beta.8   |                                          |
| flarum-emoji                 | v0.1.0-beta.8   |                                          |
| flarum-lang-english          | v0.1.0-beta.8   |                                          |
| flarum-flags                 | v0.1.0-beta.8.1 |                                          |
| flarum-likes                 | v0.1.0-beta.8.1 |                                          |
| flarum-lock                  | v0.1.0-beta.8   |                                          |
| flarum-markdown              | v0.1.0-beta.8   |                                          |
| flarum-mentions              | v0.1.0-beta.8.1 |                                          |
| flarum-statistics            | v0.1.0-beta.8   |                                          |
| flarum-sticky                | v0.1.0-beta.8   |                                          |
| flarum-subscriptions         | v0.1.0-beta.8   |                                          |
| flarum-suspend               | v0.1.0-beta.8   |                                          |
| flarum-tags                  | v0.1.0-beta.8.2 |                                          |
| botfactoryit-italian         | dev-master      | 091059d0cdc182f6abc9f68293100ff350c3c625 |
| clarkwinkelmann-emojionearea | 0.2.0-beta.1    |                                          |
| botfactoryit-b2-upload       | dev-master      |                                          |
| reflar-nightmode             | 0.2.0           |                                          |
| flagrow-impersonate          | 0.2.0           |                                          |
+------------------------------+-----------------+------------------------------------------+
Base URL: http://flarum.localhost
Installation path: C:\wamp64\www\flarum8
Debug mode: ON
Don't forget to turn off debug mode! It should never be turned on in a production system.

Instructions (MUST READ FIRST)

Before we can address your issues and concerns with the behavior of our work, we require every bit of detail from you to the fullest extent of this form. If this form is not properly filled out to it's entirity, we, ReFlar, reserve the right to close your issue due to lack of information thereof as well as not following instructions.

• By agreeing to these terms, you can simply leave this checkbox checked.

Please Mentally Go Over the Following Items Before Filling Out this Form:

• Can you reproduce this problem in debug mode?
• Are you running the latest version of this extension?
• Is your Flarum up-to-date?

Description

Flarum 14 doesn't appear to be supported, with Flarum's breaking changes like Mithril 2 and Laravel 6.

Steps to Reproduce

1. Install Flarum beta 14.
2. Activate extension.
3. Encounter breaking changes.

Looks like a pending pull request might cover these issues: #38

Bug Report

Current Behavior
FOF always sets the color-scheme meta tag to either light or to dark, this leads to styling bugs in certain situations with Chromium-based browsers.

Steps to Reproduce

1. Open Flarum in a Chromium browser (e.g. Chrome, Brave)
2. Go to "Settings"
3. Under theme Select "Automatic (based on browser or device settings)"
4. Refresh the browser or open a new tab
5. Open up a forum page

Expected Behavior
Scrollbars and form elements styling should always follow browser/device/user settings.

Screenshots

Additional Context
As a fallback where the color-scheme is not set Firefox automatically detects the colour scheme based on the background colour of the body element, this then leads to form controls and scrollbars styling taking either a light or dark look. Chromium browsers do not have a fall-back and require that you make the colour scheme explicit or it doesn't style the elements correctly.

The situation described above is not the only way to get the error - you can also load the page with a user selected "dark mode" and dynamically change it to light and everything will be wrong. You can also load the page with a user-selected "light mode" and dynamically change it to dark and everything will be wrong.

Solution
Always set the color-scheme meta tag to "light dark":

<meta name="color-scheme" content="light dark">

Additionally setting the CSS color-scheme property is required to support dynamically changing the page styling without reloading the page in Chromium browsers.

To forum.css add:

:root {
  color-scheme: light;
}

And to forum-dark.css add:

:root {
  color-scheme: dark;
}

es.yml.zip

Here is the Spanish Language
Im using the latest version

Hi

Thank you for this work !

Is it possible to purpose this function to anonymous users ?

Thank you

I met a problem about this

Uncaught TypeError: Cannot read property 'prototype' of undefined

Pretty small thing, but I would like to have the background of .DiscussionListItem-count to be removed. In standard flarum this element doesn't has a background and I don't think it really needs one in dark mode. On the other hand it is visible when the hover color of the .DiscussionListItem is changed:

• Can you reproduce this problem in debug mode? Now I can not
• Are you running the latest version of this extension? So newest, 0.1.3
• Is your Flarum up-to-date? Yes, it is current

Description

When I open a link in a discussion that opens a new tab, the background instead of being dark appears white.

Screenshot

https://imgur.com/a/A7iuYpa

Technical Details

• Version of Flarum: 0.1.0-beta.7
• Version of extension: 0.1.3
• Website URL where the bug is visible: https://forum.oxidepolska.eu
• The webserver you are running: nginx/1.13.12
• PHP version: PHP 7.1.17
• Hosted environment: VPS

Output info (ext)

EXT flarum-akismet v0.1.0-beta.6
EXT flarum-approval v0.1.0-beta.7
EXT zaptech-cookie-consent 0.1.0-beta3
EXT flarum-emoji v0.1.0-beta.6
EXT clarkwinkelmann-emojionearea 0.1.2
EXT flarum-english v0.1.0-beta.7
EXT flarum-flags v0.1.0-beta.7
EXT flarum-auth-github v0.1.0-beta.6
EXT sijad-recaptcha 0.0.2
EXT sijad-links 0.1.0-beta.6
EXT flarum-lock v0.1.0-beta.7
EXT flarum-markdown v0.1.0-beta.5
EXT ganuonglachanh-markdown-editor 0.9
EXT dogsports-pipetables 1.0.8
EXT flarum-mentions v0.1.0-beta.7
EXT antoinefr-money 0.5.0
EXT sijad-pages 0.1.0-beta.3
EXT wiseclock-profile-image-crop 0.1.1
EXT flarum-pusher v0.1.0-beta.6
EXT reflar-nightmode 0.1.3
EXT terabin-sitemap v1.0.2-beta.2
EXT sijad-auth-steam 0.1.10
EXT flarum-sticky v0.1.0-beta.7
EXT flarum-subscriptions v0.1.0-beta.6
EXT flarum-suspend v0.1.0-beta.7
EXT flarum-tags v0.1.0-beta.8

I couldn't directly find where the icon was defined, but can we replace that gear icon with the fo-sun FontAwesome sun icon or is it missing from the Flarum FontAwesome icon set?

Can I report a small issue maybe present also before?

Checkboxes like when you flag a post and need select an option or the check box to stay logged still have dark background if the light theme is active. Can be this fixed? The issue is resolved if the extension night mode is turned off.

Another small issue with the new extension is that night mode miss the night mode text.

Screenshots:

Thanks

Feature Request

Requested on discuss: https://discuss.flarum.org/d/21492-friendsofflarum-night-mode/358

By default, offer the same behaviour as currently (ie, auto, light, dark is available to all users), but optionally support restricting this via permission group(s).

I made an extension that highlights code blocks in the backend and it currently supports setting different values for both Flarum's "Light" and "Dark" theme. It is doing so by selecting the correct CSS file depending on the value of theme_dark_mode. But this does not work with fof/nightmode.

I get that with fof/nightmode the theme is switched in the frontend with JS. But how could I integrate with its behavior? It would be very useful to be able to register custom CSS files for light and dark themes and/or to be able to listen to some JavaScript event with something like:

document.addEventListener('FofNightmode', (event) => {
  if (event.theme == "dark") {
    // do something
  }
}

Related to #65, club-1/flarum-ext-server-side-highlight#3

Description

The title of Sticked posts is black in night mode.

Steps to Reproduce

1. Turn on night mode
2. Make a post
3. Sticky it

Expected Behavior: Text looks like any other post title

Actual Behavior:

Latest

hello,

There is a problem with traduction or... ?

http://j.axel-hauguel.fr/18122018-23:34:45.png

https://github.com/clarkwinkelmann/flarum-ext-high-contrast

@Shahiem you can basically tweak this to allow Night Mode with ease 😂

The setting in that joke extension for April Fools can make Night Mode user enabled.

Instructions (MUST READ FIRST)

Before we can address your issues and concerns with the behavior of our work, we require every bit of detail from you to the fullest extent of this form. If this form is not properly filled out to it's entirity, we, ReFlar, reserve the right to close your issue due to lack of information thereof as well as not following instructions.

• By agreeing to these terms, you can simply leave this checkbox checked.

Description

What is the current status of beta 9 compatibility? I'm inquiring as this hasn't seen any updates since December and the Solus project is currently evaluating the viability of updating from beta 8.2 within negatively impacting our users, so I'm wanting to ensure we don't have any blockers to doing so.

Thanks!

Description

Sorry i didn't create a pull request for this because extension.less seems too complicated for me.

Some parts are not compatible with night mode.

• Dropdown bg colors are wrong
• User mention still white
• Tags are white in discussion hero
• Reply and discussion views are not readable
• Discussion hover is white
• FoF Byobu and FoF Polls are not readable on composer
• Flags text are not readable

Expected Behavior: That parts are compatible with night mode.

Actual Behavior: [What actually happened (screenshots are welcomed!)]

Technical Details

• Version of Flarum (0.1.0-beta.12):
• Version of extension (0.4.0):
• The webserver you are running (Ubuntu):
• PHP version (7.2.24):
• Hosted environment (VPS):

Solution

// For dropdowns
body.dark .Dropdown-menu > li > a:hover, body.dark .Dropdown-menu > li > button:hover {
    background: rgb(33, 33, 33) !important;
}
body.dark .Dropdown-menu > li > a, body.dark .Dropdown-menu > li > button {
    background: rgb(26, 26, 26) !important;
}
// For back button (optional)
@media (max-width: 767px) {
.App-primaryControl>.Button, .App-backControl>.Button {
    color: #ededed !important;
}
}
// For user mention
body.dark .PostMention, .UserMention {
background: rgb(36, 36, 36) !important;
}
// For tags in posts
body.dark .DiscussionHero .TagsLabel .TagLabel.colored {
background: rgb(36, 36, 36) !important;
}
// For reply and view counters
@media (max-width: 767px){
body.dark .DiscussionListItem-count, body.dark .item-discussion-views {
        background: #2b2b2b;
}
}
// For discussion hover
@media (max-width: 767px) {
body.dark .DiscussionListItem-content:hover {
        background: rgb(36, 36, 36);
}
}
// FoF Byobu and Polls dark mode
body.dark .RecipientLabel, body.dark .DiscussionComposer-poll .PollLabel {
background: rgb(128, 128, 128);
color: rgb(255, 255, 255);
}
body.dark .DiscussionComposer-poll .PollLabel.none {
    background: transparent !important;
    color: #808080 !important;
}
// For Flags
body.dark .FlagPostModal .checkbox strong {
color: #ffffff;
}

Feature Request

Is your feature request related to a problem? Please describe.

If colored header is enabled in appearance tab of Admin, the colored header is retain even in dark mode for all users.

Describe the solution you'd like

If the admistrator enables colored headers in Admin, the colored headers should be darkened when someone visits the forum frontend and enables dark mode.

Describe alternatives you've considered

Nil

Description

Just installed this plugin and love it - nice work.
I am using a "Colored header" and noticed that switching the theme also changes the text color on colored surfaces (like the colored header, the tags & the colored buttons). Wouldn't it make sense to keep the that color to white to ensure readability?
I've already skimmed through the last years comments on this thread but didn't see this question brought up yet.

Steps to Reproduce

1. Enable Night mode in admin settings
2. Enable "Colored header" and set color to "#5572F7"
3. Go back to main page
   

Expected Behavior:
Texts on colored backgrounds continue to use a bright color.
Other web apps (Twitter, GitHub) also mostly use bright colors on their colored buttons

Actual Behavior:
Texts on colored background switched to dark text/icon color

Flarum/Server/Client Information

Technical Details

• Version of Flarum (0.1.0-beta.15):
• Version of extension (0.7.1):
• The webserver you are running (Apache):
• PHP version (7.4.15):
• Hosted environment (Shared):
• Hosting provider (https://uberspace.de/):

Flarum Info

Flarum core 0.1.0-beta.15
PHP version: 7.4.15
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, readline, Reflection, SPL, session, standard, restrictdocroot, bcmath, bz2, calendar, ctype, curl, dba, dom, mbstring, fileinfo, ftp, gd, gettext, gmp, iconv, imap, intl, json, ldap, exif, mysqlnd, PDO, pgsql, Phar, posix, shmop, SimpleXML, soap, sockets, sodium, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlwriter, xsl, mcrypt, mysqli, pdo_mysql, pdo_pgsql, pdo_sqlite, xmlreader, xmlrpc, apcu, decimal, gnupg, igbinary, imagick, msgpack, psr, yaml, zip, mongodb, phalcon, redis, Zend OPcache
+----------------------+------------------+--------+
| Flarum Extensions    |                  |        |
+----------------------+------------------+--------+
| ID                   | Version          | Commit |
+----------------------+------------------+--------+
| flarum-approval      | v0.1.0-beta.15   |        |
| flarum-bbcode        | v0.1.0-beta.15   |        |
| flarum-emoji         | v0.1.0-beta.15   |        |
| flarum-lang-english  | v0.1.0-beta.15   |        |
| flarum-flags         | v0.1.0-beta.15   |        |
| flarum-lock          | v0.1.0-beta.15   |        |
| flarum-markdown      | v0.1.0-beta.15   |        |
| flarum-mentions      | v0.1.0-beta.15   |        |
| flarum-statistics    | v0.1.0-beta.15   |        |
| flarum-sticky        | v0.1.0-beta.15.1 |        |
| flarum-subscriptions | v0.1.0-beta.15   |        |
| flarum-suspend       | v0.1.0-beta.15   |        |
| flarum-tags          | v0.1.0-beta.15   |        |
| fof-polls            | 0.3.2            |        |
| fof-user-directory   | 0.5.0            |        |
| fof-oauth            | 0.2.1            |        |
| flarum-likes         | v0.1.0-beta.15   |        |
| flarum-nicknames     | v0.1.0-beta.15   |        |
| fof-nightmode        | 0.7.1            |        |
+----------------------+------------------+--------+
Base URL: https://workinghours.timopartl.com
Debug mode: off

#58 (comment) pointed out that wrong color-scheme can cause the incorrect appearance of scrollbar, and then the problem solved.
But I think it's not a perfect solution......When the option is Automatic (based on browser or device options) and the device is in dark mode, the same problem appears.
The better solution I think is set color-scheme to light dark when the Automatic (based on browser or device options) option is active.

Bug Report

Current Behavior
When FoF Night Mode is enabled, it causes issues to CSS from Flarum Wordpress Integration embeds comments iframe. Custom CSS from that extension doesn't work anymore.

When FoF Night Mode is disabled, CSS from Flarum Wordpress Integration works as expected

Expected Behavior
Custom CSS from Flarum Wordpress Integration shouldn't cause issues with embedded iframes.

Screenshots
With FoF Night mode disabled (and custom CSS from extension applied)
https://imgur.com/l6veiGU

With FoF Night mode enabled:
https://imgur.com/vmbWIoE

Environment

• Flarum version: 1.6
• Extension version: 1.5.1
• Website URL: doesn't apply, FoF Night Mode is disabled in the production because of this server
• Webserver: [e.g. apache, nginx]
• Hosting environment: VPS
• PHP version: 7.4.30
• Browser: All browsers

Flarum core 1.6.2
PHP version: 7.4.30
MySQL version: 5.5.5-10.4.20-MariaDB-1:10.4.20+maria~buster-log
Loaded extensions: Core, date, libxml, openssl, pcre, zlib, filter, hash, pcntl, Reflection, SPL, session, standard, sodium, mysqlnd, PDO, xml, apcu, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, mbstring, FFI, fileinfo, ftp, gd, gettext, gmp, iconv, igbinary, imagick, imap, intl, json, exif, mongodb, msgpack, mysqli, odbc, pdo_dblib, PDO_Firebird, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, apc, posix, readline, redis, shmop, SimpleXML, soap, sockets, sqlite3, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xmlreader, xmlrpc, xmlwriter, xsl, zip, Phar, memcached, ionCube Loader, Zend OPcache
+-------------------------------+---------+--------+
| Flarum Extensions             |         |        |
+-------------------------------+---------+--------+
| ID                            | Version | Commit |
+-------------------------------+---------+--------+
| flarum-flags                  | v1.6.1  |        |
| flarum-approval               | v1.6.1  |        |
| flarum-tags                   | v1.6.1  |        |
| flarum-suspend                | v1.6.1  |        |
| askvortsov-auto-moderator     | v0.1.2  |        |
| flarum-markdown               | v1.6.1  |        |
| flarum-lock                   | v1.6.1  |        |
| flarum-subscriptions          | v1.6.1  |        |
| fof-byobu                     | 1.1.7   |        |
| flarum-likes                  | v1.6.1  |        |
| zerosonesfun-member           | 1.2     |        |
| zerosonesfun-direct-links     | 3.1     |        |
| v17development-user-badges    | v1.1.0  |        |
| v17development-seo            | v1.8.0  |        |
| therealsujitk-gifs            | v4.1.1  |        |
| the-turk-flamoji              | 1.0.4   |        |
| sycho-profile-cover           | v1.3.3  |        |
| sycho-move-posts              | v0.1.7  |        |
| nearata-remove-pane           | v2.0.1  |        |
| nearata-cakeday               | v2.1.0  |        |
| matteocontrini-imgur-upload   | v3.9.1  |        |
| kilowhat-wordpress            | 1.7.5   |        |
| ianm-syndication              | 1.2.2   |        |
| fof-webhooks                  | 1.1.1   |        |
| fof-user-bio                  | 1.1.1   |        |
| fof-socialprofile             | 1.1.4   |        |
| fof-sitemap                   | 1.0.3   |        |
| fof-reactions                 | 1.1.3   |        |
| fof-profile-image-crop        | 1.1.0   |        |
| fof-pretty-mail               | 1.1.1   |        |
| fof-polls                     | 1.3.0   |        |
| fof-merge-discussions         | 1.3.1   |        |
| fof-links                     | 1.1.2   |        |
| fof-linguist                  | 1.0.4   |        |
| fof-ignore-users              | 1.1.0   |        |
| fof-gamification              | 1.6.2   |        |
| fof-formatting                | 1.0.2   |        |
| fof-follow-tags               | 1.1.7   |        |
| fof-drafts                    | 1.2.0   |        |
| fof-bbcode-details            | 1.1.0   |        |
| flarum-sticky                 | v1.6.1  |        |
| flarum-statistics             | v1.6.1  |        |
| flarum-pusher                 | v1.6.1  |        |
| flarum-mentions               | v1.6.1  |        |
| flarum-lang-english           | v1.6.0  |        |
| flarum-emoji                  | v1.6.1  |        |
| flarum-bbcode                 | v1.6.0  |        |
| ecnu-im-sticky-sidenav        | v1.1.0  |        |
| davwheat-inline-group-badges  | 1.0.0   |        |
| datlechin-silent-edit         | v0.1.0  |        |
| datitisev-post-galleries      | 1.0.0   |        |
| darkle-fancybox               | 1.1.2   |        |
| clarkwinkelmann-author-change | 1.0.3   |        |
| askvortsov-rich-text          | v2.1.7  |        |
| askvortsov-pwa                | v3.1.3  |        |
| askvortsov-moderator-warnings | v0.6.1  |        |
| antoinefr-money               | v1.2.0  |        |
| acpl-mobile-tab               | 1.1.1   |        |
+-------------------------------+---------+--------+

Installation path: /home/568307.cloudwaysapps.com/wnpfpfdkcz/public_html/flarum
Queue driver: sync
Session driver: file
Mail driver: smtp
Debug mode: off

Additional Context
Previously, on FoF Night Mode 1.2.2 with Flarum 1.3 everything worked great.

• Transfer ownership to FriendsOfFlarum.
• Change all ReFlar references inside repo (code and other files).
• Fix #15.
• Fix #20.
• Fix #16
• Remove background color from side-nav items (should have no hover or active background).