friendsofagape / usfm-editor Goto Github PK

In importing usfm-editor into a react app, there is a node path error. Am I missing something?

Imported is as follows in react project at 'C:/projects/react-app/':

function Editor() {
  const usfmString = `\\c 1
  \\v 1 This is the first verse.`;
  const setUsfmString = (editedUsfm) => {console.log(editedUsfm)};
  return (
    <UsfmEditor usfmString={usfmString} onChange={setUsfmString}></UsfmEditor>
  );
}

export default Editor;

Initial part of error message:

point
C:/projects/src/interfaces/editor.ts:903
  900 | const node = Node.get(editor, path)
  901 | 
  902 | if (!Text.isText(node)) {
> 903 |   throw new Error(
      | ^  904 |     `Cannot get the ${edge} point in the node at path [${at}] because it has no ${edge} text node.`
  905 |   )
  906 | }

build tool

Next.js

Usfm Editor version

0.8.0

Reproduction repository

https://github.com/friendsofagape/autographa/blob/notification/renderer/src/components/EditorPage/UsfmEditor/UsfmEditor.js#L263

Issue Description

Some time while I navigate through books and get the output of usfm. The output usfm string has an id of the previous book and hence ends up in the wrong usfm output file for that particular book.
Surprisingly the book fetch on navigation works fine without any errors

build tool

Next.js

Node.js version

14.8.0

Usfm Editor version

0.8.0-SNAPSHOT.5

Reproduction repository

https://github.com/Ashersam/editor-demo/blob/master/src/App.js#L25

Issue Description

We have updated our package to the latest from 0.8.0-SNAPSHOT.2 since we have use cases of single or multiple chapters render based on screen space and toolbar separation.
I have started implementing ChapterSelect based render and wrapped it up with the withToolBar.js component.

Things are working except whenever I update the state on the following callbacks (onChange, onIdentificationChange, onVerseChange) whatever changes I do just rerenders multiple times and comes to the original loaded state, sometimes it ends in an infinite loop. And most of these things works as expected in 0.8.0-SNAPSHOT.2.

build tool

Next.js

Usfm Editor version

0.8.0-SNAPSHOT.6

Reproduction repository

https://github.com/Ashersam/UsfmEditorNextJs/blob/main/pages/index.js

Test site

https://ashersam.github.io/UsfmEditorNextJs/

Issue Description

I see there's a joint verse feature for usfm-editor editor and works well in create-react boilerplate. But that's not happening in nextJs based application. Just getting the following prop warning on the console when we click on a verse number.

react_devtools_backend.js:2560 Warning: Failed prop type: The prop `icon` is marked as required in `JoinWithPreviousVerseButton`, but its value is `undefined`.
    at JoinWithPreviousVerseButton (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1624422465897:8531:26)
    at VerseJoinUnjoinSubmenu (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1624422465897:7757:5)
    at ul
react_devtools_backend.js:2560 Warning: Failed prop type: The prop `text` is marked as required in `JoinWithPreviousVerseButton`, but its value is `undefined`.
    at JoinWithPreviousVerseButton (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1624422465897:8531:26)
    at VerseJoinUnjoinSubmenu (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1624422465897:7757:5)
    at ul