friends-of-forkcms / fork-cms-module-compression Goto Github PK

You use 'Index' as default action, but you only have a 'Settings' action.

https://tinypng.com/developers/reference/php#installation

I was installing some themes from here and i got this message on the last 2:

Oops! An Error Occurred
The server returned a "500 Internal Server Error".
Something is broken. Please let us know what you were doing when this error occurred. We will fix it as soon as possible. Sorry for any inconvenience caused.

I didn't see a mechanism to avoid compressing images multiple times. If you have a really big amount of images, this could cause performance problems. I would only compress the image if it isn't available in the compress_history table.

In the newest Fork version (5.8.0) the compression action keeps running, in the console you can see the "File read" is counting but none of the images are being compressed.
A time out is the result.

Already did some debugging and found 1 fix that helped a little bit but after compressing a few images the process again keeps running.

/Engine/TinyPNGApi.php - Line 108
if (substr($header, 0, 10) === 'Location: ') {

By dumping the $header it seems the "Location: ' is lower case 'location: '

Great work, it looks like a great module. I'll add some (minor) issues though.

You use the Fork licence part, stating that your files are part of Fork CMS. That's not true and should not be included in your module. (I know that this is done wrong in a lot of modules, but thats no reason to do it wrong in yours 😉 )

/*
 * This file is part of Fork CMS.
 *
 * For the full copyright and license information, please view the license
 * file that was distributed with this source code.
 */

I just noticed that when you select a child folder, the images in the parent folders don't get compressed. As you see here:

The parent folder contains 114 images and a "thumbnails" folder, but the module only compresses the thumbnail folder because it is selected.

I could use some input what would be the best way to handle this. Compress all images that are in one of the parent folders in the path (but not in a different subfolder)?