freyj / fluffy-hero-maker Goto Github PK

Classes and Background get doubled in database (not race)

Describe the bug
On a random character gen, this happened :

Stats:
Strength: 14
Dexterity: 14
Constitution: 14
Intelligence: 18
Wisdom: 9
Charisma: 13

Saving Throws:
Strength: 2
Dexterity: 2
Constitution: 1
Intelligence: 5
Wisdom: 1
Charisma: 1

Constitution should be 2 and wisdom -1 (maybe the minus just isn't showing up on the display for the wisdom, but constitution is definitely wrong)

Stop reinventing the wheel 😁

Related to #1

Because True is better than "yes".

• changing the spell template
• changing the database input
• changing the way to display
• changing all the jsons with spells

When giving a race details after first choice, the weapon proficiency array is displayed when it should not

The description is written as one long line, it would be nicer if it was broken down with newlines.

Just like #51 , but for monsters

Your attributes are:
Strength: 6
Dexterity: 6
Constitution: 2
Intelligence: 8
Wisdom: 2
Charisma: 8
Something went wrong in the 3d6 roll.

It should not be possible to pick it when choosing a bonus language

Both when choosing the class
Appears as a {"name":"","description":""} string
and when displaying the recap about the character does not appear at all

As of now, hit points are not calculated for the resulting character, even if the hit dice of the class and the constitution modifier are.

When picking a class, somehow choices for skills are not displayed or choosable

Spells are not all accessible to all classes

• adding the information to the json files (and the spell_template.json)
• adding the field in the spell table
• adding the information in the display
• querying the database for spells from a certain class
• querying the database for spells from a certain class and a certain level

Describe the bug
As Cleric you only have :
Resistance, Light, Mending
When you should have more than this (https://open5e.com/spells/by-class/cleric lists 7 spells as cleric cantrips)

To Reproduce
Choose the Cleric Class
Expected behavior
The 7 cantrips should be available for choice

This just requires the update of the json

Should be a function of the DnD5Character class and not in the creator
And should be split in smaller functions.

For flaws, bonds, ideals, and personalities, if one picks the last option in the table, it won't display the string, but the number picked.

Having tests would help improve the overall quality of the generator, and would allow to have less regression bugs.

When asking for all the spells of level 9 in the database, they seem to be duplicated 10 times.

Mostly to improve readability it would be nice to have all functions commented and maybe also the classes.

For example the Fighter has a Fighting Style to choose at level 1, and it is currently in the json data, stored in the database (probably not ideally) but not yet taken into account in the character creation

When displaying the Acolyte background a random 1: appears, apparently because there are no feature choices in this backround (some have them)

I'm pretty sure there are mistakes in the jsons, whether of grammatical errors or bad copy/paste.
Need to re check every one of them

• srd_races
• srd_classes
• srd_backgrounds
• srd_aberration
• srd_celestial
• srd_cantrips
• srd_lvl_1
• srd_lvl_9

(will add the other jsons when they are added to the code base)

• modify monster class to add information
• add information in json template
• add database input
• update all existing monsters with the proper data

To allow for less ugliness

As the FLASK_APP variable is not set to app/main_flask.py, it doesn't run properly.
(also need to check the initialization of the database if the flask app is run without running the cli_main before)

The spell slot information has not been added to the Wizard class (or the class template)

noting down an issue for something I've already started

For spells like Alter self (https://open5e.com/spells/alter-self), there are different options, and it would be easier to display and use if this was reflected in the object (for now, it's all one line in the description)

Currently not all data are saved when the user accepts to save at the end of the creation

• Keep a structure of srd_lvl_[number].json for files

• Cantrips

• Lvl 1 spells

• Lvl 2 spells

• Lvl 3 spells

• Lvl 4 spells

• Lvl 5 spells

• Lvl 6 spells

• Lvl 7 spells

• Lvl 8 spells

• Lvl 9 spells

Describe the bug
When using the spell finder, if one picks a class/level combination that has no spell, there is no message to tell the user that there is no spell

Expected behavior
It should say something like "No spell available for [class] [level].

This will affect the Ranger class and Warlock class

Add the possibility to create a Pathfinder (1e) character (checkout rules about SRD/OGL)

Adding the possiblity to display items for dnd5

Some races and backgrounds give languages, and that should be reflected in the language choices whenever they happen.

• Barbarian
• Bard
• Cleric
• Druid
• Fighter
• Monk
• Paladin
• Ranger
• Rogue
• Sorcerer
• Warlock
• Wizard

Just before the "Do you confirm this choice?" in race choice when picking Rock Gnome (no information after racial traits)
Does not do it for a Hill Dwarf (Weapon Proficiency displayed after racial traits, no extra newline

Generation type: Rolling stats until the total bonuses is not higher than 7 and not lower than 3

If currently chosen, it will crash the program.

  File "/fluffy-hero-maker/cli_main.py", line 24, in <module>
    dnd_character_creation()
  File "/fluffy-hero-maker/dnd_character_creator.py", line 98, in dnd_character_creation
    dnd_character = Dnd5Character(character_name.strip(), int(generation), stats=attributes)
  File "/fluffy-hero-maker/characters/dnd5.py", line 29, in __init__
    "Strength": self.get_modifier("Strength"),
  File "/fluffy-hero-maker/characters/dnd5.py", line 214, in get_modifier
    return floor((self.attributes[attribute] - 10) / 2)
KeyError: 'Strength'```

Draconic Ancestry
You have draconic ancestry. Choose one type of dragon from the Draconic Ancestry table. Your breath weapon and damage resistance are determined by the dragon type; as shown in the table.
Breath Weapon; Damage Resistance
[, ', B, l, a, c, k, '
Breath Weapon
You can use your action to exhale destructive energy. Your draconic ancestry determines the size; shape; and damage type of the exhalation. When you use your breath weapon; each creature in the area of the exhalation must make a saving throw; the type of which is determined by your draconic ancestry. The DC for this saving throw equals 8 + your Constitution modifier + your proficiency bonus. A creature takes 2d6 damage on a failed save; and half as much damage on a successful
Draconic Ancestry
', B, l, u, e, '
Damage Resistance
You have resistance to the damage type associated with your draconic ancestry.
Draconic Ancestry
', B, r, a, s, s, '
Race: Dragonborn

This needs fixing.

Describe the bug
Imports of monsters fail on adding the actions and traits from the json files (they are dict)

To Reproduce
Steps to reproduce the behavior:

1. Select the monster displayer
2. Should break on population of the database

Expected behavior
Import should go well

Screenshots

    monsters = get_all_monsters_from_json()
  File "/home/freyja/dev/Fluffy-Hero-Maker/databases/dnd5_monster_db.py", line 98, in get_all_monsters_from_json
    ", ".join(monster["actions"]),
TypeError: sequence item 0: expected str instance, dict found

Environment (please complete the following information):

• Ubuntu 19.04

Adding them by using srd_[monster_type].json file names

• Aberration
• Beast
• Celestial
• Construct
• Dragon
• Elemental
• Fey
• Fiend
• Giant
• Humanoid
• Monstrosity
• Ooze
• Plant
• Undead

For now, on many inputs, if the user enters anything but an integer, the whole program will crash.