freifunkbremen / nodewatcher Goto Github PK

In a string like "http://website-of-owner.com by [email protected]", we wouldn't currently recognize the address. Also, the IRC notifier would understand ",isnick" at the end of the URI to signal that the recipient is a user and not a channel, but this will never reach him because it is stripped away.

We could simply leave the string as it is (making #2 obsolete) and match without ^ and $ everywhere. However, to still catch mail addresses without mailto: but also not try to send mails to XMPP addresses, we would have to introduce priorities on the notifier plugins.

Please add some example how to enable logging to a file in the example config

Twitter imposes a limit of 250 direct messages per day, and we wouldn't want to hit that offhand. Other kinds of messages might need limitation as well.

The config could contain a list of contacts that get notified on every down node.

It should be configurable which plugins to load/use.

Most notifier plugins won't work if they are not configured properly. Instead of failing with an exception because of missing config variables, they could then be disabled in the config and wouldn't even be executed.

Currently, multiple contact possibilities are stored as comma-separated string in the database. The cleaner solution would obviously be to have a separate table contacts and a joining table node_contacts. That could give the source plugins the responsibility to split their format into multiple contacts.

IRC is a common media of communication in the Freifunk community, thus notification via IRC is reasonable.

Channels as well as individuals should be notified via PRIVMSG. FTR, the (most common) URI for individuals is irc://irc.example.org/Nickname,isnick, for channels irc://irc.example.org/channel (Source)

Currently, the PluginManager instantiates each plugin when loading it. This is sub-optimal. For example, the XMPPNotifier doesn't need to connect to the XMPP server (and tear it down eventually) if nobody is notified via XMPP.