Frogger Jump location preview [bounty: 4 XTR] about ancientbeast HOT 8 CLOSED

@DreadKnight Ok sounds good, I'm going to submit a PR for this one for now.

from ancientbeast.

I'm glad to do this one

from ancientbeast.

from ancientbeast.

@DreadKnight this one seems good to go, but just a quick question. At the bottom of the hexgrid code I found a function called fadeOutTempCreature that has a comment above it mentioning factoring it out but it seems to do exactly what we need when using the previewCreature function so I used it for this ability. Does this seem ok?

from ancientbeast.

fadeOutTempCreature

@gg447062 Took a peek at it. Well, ideally it would be to do things as indicated in the comment there it seems 🐻
You could use that and I could open new issue regarding the TODO refactoring 🤔 hopefully it won't create chaos.

from ancientbeast.

Ok from what I can tell, that function is only used twice so I don't think it should cause too much chaos to refactor it. I think the thing that confused me about the comment was that it mentions the existing temp creature created by /src/abilities/Dark-Priest.js but unless I'm totally off the temp creature is this.materialize_overlay, which is also not an instance of Creature.creatureSprite.

from ancientbeast.

Ok from what I can tell, that function is only used twice so I don't think it should cause too much chaos to refactor it. I think the thing that confused me about the comment was that it mentions the existing temp creature created by /src/abilities/Dark-Priest.js but unless I'm totally off the temp creature is this.materialize_overlay, which is also not an instance of Creature.creatureSprite.

@gg447062 Comment could be wrong, I'm not sure. Feel free to poke at it and make a PR 🐻

from ancientbeast.

Fixed in ##2580

from ancientbeast.