Giter Club home page Giter Club logo

Comments (4)

allmtz avatar allmtz commented on June 11, 2024 1

The origin lines for Earth Shaker and Infernal Prayer are slightly different:

// Earth Shaker
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[0, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

// Infernal Prayer
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[1, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

I tried using the Earth Shaker matrix for Infernal Prayer but this results in not being able to attack targets in the hex directly in front and behind of the Infernal. Pretty sure this is because an Infernal is 3 hexes wide vs Stomper being 2 hexes wide.

stomper-matrix

Both matrices are needed but they could be made more generic with names like largeCreatureFrontAndBack9Hex and mediumCreatureFrontAndBack8Hex. Or more specifically size2CreatureFrontAndBack8Hex and size3CreatureFrontAndBack9Hex. Not very pretty but it avoids confusion in the future if a creature larger than 3 hexes is introduced. @DreadKnight thoughts?

from ancientbeast.

DreadKnight avatar DreadKnight commented on June 11, 2024 1

The origin lines for Earth Shaker and Infernal Prayer are slightly different:

// Earth Shaker
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[0, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

// Infernal Prayer
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[1, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

I tried using the Earth Shaker matrix for Infernal Prayer but this results in not being able to attack targets in the hex directly in front and behind of the Infernal. Pretty sure this is because an Infernal is 3 hexes wide vs Stomper being 2 hexes wide.
stomper-matrix

Both matrices are needed but they could be made more generic with names like largeCreatureFrontAndBack9Hex and mediumCreatureFrontAndBack8Hex. Or more specifically size2CreatureFrontAndBack8Hex and size3CreatureFrontAndBack9Hex. Not very pretty but it avoids confusion in the future if a creature larger than 3 hexes is introduced. @DreadKnight thoughts?

Thought there was an issue regarding reusing that, thanks for looking into it and confirming @allmtz
I think the issue is not actually because of the different size of units, but that Intense Prayer affects a bigger area for several reasons:

  • animation wise, Infernal will be hitting frontal-underneath hexagon
  • upgraded Intense Prayer will be complementing the passive nicely if keeping position, leaving traps under all Infernal's hexagons
  • this would be an area attack, I didn't want the direct hit to be a hexagon that can be occupied by a foe in order to avoid some confusion when dealing with blocks/wards/shields type of mechanics and to reinforce the animation.

At some point I recall I've even considered Intense Prayer's upgrade being rather OP and wanted to revamp it, but some fans opposed to the idea, saying they really like it like this xD

I could drop the "reuse" part between those two and just consider a more useful rename then; will tweak OP.

from ancientbeast.

DreadKnight avatar DreadKnight commented on June 11, 2024 1

from ancientbeast.

allmtz avatar allmtz commented on June 11, 2024

I think the issue is not actually because of the different size of units, but that Intense Prayer affects a bigger area for several reasons:

  • animation wise, Infernal will be hitting frontal-underneath hexagon

Dropping the size from the name, what do you think of frontAndBack8Hex and frontAndBack9Hex?

from ancientbeast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.