Reproduced in the cypress core tests, specifically when comparing the pattern

The FAQ link in the footer points to /docs/faq but should point to /faq instead.

Just update this line: https://github.com/freesewing/freesewing/blob/develop/packages/components/src/Footer/index.js#L21

The back pleat seems to be too long. It extends past the pocket line to the seat circumference narrowing the circumference at the pocket line.

Also, as drafted, the pattern has too much ease at the crotch and not enough at the seat. From what I can see the pattern doesn't use seat circumference in its calculations. Is that right?

Carton and Carlita are missing instructions. Specifically:

• Cutting instructions
• Fabric guidelines
• Requirements

We often have a need to sort things based on their translation (measurements, options and so on).
It would be good to add a method to the utils package that handles that.

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet.
We recommend using:

• CircleCI
• Travis CI
• Buildkite
• CodeShip
• Azure Pipelines
• TeamCity
• Buddy
• AppVeyor
  But Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating cross-env in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

The hem option does what it does, but also seems to influence the length of the split. Which is an unwanted side-effect.

Since we've renamed our rooms, we need to update the links to them

Simon writes:

Collar in image is actually right way up as top is wider than bottom. In previous section it is this same orientation and topstitching is at top. I assembled this with collar and undercollar piece rotated 180° and I got a correctly assembled collar. Also if I was to be really pedantic in this diagram the stand has yet to be turned out so stand should be shown as interfacing as both undercollar piece were previously interfaced. I think this is one of those things where an experienced sewer might not notice the problem as they automatically know the right way to assemble a collar.

And he is correct. The collar should be drawn upside down but it's not in this particular image:

Note that this needs to be fixed in both this repo, and backported to the current website.
Also, I'm not even sure we have the original SVGs for this.

• Estimate (app.estimate)
• Actual (app.actual)

eg:

https://freesewing.org/blog/freesewing-v2-1

in the case of Waralee — unisex clothing

https://freesewing.org/patterns/waralee

Department | Menswear

Could require joins for searches by sex, but could get around that by just having a 3rd sex.

If you see a cannot scale this curve. Try reducing it first. you've hit this issue.
Strictly speaking, this is not an issue in freesewing/core, but in the upstream bezierjs library. Specifically, Pomax/bezierjs#102 It happens when a Bezier curve becomes so straight it almost becomes a line. At which point the offset algorithm goes off the rails.

The issue has been open since October 2018, and tagged with 'help-wanted', so it is unlikely to get fixed by the upstream author (pomax). A fix is going to be non-trivial. Not only because it's not our code, but because offsetting Bezier curves is just not easy.

We hit this problem far too often to ignore it. So we should try to address it. Especially since this library does make our life significantly either, and if we tried to implement all the Bezier-juggling ourselves, we would very likely end up with our own set of bugs. So we can't simply swap it out for a drop-in replacement.

It seems like what we need here, is a hero.

See discussion here: https://gitter.im/freesewing/development?at=5d66f5cd3770ed0cbda630e3

The width of the Carlton coat tail is incorrect. (hat-tip to @SennettTailor for reporting this).

Although the initial complaint was that it was too wide, turns out it's too narrow.
This is carlton in v2.0.3:

The key thing here is to understand how the back is pleated, which I've tried to clarify in this image (that already has the fix that will come out in v2.0.4)

Starting from the left, we go towards the side, fold back on the first fold, then go back until we reach center back again, and fold back on the second fold. This means both folds have cancelled each other out.
The same happens on the right side, so the real width of the tail is the width of the part, with 4 times the distance between 2 fold lines subtracted. In other words, the sum of the values that have been encircled

Note that that last fold line on the right is not actually a fold, it's merely there to indicate where the folded fabric lies on top of the layer underneath.

I don't know if there is a better way to handle this. But this worked for my testing.

Add 'example\public\favicon.ico' to the template blacklist in the create freesewing pattern package.

REASON:
In the package, Create-freesewing-pattern. The create-library.js library uses a blacklist set to ignore the faveicon.ico file.

This works on OSX and Linux but on Windows it returns an error

"Error: Lexical error on line 1. Unrecognized text"

This appears to be because the command - path.relative(source, file) returns Windows style path strings.

In Linux and OSX paths are separated by '/' but in Windows it's separated by ''. So when checking if the fileRelativePath is in the templateBlacklist it'll always return false. Adding the Windows variant to the set takes care of this.

In Theo pattern, I noticed that it require seat circumference measurement however in both documentation tab and in the model page itself doesn't seem to list a way to input seat circumference.
Given that it's basically impossible to uses the pattern since it keeps saying necessary measurements is missing

Needs the same fix as freesewing/freesewing.org@f78278f

Reproduces in the cypress core tests, specifically when comparing.

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating webpack in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

There's no instructions on using remark-jargon without gatsby, that should be fixed.

These is (part of) the resolved dependencies in Carlton:

collar: (11) […]
​​​0: "collarStand"
​​​​1: "bentFront"
​​2: "bentBack"
​​​​3: "bentBase"
​​​​4: "bentBack"
​​​​5: "bentBase"
​​​​6: "bentBack"
​​​​7: "bentBase"
​​​​8: "bentBase"
​​​​9: "bentBase"
​​​10: "bentBase"
​​length: 11
​<prototype>: Array []

Obviously, this is not right.

1. Sign up with new email and password
2. Click confirmation in email

Expected

To be able to login on website

Actual

Gives an error:

Authentication failed

Notes:

https://beta.freesewing.org/confirm/signup/5d2e5cc89b4ac16f227ba9dc

This was initially reported as https://github.com/freesewing/plugin-validate/issues/1

The reason this only happens with the validate plugin is because that's the only plugin to use the preDraft of postDraft hooks. Adding these hooks to any other plugin (I've tested with plugin-theme) causes the same issue.

It's a bit murky as to why exactly this is happening. I've swapped out the hooks NPM module in favor of hooks-fixed but the behaviour dind't change.

I did some more digging, and it seems to me that the problem is due to the preDraft and postDraft hooks being added to (an instantiated version of) the pattern object, whereas all other hooks are attached to object prototypes.

A quick test/workaround confirms this. If I move the draft() object to the pattern prototype, and instead have it call an _draft() method that I define in the pattern, the issue is sidestepped.

It feels hackish though, and while changing patterns to define a _draft method instead of a draft method is no big change, it is non-intuitive for developers. So if there's any chance to avoid it, I'd prefer that.

There's also the graplling-hook NPM package which does a similar thing, but is newer and might be worth looking in to. Then again, perhaps the nature of the issue means that we'll end up with the same prototype vs object situation.

edit: wrote method when I meant package

Below is a list of illustrations that are missing. Note that some illustrations are (currently) not available on the website, but we do have them (they just haven't been published yet). The ones below are ones that still need to be drawn:

Missing illustrations

These are illustrations that have never been made. These should be priority.

• Bent
  • Sleeve bend
  • Sleevecap ease
  • Sleeve length bonus
• Brian
  • Sleevecap ease
  • Sleevewidth guarantee (not sure whether this needs an illustration, or how to illustrate it)
• Carlita (many of these could also be used by Carlton)
  • Back neck cutout
  • Belt width
  • Horizontal button spacing
  • Chest pocket angle
  • Chest pocket height
  • Chest pocket placement
  • Chest pocket width
  • Collar flare
  • Collar height
  • Collar spread
  • Cuff length
  • Front armhole extra cutout
  • Front overlap
  • Inner pocket depth
  • Inner pocket placement
  • Inner pocket welt height
  • Inner pocket width
  • Lapel reduction
  • Length
  • Pocket flap radius
  • Pocket height
  • Horizontal pocket placement
  • Vertical pocket placement
  • Pocket radius
  • Pocket width
  • Shoulder slope reduction
  • Sleevecap height
• Florent
  • Head ease
• Hugo
  • Ribbing stretch
• Huey
  • Hips ease
  • Hood angle
  • Hood closure
  • Hood cutback
  • Hood depth
  • Hood height
  • Pocket height
  • Pocket width
  • Ribbing
  • Waist ease
• Jaeger
  • Button length
  • Number of buttons
  • Chest pocket depth
  • Collar roll
  • Collar spread
  • Front cutaway end
  • Front overlap
  • Hem radius
  • Inner pocket depth
  • Inner pocket placement
  • Inner pocket welt height
  • Inner pocket width
  • Lapel reduction
  • Pocket fold-over
  • Sleevecap height
  • Sleeve vent length
  • Sleeve vent width
• Shin
  • Back rise
  • Bulge
  • Leg reduction
  • Length bonus
  • Rise
  • Stretch
• Tamiko
  • Armhole depth factor
  • Chest ease
  • Flare
  • Shoulderseam length
  • Shoulder slope
• Theo
  • Leg width
  • Wedge
• Wahid
  • Length bonus
  • Pocket angle
  • Pocket width
  • Pocket location
  • Welt height

Incorrect illustrations

These are illustrations that are shared between patterns, which means they are not strictly correct, but often are helpful nevertheless.
While it would be good to an illustration per option per pattern, these are somewhat less urgent as at least there's something.

• Bent: All options except the ones listed above re-use illustrations from Brian
• Hugo: All options except ribbing height (done) and ribbing stretch (missing)
• Huey: Options inherited from Brian
• Jaeger:
  • Back neck cutout
  • Front armhole extra cutout
  • Biceps ease
  • Collar ease
  • Shoulder ease

This can be reproduced by running the cypress core tests. It happens when comparing the pattern.

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating execa in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Some patterns (like theo) don't have all their options translated, making them appear as their translation lookup key.

Initially reported in https://github.com/freesewing/freesewing.org/issues/67

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating webpack in /yarn.lock:
Couldn't find any versions for "@freesewing/core" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

1. Sign up with either github or google

Expected Behavior

It to sign me up

Actual Behavior

It gives an error:

https://backend.beta.freesewing.org/callback/from/google?state=5d2e72879b4ac16f227ba9dd&code=4/iQGXKkUQu4aL-dPUZzyz4lu6XL9_tVplHLT2sKCHZNstlBbQCtlacCoaf4LCzBMDTA6mDpbpj9P3FROaWLj7I-I&scope=email%20profile%20https://www.googleapis.com/auth/userinfo.profile%20https://www.googleapis.com/auth/userinfo.email&authuser=0&hd=occsn.com&session_state=b011a3aa2f8a8d8bf5e3f846f179a1cf34e0a71b..c8f4&prompt=none

Internal Server Error

Subject says it all

Hello,

I tried to make a pattern of bruce, but it seem that the hem allowance is not anymore here on
side and inset, while it's still here on back.

My recipe :

{
  "handle": "lpoct",
  "name": "1st try latex",
  "notes": "",
  "recipe": {
    "settings": {
      "sa": 4.9,
      "complete": true,
      "paperless": false,
      "locale": "en",
      "options": {
        "stretch": 0.09,
        "legBonus": 0.09
      },
      "units": "metric",
      "measurements": {
        "hipsCircumference": 800,
        "upperLegCircumference": 490,
        "hipsToUpperLeg": 190
      }
    },
    "pattern": "bruce",
    "model": "idcke"
  },
  "created": "2019-09-06T23:17:57.529Z"
}

the result :
pattern-a4(4).pdf

It also seem that the side part is upside down, ( the fitting was better with the largest part on the leg and the short on the hip.)

Thank for your pattern !

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating cross-env in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Reproduced in cypress core tests, specifically when comparing the pattern.

This is to avoid issues with translation

This happens when running the cypress core tests, specifically when comparing.

We have a (new) LineDrawing React component which is supposed to show a linedrawing of a given pattern. Essentially, like an icon: a basic outline to give you an idea of what the pattern looks like.

The only problem is: The component doesn't (yet) have linedrawings in it, and returns the outline of the GitHub icon (because we had to return something) :

What we need to do is:

• Draw linedrawing for Aaron
• Draw linedrawing for Benjamin
• Draw linedrawing for Bent
• Draw linedrawing for Brian
• Draw linedrawing for Bruce
• Draw linedrawing for Carlita
• Draw linedrawing for Carlton
• Draw linedrawing for Cathrin
• Draw linedrawing for Florent
• Draw linedrawing for Huey
• Draw linedrawing for Hugo
• Draw linedrawing for Jaeger
• Draw linedrawing for Sandy
• Draw linedrawing for Shin
• Draw linedrawing for Simon
• Draw linedrawing for Sven
• Draw linedrawing for Tamiko
• Draw linedrawing for Theo
• Draw linedrawing for Trayvon
• Draw linedrawing for Wahid
• Integrate these linedrawings into LineDrawing component

What's a linedrawing?

A linedrawing (line drawing?) is a simplified/technical view of the sewing pattern. Example:

As shown here:

Thanks to @GitBen2 for initially reporting this.

When specifying only as an array, including a non-existing part throws:

TypeError: this.config.resolvedDependencies[f] is undefined

This should either throw a more descriptive error, or be handled more gracefully.

The problem lies in line 21 of shape.js

let skirtLength = measurements.naturalWaistToKnee + options.lengthBonus + options.hem;

But skirtLength is a percentage option. So it should be something like:

let skirtLength = measurements.naturalWaistToKnee * 1 +  options.lengthBonus)

I also think it makes more sense to draw the exact skirt, and handle the hem length in SA since that's how it's on all other patterns (just to clarify why I left it out of the updated code)

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating conf in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot can't resolve your JavaScript dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

Error whilst updating @babel/node in /yarn.lock:
Couldn't find any versions for "@freesewing/css-theme" that matches "beta"

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

You can mention @dependabot in the comments below to contact the Dependabot team.

@GlassSteel writes:

Anyone made the Simon shirt, that might know what I'm doing wrong? I've just about maxed out the ease options and it's still super slim cut - like, I can't bend my arm the sleeve is so slim. I'm 14.75" neck, 36.5" chest, 31" natural waist, 11" bicep, 6.5" wrist - in other words, not a big guy and I'm used to slim cuts but I can't make this one work!

Obviously, this is kind of a big deal. There's 3 things that come to mind that could cause this:

• There's a bug in Simon
• There's a bug in Brian
• The option defaults and range are poorly chosen

As reported by @paikea

Wehn running docker compose, the seed data is not populated and crashes the gatsby freesewing.org website.

Would it be possible that, when running docker compose, it always populates the seed data automatically?

GraphQL Error Encountered 2 error(s):
- Unknown field 'allFsPatron' on type 'Query'. Source: document `usersKieranklaassenFreesewingOrgSrcComponentsAppFooterJs555225342` file: `GraphQL request`
  
  GraphQL request:3:7
  2 |     {
  3 |       allFsPatron {
    |       ^
  4 |         edges {
- Unknown field 'allFsPatron' on type 'Query'.

      file: /Users/kieranklaassen/freesewing.org/src/components/patrons/list.js

Subject says it all :)

As initially reported in https://github.com/freesewing/freesewing.org/issues/64, Jaeger goes off the rails with a double-vent setup.

This happens in draftSide() with error:

(new h(...)).move(...).curve(...).split(...).pop(...).line is not a function

It should be a radio button:

• 0
• 1
• 2

but it's a slider.

The models page stays completely blank.
The console shows the following Errors:

TypeError: "r.pictureUris is undefined"
render Container.js:217
render Container.js:193
React 12
v Redux
setModels Base.js:125
componentDidMount Base.js:55
a es6.promise.js:75
M es6.promise.js:92
c _microtask.js:18
react-dom.production.min.js:194:186
TypeError: "r.pictureUris is undefined"
render Container.js:217
render Container.js:193
React 12
v Redux
setModels Base.js:125
componentDidMount Base.js:55
a es6.promise.js:75
M es6.promise.js:92
c _microtask.js:18
react-dom.production.min.js:194:186
TypeError: "r.pictureUris is undefined"
render Container.js:217
render Container.js:193
React 12
v Redux
setModels Base.js:125
componentDidMount Base.js:55
a es6.promise.js:75
M es6.promise.js:92
c _microtask.js:18
Base.js:60:12