frederiksen / classic-wix-burn-theme Goto Github PK

The culture and language attributes of the WixLocalization tag are not correctly set in the German localization ClassicTheme.xml file. I believe the tag should be:
<WixLocalization Culture="de-de" Language="1031" xmlns="http://schemas.microsoft.com/wix/2006/localization">

first of all: great work. Using your code I was able to create a bilingual setup in English and German (my software is only supporting the two at present).
I encountered some glitches however:

1. in different texts you are using device vs computer. I do understand that it might be confusing to refer to a mobile as a computer, but I´d go for consistency. Maybe another variable to be reused?
2. as I dislike abbreviations I suggest the following German: Mit der Installation akzeptieren Sie diese <a href="#">Lizenzbedingungen</a>.
3. while it is obvious that ClassicTheme.xwl must be language specific, it is less clear why banner and ClassicTheme.xml are redundant (at least in Sample2), and which of these are actually required. Also it looks like banner.png is included into the setup.exe multiple times, which is a waste of space. Can you please clarify?

Thanks, Joachim

I'm trying to apply your code on my Korean project.
I ran your app but it did not work for me. I changed system language to German and ran exe but it shows English anyway. I saw some German (Yes or No) when I click the close button to cancel the installation. I think that was from OS.
I compiled your code with wixtoolset 3.11 and visual studio 2017.
Are there any precondition that should I do?

Hi,

thank you for releasing this project on github!

I was trying out Sample2 but I can only get it to display in english.
When I run MyCoolAppSetup.exe it always starts in english.
Am I supposed to change something in the bundle.wxs? My Windows is language is set to german.

Thanks,
Magnus