frbec / jammming Goto Github PK

Great job with the React fundamentals. You update state where you should using setState. You also pass all the right props to the child. Lastly, you use the child components to render specific parts of the application. Nice work.

You did a good job on your project. You components had all the right methods in them and did what they were suppose to. Nice work on your Spotify.js file, that can definitely be challenging. Also, good work setting state, passing props and using the child components. Be careful not to mutate your state and you should be doing great. Nice job on your project.

Nice job with your Spotify.js file. A lot of users get really caught up on this good job making it through. I really like the comments you added. It helps me as a reviewer understand what the code does more quickly. Also, it makes for a good reminder if you were to come back to the code after a long time passed.

You have this code in your App.js -> addTrack method:

  addTrack (track) {
    let newState = this.state.savedTracks
    newState.push(track)
    this.setState({ savedTracks: newState })
  }

Here, you are trying to get a new copy of state but that won't work. newState is a direct reference to this.state.savedTracks meaning anything you do to one you do to the other. Instead you want a new copy by doing either of the following:

let newState = this.state.savedTracks.slice();
let newState = [ ...this.state.savedTracks ];

Either one will do the trick. Slice returns a new array, as does the spread operator.