fraktalio / fmodel-ts Goto Github PK
View Code? Open in Web Editor NEWFunctional Domain Modeling with Typescript
Home Page: https://fraktalio.com/fmodel-ts
License: Other
fmodel-ts's People
Contributors
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "dependabot[bot]")
Stargazers
Watchers
Forkers
mateusznakodach equilcode mahulst trendingtechnology florianbepunkt reify-joe-eckard typedfp aguerot jabrelandfmodel-ts's Issues
The `LatestVersionProvider` should return Promise
The LatestVersionProvider type is currently defined as:
export type LatestVersionProvider<E, V> = (e: E) => V | null;
shouldn't this also return a Promise since it will be doing IO?
Originally posted by @reify-joe-eckard in #508
Storybook complains about class properties with the current build target
-
I'm submitting a ...
[ ] bug report
[ ] feature request
[x] question about the decisions made in the repository
[ ] question about how to use this project -
Summary
When using this dependency in a project with storybook it will complain about the class properties defined in this module's build.
Node modules are preferably not processed by the babel loader because it slows down the startup time. -
Other information
Stacktrace:
ERROR in <snip>/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@fraktalio/fmodel-ts/build/module/lib/domain/saga.js 38:9
Module parse failed: Unexpected token (38:9)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| */
| export class Saga {
> react;
| /**
| * @constructor Creates `Saga`
@ <snip>/common/temp/node_modules/.pnpm/@[email protected]/node_modules/@fraktalio/fmodel-ts/build/module/index.js 15:0-34 15:0-34
@ ../remarks/dist/commonjs/domain/list-remark.js
@ ../remarks/dist/commonjs/index.js
@ ../component-lib/src/components/Remarks/ListRemarkDetail.tsx
@ ../component-lib/src/components/Remarks/index.tsx
@ ../component-lib/src/index.tsx
@ ./.storybook/preview.tsx
@ ./.storybook/preview.tsx-generated-config-entry.js
It looks like it is picking up the module build that is specified with build target "ESNext" in the tsconfig.module.json or this project.
I tried three things that seem to fix the issue:
- Change the target to "ES2020" in tsconfig.module.js.
- Do not expose a
"module": "build/module/index.js"in the package.json - Change storybook's webpack config to also transpile node_modules.
Both of these solutions are done in this project.
Would you accept either 1 or 2 as a PR?
Or do you have a better solution?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.