Giter Club home page Giter Club logo

jquery-fancybox's People

Contributors

fractefactos avatar

Stargazers

 avatar

Watchers

 avatar

jquery-fancybox's Issues

Update NPM package?

Hello,

Back in May you merged in my suggestion, which I greatly appreciated, but it seems like the version on NPM doesn't include my code. Is it possible for you to update that NPM package by chance? I would greatly appreciate it as I'm using this package in a current project.

Thanks!

Update Fancybox to 2.1.5

Hi,

When you get a chance, could you possibly update your version of Fancybox to 2.1.5? Trying to debug something and want to rule out the possibility that the version I'm using vs. the version another team member is using is to blame.

Thanks!

Image path within Sass file

Hello!

Maybe I'm missing something, but it seems that inside jquery.fancybox.scss, the references to images should be using the path url('../img/img-name') in order to properly load the images from the package's img directory. Is this how it should be?

When I currently use that sass file as is, I get a 404 error in the console, where the image files referenced in jquery.fancybox.scss are not found.

EDIT:
Actually, in thinking further about this, what would be nice is if there was a Sass variable with the image path, that we could then overwrite, to suit our own purposes when importing the file into our projects.

Something like:

$image-path: '.../.../node_modules/img';
@import 'jquery.fancybox';

And then the jquery.fancybox.scss file would have the following at the top:

$image-path: "../img" !default;

Thoughts?

Module not found: Error: Can't resolve 'jquery-fancybox'

Hello,

Using yarn and webpack in a Rails 4.2 project with webpacker gem.

All my other dependencies are fine but I get this error:

22:52:17 webpack.1 | ERROR in ./app/javascript/packs/story_and_rain.js
22:52:17 webpack.1 | Module not found: Error: Can't resolve 'jquery-fancybox' in '/Users/stephenmarsh/dev/story-rain-spree-camaleon/app/javascript/packs'
22:52:17 webpack.1 |  @ ./app/javascript/packs/story_and_rain.js 5:0-26
22:52:17 webpack.1 |  @ multi (webpack)-dev-server/client?http://0.0.0.0:8080 ./app/javascript/packs/story_and_rain.js
22:52:17 webpack.1 | webpack: Failed to compile.

this is my package.json:

{
  "dependencies": {
    "autoprefixer": "^7.1.1",
    "babel-core": "^6.25.0",
    "babel-loader": "7.x",
    "babel-plugin-syntax-dynamic-import": "^6.18.0",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-polyfill": "^6.23.0",
    "babel-preset-env": "^1.5.2",
    "bootstrap": "^3.3.7",
    "coffee-loader": "^0.7.3",
    "coffee-script": "^1.12.6",
    "compression-webpack-plugin": "^0.4.0",
    "css-loader": "^0.28.4",
    "extract-text-webpack-plugin": "^2.1.2",
    "file-loader": "^0.11.2",
    "fitvids.1.1.0": "^1.1.0",
    "glob": "^7.1.2",
    "handlebars": "^4.0.10",
    "jquery": "^3.2.1",
    "jquery-fancybox": "^3.1.0",
    "jquery-match-height": "^0.7.2",
    "jquery.backstretch": "^2.1.15",
    "js-yaml": "^3.8.4",
    "node-sass": "^4.5.3",
    "path-complete-extname": "^0.1.0",
    "postcss-loader": "^2.0.5",
    "postcss-smart-import": "^0.7.4",
    "precss": "^1.4.0",
    "rails-erb-loader": "^5.0.2",
    "resolve-url-loader": "^2.0.2",
    "sass-loader": "^6.0.5",
    "slick-carousel": "^1.6.0",
    "style-loader": "^0.18.2",
    "webpack": "^2.6.1",
    "webpack-manifest-plugin": "^1.1.0",
    "webpack-merge": "^4.1.0"
  },
  "devDependencies": {
    "webpack-dev-server": "^2.4.5"
  }
}

i have tried both:
require('jquery-fancybox')
and import fancyBox from 'jquery-fancybox'

I installed it with:

yarn add v0.24.6
warning No license field
[1/5] ๐Ÿ”  Resolving packages...
[2/5] ๐Ÿšš  Fetching packages...
[3/5] ๐Ÿ”—  Linking dependencies...
[4/5] ๐Ÿ“ƒ  Building fresh packages...
[5/5] โ™ป๏ธ  Cleaning modules...
success Saved 1 new dependency.
โ””โ”€ [email protected]
warning No license field
โœจ  Done in 15.71s.

I'm new to webpack, yarn, and fancybox, so any help would be appreciated. Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.