Giter Club home page Giter Club logo

etherpad-plugins's People

Contributors

clkao avatar fourplusone avatar gedion avatar johnmclear avatar peteruithoven avatar simong avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

etherpad-plugins's Issues

Line breaks disappear with style Code

Used versions

  • headings 0.1.6
  • etherpad-lite 1.3.0
  • Debian Wheezy (7.2) with abiword 2.9.2

Problem

You use the style Code from headings for a code block in your pad, for ex.:

print "Hello";
print "you!";
return 0;

If you want to export this pad to html, pdf and so on the linebreaks in the code block disappear. This looks like:

print "Hello"; print "you!"; return 0;

changing headings in a list works, but back to "normal" clears the list type. Don't do this. Keep the list style intact.

When you have an ordered (or unorded) list

  • asdsad
  • dasddas
  • sadasdads

and change the heading style in the second line (for example), you can change it to all heading types, but you cannot simply remove the heading style without a negative sideeffect:

  • when clicking on (heading) Normal, a previous list style of that line (here: bulleted, unordered list) is removed.

This should not happen.

several console errors/warnings

EPL on master branch @ v.1.2.8, only ep_headings installed:

  • [ERROR] console - Failed to load 'ep_headings/static/js/index' for 'ep_headings/main/client_hooks/aceAttribsToClasses': ReferenceError: window is not defined

after: I was experiencing some notifications of warnings (log4js via mail) when I was on the plugins page; so i shut down the server and restarted (my epl tab closed meanwhile) and opened the admin/plugins url, which triggered the above

  • [ERROR] console - Failed to load 'ep_headings/static/js/index' for 'ep_headings/main/client_hooks/aceRegisterBlockElements': ReferenceError: window is not defined

after: the scenario from above: going to the troubleshoot page in the admin panel and then back to plugins

  • also had a [ERROR] console - Failed to load 'ep_headings/static/js/index' for 'ep_headings/main/client_hooks/postAceInit': ReferenceError: window is not defined

after: more/less the same scenario

Headings vs headings2

It appears that headings is forked to headings2 with quite some extra functionality. Do you support this fork?
Then it might be nice to mention it in your readme.

l10n support can be easily doubled

Thank's for having closed the issue #26 so quickly. Maybe you can add the following file to your repository, so that it can be used by anyone (or do you prefer another way, like pull request, to ask for enhancement/modification) ?

locales/es.json

{
  "ep_heading.heading" : "Encabezado",
  "ep_heading.normal" : "Normal",
  "ep_heading.h1" : "Titulo 1",
  "ep_heading.h2" : "Titulo 2",
  "ep_heading.h3" : "Titulo 3",
  "ep_heading.h4" : "Titulo 4",
  "ep_heading.h5" : "Titulo 5",
  "ep_heading.h6" : "Titulo 6",
  "pad.chat" : "Notas"
}

locales/fr.json

{
  "ep_heading.heading" : "Titres",
  "ep_heading.normal" : "Normal",
  "ep_heading.h1" : "Titre 1",
  "ep_heading.h2" : "Titre 2",
  "ep_heading.h3" : "Titre 3",
  "ep_heading.h4" : "Titre 4",
  "ep_heading.h5" : "Titre 5",
  "ep_heading.h6" : "Titre 6",
  "pad.chat" : "Notes"
}

Add paragraph element

Maybe this is more a feature request than a bug, but paragraphs with nice width and maybe adjusted line height would be extremely helpful. At the moment all texts are way too wide.

server side hook not run?

ep_headings works fine for newly added headings. however if the content is being set by the setHTML API, the collectContentPre hook does not seem to be run and thus to existing headings are cleared.

to reproduce, start epl with ep_headings installed, create a pad call headings. then:

curl -d apikey=cat APIKEY.txt -d 'padID=headings' -d 'html=<div><h1>foo</h1><p>fofo<b>wer</b>sdf</div>' 'http://localhost:9001/api/1/setHTML'

l10n is lacking

The template used does not follow etherpadlite documentation about data localization.

For what I understood from the current documentation, the code for templates/editbarButtons.ejs should be

<li class="separator acl-write"></li>                                                                                                                                                                                                          
<li id="headings" class="acl-write">                                                                                                                                                                                                           
    <select id="heading-selection">                                                                                                                                                                                                            
        <option data-l10n-id="ep_heading.heading" value="dummy" selected></option>                                                                                                                                                             
        <option data-l10n-id="ep_heading.normal" value="-1"></option>                                                                                                                                                                          
        <option data-l10n-id="ep_heading.h1" value="0"></option>                                                                                                                                                                               
        <option data-l10n-id="ep_heading.h2" value="1"></option>                                                                                                                                                                               
        <option data-l10n-id="ep_heading.h3" value="2"></option>                                                                                                                                                                               
        <option data-l10n-id="ep_heading.h4" value="3"></option>                                                                                                                                                                               
        <option data-l10n-id="ep_heading.h5" value="4"></option>                                                                                                                                                                               
        <option data-l10n-id="ep_heading.h6" value="5"></option>                                                                                                                                                                               
    </select>                                                                                                                                                                                                                                  
</li>

A file named locales/en.json should exist with the following content:

{
  "ep_heading.heading" : "Headings",
  "ep_heading.normal" : "Normal",
  "ep_heading.h1" : "Heading 1",
  "ep_heading.h2" : "Heading 2",
  "ep_heading.h3" : "Heading 3",
  "ep_heading.h4" : "Heading 4",
  "ep_heading.h5" : "Heading 5",
  "ep_heading.h6" : "Heading 6",
  "pad.chat" : "Notes"
}

Some translations already exist in the ep_headings-trl8 plugin (see https://github.com/joker-x/etherpad-plugins/tree/master/ep_headings-trl8/locales). This latter plugin, however and unfortunately, does not work as is on a brand new installation of etherpadlite.

Font name does not change.

The name of the font does not change in the style drop down menu even after changing the character's font by using the style drop down menu. I changed the font style and later when I changed lines and went back to the font it would still show me style but not the name.

Style dropdown menu doesn’t reflect the style of selected text (Usability/Feature Request)

When I select a heading, the select box does not update to tell me which kind of heading it is—with six levels of heading, it would be quite useful if it would. It is also anti-intuitive to see the label ‘normal’ when clearly there is a heading style applied.

I realise that this is not trivial to implement: Etherpad itself is similar in that the bold and italic buttons don’t reflect the status of the selected text.

Cheers,

Linkify compatibility with latest Etherpad

I tried using the Linkify plugin in the latest Etherpad version (git version: 5dd64df) but it doesn't work, the [[...]] don't change into links.
There are no errors.

Control 1 to set heading 1

Would be nice if I can highlight text and press control 1 to make it heading 1, control 2 for heading 2 etc..

Special html characters are not masked in headers

Used versions

  • headings 0.1.6
  • etherpad-lite 1.3.0
  • Debian Wheezy (7.2) with abiword 2.9.2

Problem

If a line has been processed with headings, special html characters have not masked. This is a problem if you want to export your pad to for ex. pdf. Abiword will not load the html file with a HTML parser error.

Using these example lines as headings do not work:

You & I
This is <Paul>

These lines in style Normal this means without headings processing will be exported without a problem.

Importing HTML with headings is not properly formatted

It seems that importing HTML that includes <h1>, <h2>, .. tags messes up the formatting.

Here's a quick bash script that demonstrates what happens

#!/bin/bash
#
# Save as sethtml.sh and execute by running
# ./sethtml.sh "your api key" "a pad id" "<html><body><div><h1>Heading 1</h1><p>some text</p><h2>Heading 2</h2><p>More text</p></div></body></html>"
#
APIKEY=$1
PADID=$2
HTML=$3

curl -d"apikey=$APIKEY" -d"padID=$PADID" -d"html=$HTML" http://localhost:9001/api/1/setHTML

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.