foundryspatial / streamdepletr Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 3.0 1.11 MB

R package for assessing streamflow depletion due to groundwater pumping.

License: Other

R 100.00%

streamdepletr's People

Contributors

Stargazers

Watchers

Forkers

samzipper waternk

streamdepletr's Issues

Can't install via R Studio

Copied and ran code from your install instructions using RStudio v. 1.1.456 and R v. 3.5.1, but install failed. Removed and reinstalled Devtools.

Downloading GitHub repo szipper/streamDepletr@master
from URL https://api.github.com/repos/szipper/streamDepletr/zipball/master
Installing streamDepletr
"C:/PROGRA~~1/R/R-35~~1.1/bin/x64/R" --no-site-file --no-environ --no-save --no-restore
--quiet CMD build
"C:\Users\misty\AppData\Local\Temp\RtmpwFly9k\devtools529451532c45\szipper-streamDepletr-3405c61"
--no-resave-data --no-manual

checking for file 'C:\Users\misty\AppData\Local\Temp\RtmpwFly9k\devtools529451532c45\szipper-streamDepletr-3405c61/DESCRIPTION' ... OK
preparing 'streamDepletr':
checking DESCRIPTION meta-information ... OK
installing the package to build vignettes
creating vignettes ... ERROR
Quitting from lines 72-82 (intro-to-streamDepletr.Rmd)
Error: processing vignette 'intro-to-streamDepletr.Rmd' failed with diagnostics:
there is no package called 'reshape2'
Execution halted
Installation failed: Command failed (1)

Infinite/zero erfc and exp terms

Under some combinations of input parameters, erfc terms approach 0 and exp term approach infinity. These are multiplied by each other so theoretically things should cancel out, but the numbers get so large (small) that R can no longer keep track of them.

Have tried converting units of inputs (e.g. [m/d] --> [m/s]) but this does not help because of the structure of the erfc and exp inputs. Currently have a kludge to adjust inputs if this happens until model is stable.

This affects hantush.R and hunt.R

Finalize naming convention

Develop consistent convention, rename existing functions, and make sure all test scripts are updated.

Write vignette

Function to add: Holzbecher (2012)

https://pdfs.semanticscholar.org/5035/736de52eb03bdead6c840a3e2e416f6371d2.pdf

clarify that it does not work with sf objects (or, make it so it does work with sf objects)

Function to add: estimating lmda

See Reeves et al. (2009) USGS and Huggins et al. (2018) JAWRA for options

Function to add: Zlotnik & Huang (1999)

Mentioned on Rathfelder (2016) pg 58

Look at review paper: any missing functions?

https://www.sciencedirect.com/science/article/pii/S0022169418302683?via%3Dihub

Function to add: Singh (2003)

Described on Rathfelder (2016) pg 57

set max_dist default to Inf in apportion functions

Convert prep_reach_dist, apportion_polygon to sf

Set up automatic checks

Travis? Look at CSHS-Hydrology

prep_reach_dist function

Takes shapefile and well location and makes reach_dist data frame

fix reach_id description for prep_reach_dist function

Incomplete sentence

Function to add: Yeh et al wedge shaped aquifers

https://www.sciencedirect.com/science/article/pii/S0022169407007056

Function to add: depletion apportionment equations

Should take as input a point and a shapefile

Check Hantush (1965)

Test: reproduce Figure 42 from Rathfelder (2016)

Please remove dependencies on rgdal, rgeos, and/or maptools

This package depends on (depends, imports or suggests) raster and one or more of the retiring packages rgdal, rgeos or maptools (https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html). Since raster 3.6.3, all use of external FOSS library functionality has been transferred to terra, making the retiring packages very likely redundant. It would help greatly if you could remove dependencies on the retiring packages as soon as possible.