fossfreedom / coverart-search-providers Goto Github PK

Would welcome any help in this area!

mutagen does not have a python3 equivalent

Currently the plugin uses mutagenx - but most distro's dont have this packaged.

Suggestion - replace the elements of the plugin that retrieves and saves coverart with gstreamer calls instead.

This gist is an example of obtaining the tag names and values:

https://gist.github.com/fossfreedom/37ee44971e9f4950e561

Gstreamer documentation here (Gst) https://lazka.github.io/pgi-docs

The Rhythmbox 3 (python3) version of this plugin does not extract embedded coverart. This is because the plugin uses the mutagen python library that has not as yet been ported to python3.

Given the very slow progress of the current port of mutagen, I suspect when (or if) the python library is finally finished it will probably miss the inclusion into Ubuntu 14.04 LTS.

There is a python3 derivative of mutagen called mutagenx. Lets use this library if installed.

I've already created the debian python3 version mutagen - should be simple to replace the package name for mutagenx and thus include this as the dependency within my PPA

lets investigate getting all requested search providers to be searched for at the same time - but processed in the order given by the user.

This should make stuff faster to appear.

Hello, I am unable to enable the plugin. (Manjaro 16.06.1) It seems to be an issue with the python plugin loader. Here is my terminal output:

(rhythmbox:19430): Rhythmbox-WARNING **: Unable to start mDNS browsing: MDNS service is not running

(rhythmbox:19430): libdmapsharing-WARNING **: Unable to initialize mDNS: Daemon not running

(rhythmbox:19430): libdmapsharing-WARNING **: Unable to notify network of media sharing: The avahi MDNS service is not running
/usr/lib/rhythmbox/plugins/equalizer/Conf.py:20: PyGIWarning: GConf was imported without specifying a version first. Use gi.require_version('GConf', '2.0') before import to ensure that the right version gets loaded.
  from gi.repository import GConf, Gst
Traceback (most recent call last):
  File "/usr/lib/rhythmbox/plugins/equalizer/equalizer.py", line 38, in do_activate
    self.eq = Gst.ElementFactory.make('equalizer-10bands', None)
  File "/usr/lib/python3.5/site-packages/gi/overrides/Gst.py", line 217, in make
    return Gst.ElementFactory.make(factory_name, instance_name)
  File "/usr/lib/python3.5/site-packages/gi/overrides/Gst.py", line 348, in fake_method
    raise NotInitialized("Please call Gst.init(argv) before using GStreamer")
gi.overrides.Gst.NotInitialized: Please call Gst.init(argv) before using GStreamer

This is were I enabled the plugin:

(rhythmbox:19430): libpeas-WARNING **: The 'python' plugin loader has not been enabled

(rhythmbox:19430): libpeas-CRITICAL **: peas_engine_create_extensionv: assertion 'peas_plugin_info_is_loaded (info)' failed

(rhythmbox:19430): libpeas-CRITICAL **: peas_engine_create_extensionv: assertion 'peas_plugin_info_is_loaded (info)' failed

This issue also effects the coverart browser plugin, since I cannot use that plugin without enabling this one. Also your AUR link on the main page does not work.

Same issue as #7, but for Ubtuntu/Ubuntu GNOME:

mjg@montbard:~$ sudo apt-get install rhythmbox-plugin-coverart-search 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies.
 rhythmbox-plugin-coverart-search : Depends: python3-imaging but it is not installable
E: Unable to correct problems, you have held broken packages.
mjg@montbard:~$ apt-cache search python3-pil
python3-pil.imagetk - Python Imaging Library - ImageTk Module (Python3)
python3-pil - Python Imaging Library (Python3)
python3-pil-dbg - Python Imaging Library (Python3 debug extension)
python3-pil.imagetk-dbg - Python Imaging Library - ImageTk Module (Python3 debug extension)
mjg@montbard:~$ 

For motivation, see
fossfreedom/coverart-browser#232

To uninstall, I did:

$ su
# cd /usr/share/locale
# find . -name coverart_*.mo -delete # superfluous after uninstalling coverart-browser
# rm /usr/share/glib-2.0/schemas/org.gnome.rhythmbox.plugins.coverart_search_providers.gschema.xml
# glib-compile-schemas /usr/share/glib-2.0/schemas/
# exit
$ rm -r ~/.local/share/rhythmbox/plugins/coverart_search_providers/

I hope you will consider adding an uninstall script. Thanks.

as title says - spotify has a free api we can use

from #11

whilst the above is the main issue - for this release, lets just disable discogs.

We'll need to ensure that if discogs was the sole provider, we default to something else. Otherwise, just hide discogs from being chosen and no longer taking into account in the list of search providers.

No need to delete the code - just comment out appropriately.

On Debian Jessie, the python3-imaging was seams to be replaced by python3-pil. May you update the instruction.

Thanks

lets investigate this to see if its useful as a source

• http://developer.echonest.com/docs/v4

... quick google reveals this plugin as well

https://github.com/bostonbusmap/rhythmbox-echonest

creative commons music for some rather unusual album-art and artist details.

http://freemusicarchive.org/api/docs

Hello,
First thanks for the great plugin. Can you add a possibility to download the cover art for the single.
eg if I have the song : When I'm Gone by Eminem in the album Curtains Call, the plugin search for the cover art of the album. My suggestion is to search first for the cover art for When I'm Gone, and then search for the album.

Sorry for my english. Have a great day

recent change from discogs forces rate limited and authenticated url retrieval.

discogs client does not have a method or class to retrieve such images

Hi,
It doesn't work for me. See the attached image.

In rhythmbox 3.0.1, "CoverArt Browser Search Providers" could not be loaded. It just says an error occurred. I installed both this plugin and coverart browser as per the 3.0 instructions in the READMEs.

I got this log:

Traceback (most recent call last):
  File "/home/adrusi/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_search_providers.py", line 33, in <module>
    from coverart_album_search import CoverAlbumSearch
  File "/home/adrusi/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 35, in <module>
    import discogs_client as discogs
  File "/home/adrusi/.local/share/rhythmbox/plugins/coverart_search_providers/discogs_client.py", line 4, in <module>
    import requests
ImportError: No module named 'requests'

Hello,
I have just installed Ubuntu 14.04 beta and as a result I have the latest version (or so I think), I am able now to do bug repport
The title of the window "Search Preferences" isn't translated and seems not translatable in the po file (looking for "Search Preferences" in the po file and it doesn't exist.).
Am I right ?

Tnak you for the work, it is amazing.

I had to install the following packages before I could get this plugin to work on Arch Linux:

• python-pillow
• python-chardet
• python-mutagen (as mentioned already in the readme)

There might be more dependencies that I had installed already, but at least the above libraries are required.

Ubuntu has a service that provides artist and album art. Can we use this?

https://launchpad.net/thumbnailer

http://developer.ubuntu.com/en/blog/2015/08/17/fast-thumbnailer-ubuntu/

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Fedora
(Korora 21)
Gnome 3.14.2

As requested, Terminal output, though doubtlessly useless.

(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist


(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist


(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist


(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist


(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist


(rhythmbox:26536): Gtk-WARNING **: Duplicate child name in GtkStack: Add to Playlist

minor changes upstream need to be sync'd

• GNOME/rhythmbox@c842838...ff7bc8f

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

lets investigate this coverart provider

• https://github.com/cweichen/pygn

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

have seen the following error:

Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 125, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value
Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 125, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 144, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value

more tracing:

(14:33:06) [0x841bb60] [CoverSearch.next_search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:144: next search
(14:33:06) [0x841bb60] [CoverSearch.next_search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:145: True
(14:33:06) [0x841bb60] [CoverSearch.next_search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:156: calling search
(14:33:06) [0x841bb60] [CoverSearch.next_search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:157: 
(14:33:07) [0x841bb60] [CoverAlbumSearch.search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:324: calling search
(14:33:07) [0x841bb60] [CoverAlbumSearch.search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:342: searching for local art for file:///home/dad/Music/ACDC_-_Back_In_Black-sample.ogg
(14:33:07) [0x841bb60] [CoverSearch.next_search] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:159: end of next_search TRUE
(14:33:08) [0x841bb60] [CoverAlbumSearch.get_embedded_image] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:379: get_embedded_image
(14:33:08) [0x841bb60] [CoverAlbumSearch._enum_dir_cb] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:261: okay, probably done: Argument 1 does not allow None as a value
Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 125, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value
(14:33:09) [0x841bb60] [CoverAlbumSearch.get_embedded_image] /home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py:379: get_embedded_image
Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 125, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 144, in _enum_dir_cb
    self.finished(results)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 112, in finished
    found = self.get_embedded_image(uri)
  File "/home/dad/.local/share/rhythmbox/plugins/coverart_search_providers/coverart_album_search.py", line 194, in get_embedded_image
    key = RB.ExtDBKey.create_storage("album", self.album)
TypeError: Argument 1 does not allow None as a value

Hi,

Running Ubuntu 16.04 & RB v3.3 but same behavior in Ubuntu 14.04.

As soon as I activate coverart-search-providers in RB some parts of the UI fall back to english (instead of french in my case) : play queue / «all» in title, artist, genre / duration & number of files in lower state bar / by & from in top panel…

De-activate plugin gets expected french words back.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

All the internet providers have rate limiting requirements.

We are currently doing stuff not efficiently or in breach of those requirements.

Lets make sure that where we have previously done a seach we use a gdk_idle_add type calculation rather than a hardcoded "sleep" statement - should speed stuff up.

Also make sure where we do a repeated search (search_next) - we use rate limiting - currently we don't

Spotify - 120 requests per minute

LastFM - 5 requests per second

• http://www.last.fm/api/tos

Music Brainz - 1 request per second

• https://musicbrainz.org/doc/XML_Web_Service/Rate_Limiting

CoverArt Archive - same as Music Brainz